From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B676FC433E6 for ; Sun, 30 Aug 2020 09:11:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 96260207DA for ; Sun, 30 Aug 2020 09:11:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1598778711; bh=BWklOV6bppJJ3A+SKZXddiVUDib6q31F3dsVGTSMtbw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=pjL+vReBgje1ScK2KSUFTZE/dH/F7JwJR+l+9lpDPQBR0K/r6cEzePBtD30RUNWVX uGgf+sUbBvdPfykp60dxoJFmgGHNzVpSyh3j5sMMQCWK+qN56CGoEa/c0nyoO1vXFH ZKC0DeNXOnWobJrlrVUjD68qbIi4pyqnZLqAnyhE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728720AbgH3JLs (ORCPT ); Sun, 30 Aug 2020 05:11:48 -0400 Received: from mail.kernel.org ([198.145.29.99]:60982 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725869AbgH3JLq (ORCPT ); Sun, 30 Aug 2020 05:11:46 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5E151207BB; Sun, 30 Aug 2020 09:11:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1598778705; bh=BWklOV6bppJJ3A+SKZXddiVUDib6q31F3dsVGTSMtbw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Ai0UuHTnZlo4wf/I5Ov08/TrKTmcZtSZYe3sSmtFPMekal3JdcbUjzjqFbnUO+Xal 3yu7jLxoRUMmC3+CDPYPEQ3UI5NZnEfFVp9S1Y2s6awOmfdpwE/crUJIFWSu1iADuB /HLt1Sk8k3z7Ye5JS2yTFeHHb/XaDjL5nXdJ7wQA= Date: Sun, 30 Aug 2020 11:11:42 +0200 From: Greg Kroah-Hartman To: Joe Perches Cc: LKML , Denis Efremov , "Rafael J. Wysocki" , Kees Cook , "Gustavo A . R . Silva" , Julia Lawall , Alex Dewar , York Sun , Borislav Petkov , Mauro Carvalho Chehab , Tony Luck , James Morse , Robert Richter , Michal Simek , Boris Brezillon , Maxim Levitsky , Alex Dubov , Ulf Hansson , Tomas Winkler , Arnd Bergmann , Madalin Bucur , "David S. Miller" , Jakub Kicinski , Douglas Miller , Stanislav Yakovlev , Kalle Valo , Darren Hart , Andy Shevchenko , Kai =?iso-8859-1?Q?M=E4kisara?= , "James E.J. Bottomley" , "Martin K. Petersen" , Mark Brown , Oliver Neukum , Pete Zaitcev , linux-edac@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-i3c@lists.infradead.org, linux-mmc@vger.kernel.org, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-scsi@vger.kernel.org, linux-spi@vger.kernel.org, linux-usb@vger.kernel.org Subject: Re: sysfs output without newlines Message-ID: <20200830091142.GC112265@kroah.com> References: <0f837bfb394ac632241eaac3e349b2ba806bce09.camel@perches.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0f837bfb394ac632241eaac3e349b2ba806bce09.camel@perches.com> Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Sat, Aug 29, 2020 at 11:23:43AM -0700, Joe Perches wrote: > While doing an investigation for a possible treewide conversion of > sysfs output using sprintf/snprintf/scnprintf, I discovered > several instances of sysfs output without terminating newlines. > > It seems likely all of these should have newline terminations > or have the \n\r termination changed to a single newline. > > Anyone have any objection to patches adding newlines to these > in their original forms using sprintf/snprintf/scnprintf? No objection for me, patches for my subsystems will be gladly taken. thanks, greg k-h