From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44272C433E2 for ; Mon, 31 Aug 2020 15:16:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1C1D920936 for ; Mon, 31 Aug 2020 15:16:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="HWb+Kqmb" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728363AbgHaPQ5 (ORCPT ); Mon, 31 Aug 2020 11:16:57 -0400 Received: from mail29.static.mailgun.info ([104.130.122.29]:59175 "EHLO mail29.static.mailgun.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728213AbgHaPQy (ORCPT ); Mon, 31 Aug 2020 11:16:54 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1598887013; h=Date: Message-Id: Cc: To: References: In-Reply-To: From: Subject: Content-Transfer-Encoding: MIME-Version: Content-Type: Sender; bh=ysYzo+Er7KVYGGas/Ij6Cr6vjIBlCSJyFLaEx6zU4E4=; b=HWb+Kqmbxz7n/8a5/ZOrV7OE4iCfuXV5AuLGlNQKmTLShPtxATR5mn6QgQvNS9LaIg9N4X3f M0ySRD9R2GuXlmG2oiQ5FCukSJ4NKZ9GVMaJwpdhABLbQu73uj0GskxC7pEVCEvjqecRr8Ms L1Gx/lCRDqDeQj1+CoakhuIH3cg= X-Mailgun-Sending-Ip: 104.130.122.29 X-Mailgun-Sid: WyI3YTAwOSIsICJsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n03.prod.us-east-1.postgun.com with SMTP id 5f4d1464947f606f7e65d837 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Mon, 31 Aug 2020 15:16:52 GMT Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 4D014C43395; Mon, 31 Aug 2020 15:16:52 +0000 (UTC) Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id CF877C433CB; Mon, 31 Aug 2020 15:16:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org CF877C433CB Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH][next] ath11k: fix missing error check on call to ath11k_pci_get_user_msi_assignment From: Kalle Valo In-Reply-To: <20200819111452.52419-1-colin.king@canonical.com> References: <20200819111452.52419-1-colin.king@canonical.com> To: Colin King Cc: "David S . Miller" , Jakub Kicinski , Carl Huang , ath11k@lists.infradead.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org User-Agent: pwcli/0.1.0-git (https://github.com/kvalo/pwcli/) Python/3.5.2 Message-Id: <20200831151652.4D014C43395@smtp.codeaurora.org> Date: Mon, 31 Aug 2020 15:16:52 +0000 (UTC) Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Colin King wrote: > The return error check on the call to ath11k_pci_get_user_msi_assignment is > missing. If an error does occur, num_vectors is still set to zero and > later on a division by zero can occur when variable vector is being > calculated. Fix this by adding an error check after the call. > > Addresses-Coverity: ("Division or modulo by zero") > Fixes: d4ecb90b3857 ("ath11k: enable DP interrupt setup for QCA6390") > Signed-off-by: Colin Ian King > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. b2c094582e38 ath11k: fix missing error check on call to ath11k_pci_get_user_msi_assignment -- https://patchwork.kernel.org/patch/11723523/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches