From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1C39C43461 for ; Wed, 16 Sep 2020 19:02:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3FF49206B2 for ; Wed, 16 Sep 2020 19:02:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="FPK/6jzm" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727931AbgIPTCW (ORCPT ); Wed, 16 Sep 2020 15:02:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35720 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727496AbgIPRst (ORCPT ); Wed, 16 Sep 2020 13:48:49 -0400 Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B50F6C0086BE for ; Wed, 16 Sep 2020 06:44:59 -0700 (PDT) Received: by mail-wm1-x343.google.com with SMTP id l9so3108778wme.3 for ; Wed, 16 Sep 2020 06:44:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=4dl2E36IT++Epfaf89pf4ocS2i76rCOis/+URY5PLmQ=; b=FPK/6jzmYFbA+D673b79HCVgLqvHTYf/fbXTB3/wEVBKsD3TjfAL2Ysp8udcHucQmH ksOMEe403/ORGrd8qmCWb9XVg/tMbdUYvTZSsi16bDZRxZcFP8VKwFJxcv6ByjsCcuGd qpXDgMXHKcZJKmXEOuouiUcIDBcAxSPSBPoMQcVhQc5/eHUCevr3ADjvFoR7zHEOJzVw BAfrA0QyiRE1FY6vbRYHf+oNpVTMcnTInjEqvHAQgZO2+D5ISCre/PtxF2BrnPLtUcup wIBNz/2NzpQMFp+Mgkg+ZExTyQxBX4vei9FZ/a4mdxnnGjBh3hMAljhqsd7CuUn+56c8 ryxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=4dl2E36IT++Epfaf89pf4ocS2i76rCOis/+URY5PLmQ=; b=cVZNeJOnylgtRZy6cWztxnB0PXQoDzzJUE4rUNTXp2D+deFU7EStUSO+459Vqn7DQx sejxVT9SIdK+69mGgAuQB+hgAylUSn5hOlY5VLwYHi/li2rt6bsLlwwrTG7xo+Bf9Dcq j9Z+sR1PJ/egSQen3kthoWuEcIRNS0ZWdX3UatPtOKbOXqkW9+sL582h2V0EZ0Zt3hgr 6H3HzitH5Fl99pYYlT9AX8izlM+8VdvVwetnC/oIJKU/V1d7mBX2pLYSb1ScbLoZRYuF yaYvHc6fWStyukANngUOx1SlX5oHt4KlaNX7jeoIwfiV5c6/ASVGGtHMIe5Cjdj2nLEC 4WNQ== X-Gm-Message-State: AOAM530glBUfpmWxQ0Sz0PVj3J7hL/fZmai7+P2V41DHUOVJZ1cNJNNC XQzpNwRdOIgN+eLMwCdCJquRsw== X-Google-Smtp-Source: ABdhPJzIStvqGlvQyfrjasZ1DnHHZ9nJu8xB5ntjy2TO3DIc6VErhfegcv/LA1Hbwnd1PFEqlvlZkA== X-Received: by 2002:a1c:7215:: with SMTP id n21mr5123028wmc.154.1600263898338; Wed, 16 Sep 2020 06:44:58 -0700 (PDT) Received: from dell ([91.110.221.204]) by smtp.gmail.com with ESMTPSA id z7sm33064936wrw.93.2020.09.16.06.44.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Sep 2020 06:44:57 -0700 (PDT) Date: Wed, 16 Sep 2020 14:44:55 +0100 From: Lee Jones To: Allen Pais Cc: kvalo@codeaurora.org, kuba@kernel.org, jirislaby@kernel.org, mickflemm@gmail.com, mcgrof@kernel.org, chunkeey@googlemail.com, Larry.Finger@lwfinger.net, stas.yakovlev@gmail.com, helmut.schaa@googlemail.com, pkshih@realtek.com, yhchuang@realtek.com, dsd@gentoo.org, kune@deine-taler.de, keescook@chromium.org, ath11k@lists.infradead.org, linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, b43-dev@lists.infradead.org, brcm80211-dev-list.pdl@broadcom.com, brcm80211-dev-list@cypress.com, Allen Pais , Romain Perier Subject: Re: [PATCH 10/16] wireless: intersil: convert tasklets to use new tasklet_setup() API Message-ID: <20200916134455.GD4678@dell> References: <20200817090637.26887-1-allen.cryptic@gmail.com> <20200817090637.26887-11-allen.cryptic@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200817090637.26887-11-allen.cryptic@gmail.com> Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Mon, 17 Aug 2020, Allen Pais wrote: > From: Allen Pais > > In preparation for unconditionally passing the > struct tasklet_struct pointer to all tasklet > callbacks, switch to using the new tasklet_setup() > and from_tasklet() to pass the tasklet pointer explicitly > and remove .data field. > > Signed-off-by: Romain Perier > Signed-off-by: Allen Pais > --- > .../net/wireless/intersil/hostap/hostap_hw.c | 18 +++++++++--------- > drivers/net/wireless/intersil/orinoco/main.c | 7 +++---- > drivers/net/wireless/intersil/p54/p54pci.c | 8 ++++---- > 3 files changed, 16 insertions(+), 17 deletions(-) This patch seems to cause several warnings along the lines of: drivers/net/wireless/intersil/hostap/hostap_hw.c: In function ‘prism2_init_local_data’: drivers/net/wireless/intersil/hostap/hostap_hw.c:3185:48: warning: cast between incompatible function types from ‘void (*)(struct tasklet_struct *)’ to ‘void (*)(long unsigned int)’ [-Wcast-function-type] 3185 | do { memset((q), 0, sizeof(*(q))); (q)->func = (void(*)(unsigned long))(f); } | ^ drivers/net/wireless/intersil/hostap/hostap_hw.c:3187:2: note: in expansion of macro ‘HOSTAP_TASKLET_INIT’ 3187 | HOSTAP_TASKLET_INIT(&local->bap_tasklet, hostap_bap_tasklet, | ^~~~~~~~~~~~~~~~~~~ drivers/net/wireless/intersil/hostap/hostap_hw.c:3185:48: warning: cast between incompatible function types from ‘void (*)(struct tasklet_struct *)’ to ‘void (*)(long unsigned int)’ [-Wcast-function-type] -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog