From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA0EEC4727F for ; Wed, 30 Sep 2020 10:45:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 81A432074A for ; Wed, 30 Sep 2020 10:45:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601462711; bh=gGzRaDxmnzYQQAp4vf2ECSVh//FBu7bCpbe1lpzOsj0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=Wf/Y/PYMcNRFonqELHPgwLkbJJweuI6EL/ZkEuLNW673BkESMdlipOucdzSI9VCNP hCkfR2lpSr6iJfbTU3S90qrvqNR8QeFHQFsWQCdPT8JQKXW1qtBxOVl+wpEJxy47oY QwW5TetVv10iU24F+3kIScUJteFGTuFT2CMIlelo= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729086AbgI3KpE (ORCPT ); Wed, 30 Sep 2020 06:45:04 -0400 Received: from mail.kernel.org ([198.145.29.99]:34250 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725776AbgI3KpE (ORCPT ); Wed, 30 Sep 2020 06:45:04 -0400 Received: from localhost (unknown [213.57.247.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 81E212074A; Wed, 30 Sep 2020 10:45:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601462703; bh=gGzRaDxmnzYQQAp4vf2ECSVh//FBu7bCpbe1lpzOsj0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=FNMBVYGLa/mPrIp1u0ApI3K1m/Yfbp7KHz6L/PC12vti2RR0l8aTJzkm2c8uVooQH +Dl0pN/nAql2WAYqQbc4QHlNRiiLBy1x7UJcxnygxkNU3pM76Qgal+OcvXwHY8KGG+ Pus+8wqfET9Ak1nVj+Sn/G5rnvGaYJTL/xD4aToI= Date: Wed, 30 Sep 2020 13:44:59 +0300 From: Leon Romanovsky To: Johannes Berg Cc: Kalle Valo , Srinivasan Raju , mostafa.afgani@purelifi.com, "David S. Miller" , Jakub Kicinski , Mauro Carvalho Chehab , Rob Herring , linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH] [v2] wireless: Initial driver submission for pureLiFi devices Message-ID: <20200930104459.GO3094@unreal> References: <20200924151910.21693-1-srini.raju@purelifi.com> <20200928102008.32568-1-srini.raju@purelifi.com> <20200930051602.GJ3094@unreal> <87d023elrc.fsf@codeaurora.org> <20200930095526.GM3094@unreal> <1449cdbe49b428b7d16a199ebc4c9aef73d6564c.camel@sipsolutions.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1449cdbe49b428b7d16a199ebc4c9aef73d6564c.camel@sipsolutions.net> Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Wed, Sep 30, 2020 at 12:11:24PM +0200, Johannes Berg wrote: > On Wed, 2020-09-30 at 12:55 +0300, Leon Romanovsky wrote: > > On Wed, Sep 30, 2020 at 11:01:27AM +0300, Kalle Valo wrote: > > > Leon Romanovsky writes: > > > > > > > > diff --git a/drivers/net/wireless/purelifi/Kconfig > > > > b/drivers/net/wireless/purelifi/Kconfig > > > > > new file mode 100644 > > > > > index 000000000000..ff05eaf0a8d4 > > > > > --- /dev/null > > > > > +++ b/drivers/net/wireless/purelifi/Kconfig > > > > > @@ -0,0 +1,38 @@ > > > > > +# SPDX-License-Identifier: GPL-2.0 > > > > > +config WLAN_VENDOR_PURELIFI > > > > > + bool "pureLiFi devices" > > > > > + default y > > > > > > > > "N" is preferred default. > > > > > > In most cases that's true, but for WLAN_VENDOR_ configs 'default y' > > > should be used. It's the same as with NET_VENDOR_. > > > > I would like to challenge it, why is that? > > Why do I need to set "N", every time new vendor upstreams its code? > > You don't. The WLAN_VENDOR_* settings are not supposed to affect the > build, just the Kconfig visibility. Which is important to me, I'm keeping .config as minimal as possible to simplify comparison between various builds. Thanks