From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F102AC388F9 for ; Sat, 7 Nov 2020 11:32:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B7D94206F4 for ; Sat, 7 Nov 2020 11:32:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="Yzp3nnPR" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727861AbgKGLcu (ORCPT ); Sat, 7 Nov 2020 06:32:50 -0500 Received: from m42-4.mailgun.net ([69.72.42.4]:54103 "EHLO m42-4.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727298AbgKGLct (ORCPT ); Sat, 7 Nov 2020 06:32:49 -0500 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1604748769; h=Date: Message-Id: Cc: To: References: In-Reply-To: From: Subject: Content-Transfer-Encoding: MIME-Version: Content-Type: Sender; bh=J5hlXp8ODgBGWRCIR8UQ6KIXJevlP1gpseMXY6FOGNQ=; b=Yzp3nnPR9sX915K9ZxasdDR/6AkAxZQ01TlM55oW1ni/aChXlCZZ3Z986WFi/HXr60ntB7DA JMP1Vu4ElkM+jgJj0JI81hWpKXPJ8QlVoONv8e1GHLPPXKgj+bvXq2QTz1kp9y6j7JHfW9cr pozF/CJgeXnpwhKgP6QKzR/Bp3s= X-Mailgun-Sending-Ip: 69.72.42.4 X-Mailgun-Sid: WyI3YTAwOSIsICJsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n03.prod.us-west-2.postgun.com with SMTP id 5fa685e061a7f890a695a76e (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Sat, 07 Nov 2020 11:32:48 GMT Sender: kvalo=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id A4EBEC433FE; Sat, 7 Nov 2020 11:32:48 +0000 (UTC) Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id 24BC6C433C8; Sat, 7 Nov 2020 11:32:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 24BC6C433C8 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] rsi: Fix TX EAPOL packet handling against iwlwifi AP From: Kalle Valo In-Reply-To: <20201015111616.429220-1-marex@denx.de> References: <20201015111616.429220-1-marex@denx.de> To: Marek Vasut Cc: netdev@vger.kernel.org, Marek Vasut , Angus Ainslie , "David S . Miller" , Jakub Kicinski , Lee Jones , Martin Kepplinger , Sebastian Krzyszkowiak , Siva Rebbagondla , linux-wireless@vger.kernel.org User-Agent: pwcli/0.1.0-git (https://github.com/kvalo/pwcli/) Python/3.5.2 Message-Id: <20201107113248.A4EBEC433FE@smtp.codeaurora.org> Date: Sat, 7 Nov 2020 11:32:48 +0000 (UTC) Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Marek Vasut wrote: > In case RSI9116 SDIO WiFi operates in STA mode against Intel 9260 in AP mode, > the association fails. The former is using wpa_supplicant during association, > the later is set up using hostapd: > > iwl$ cat hostapd.conf > interface=wlp1s0 > ssid=test > country_code=DE > hw_mode=g > channel=1 > wpa=2 > wpa_passphrase=test > wpa_key_mgmt=WPA-PSK > iwl$ hostapd -d hostapd.conf > > rsi$ wpa_supplicant -i wlan0 -c <(wpa_passphrase test test) > > The problem is that the TX EAPOL data descriptor RSI_DESC_REQUIRE_CFM_TO_HOST > flag and extended descriptor EAPOL4_CONFIRM frame type are not set in case the > AP is iwlwifi, because in that case the TX EAPOL packet is 2 bytes shorter. > > The downstream vendor driver has this change in place already [1], however > there is no explanation for it, neither is there any commit history from which > such explanation could be obtained. > > [1] https://github.com/SiliconLabs/RS911X-nLink-OSD/blob/master/rsi/rsi_91x_hal.c#L238 > > Signed-off-by: Marek Vasut > Cc: Angus Ainslie > Cc: David S. Miller > Cc: Jakub Kicinski > Cc: Kalle Valo > Cc: Lee Jones > Cc: Martin Kepplinger > Cc: Sebastian Krzyszkowiak > Cc: Siva Rebbagondla > Cc: linux-wireless@vger.kernel.org > Cc: netdev@vger.kernel.org Patch applied to wireless-drivers-next.git, thanks. 65277100caa2 rsi: Fix TX EAPOL packet handling against iwlwifi AP -- https://patchwork.kernel.org/project/linux-wireless/patch/20201015111616.429220-1-marex@denx.de/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches