linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] net: wireless: zydas: Prefer pr_err over printk error msg
@ 2021-05-06  4:48 Saurav Girepunje
  2021-06-15 13:37 ` zd1211rw: " Kalle Valo
  0 siblings, 1 reply; 2+ messages in thread
From: Saurav Girepunje @ 2021-05-06  4:48 UTC (permalink / raw)
  To: dsd, kune, kvalo, davem, kuba, linux-wireless, netdev, linux-kernel
  Cc: saurav.girepunje

In zd_usb.c usb_init we can prefer pr_err() over printk KERN_ERR
log level.

Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com>
---
 drivers/net/wireless/zydas/zd1211rw/zd_usb.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/wireless/zydas/zd1211rw/zd_usb.c b/drivers/net/wireless/zydas/zd1211rw/zd_usb.c
index 5c4cd0e1adeb..a7ceef10bf6a 100644
--- a/drivers/net/wireless/zydas/zd1211rw/zd_usb.c
+++ b/drivers/net/wireless/zydas/zd1211rw/zd_usb.c
@@ -1544,14 +1544,14 @@ static int __init usb_init(void)

 	zd_workqueue = create_singlethread_workqueue(driver.name);
 	if (zd_workqueue == NULL) {
-		printk(KERN_ERR "%s couldn't create workqueue\n", driver.name);
+		pr_err("%s couldn't create workqueue\n", driver.name);
 		return -ENOMEM;
 	}

 	r = usb_register(&driver);
 	if (r) {
 		destroy_workqueue(zd_workqueue);
-		printk(KERN_ERR "%s usb_register() failed. Error number %d\n",
+		pr_err("%s usb_register() failed. Error number %d\n",
 		       driver.name, r);
 		return r;
 	}
--
2.25.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: zd1211rw: Prefer pr_err over printk error msg
  2021-05-06  4:48 [PATCH] net: wireless: zydas: Prefer pr_err over printk error msg Saurav Girepunje
@ 2021-06-15 13:37 ` Kalle Valo
  0 siblings, 0 replies; 2+ messages in thread
From: Kalle Valo @ 2021-06-15 13:37 UTC (permalink / raw)
  To: Saurav Girepunje
  Cc: dsd, kune, davem, kuba, linux-wireless, netdev, linux-kernel,
	saurav.girepunje

Saurav Girepunje <saurav.girepunje@gmail.com> wrote:

> In zd_usb.c usb_init we can prefer pr_err() over printk KERN_ERR
> log level.
> 
> Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com>

Patch applied to wireless-drivers-next.git, thanks.

29d97219f403 zd1211rw: Prefer pr_err over printk error msg

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20210506044838.GA7260@user/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-06-15 13:38 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-06  4:48 [PATCH] net: wireless: zydas: Prefer pr_err over printk error msg Saurav Girepunje
2021-06-15 13:37 ` zd1211rw: " Kalle Valo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).