From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D76EC433B4 for ; Sat, 15 May 2021 14:55:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2D7D3613BE for ; Sat, 15 May 2021 14:55:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232402AbhEOO4S (ORCPT ); Sat, 15 May 2021 10:56:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35514 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232277AbhEOO4C (ORCPT ); Sat, 15 May 2021 10:56:02 -0400 Received: from bues.ch (bues.ch [IPv6:2a01:138:9005::1:4]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 55796C06174A for ; Sat, 15 May 2021 07:54:46 -0700 (PDT) Received: by bues.ch with esmtpsa (Exim 4.92) (envelope-from ) id 1lhvgL-0003tZ-2m; Sat, 15 May 2021 16:54:21 +0200 Date: Sat, 15 May 2021 16:52:54 +0200 From: Michael =?UTF-8?B?QsO8c2No?= To: Zhen Lei Cc: "John W . Linville" , "David S . Miller" , linux-wireless Subject: Re: [PATCH 1/1] ssb: Fix error return code in ssb_bus_scan() Message-ID: <20210515165254.248647d0@wiggum> In-Reply-To: <20210515072949.7151-1-thunder.leizhen@huawei.com> References: <20210515072949.7151-1-thunder.leizhen@huawei.com> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/VHxs5xiuuPF0B6tDQDbV9Gg"; protocol="application/pgp-signature"; micalg=pgp-sha512 Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org --Sig_/VHxs5xiuuPF0B6tDQDbV9Gg Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Sat, 15 May 2021 15:29:49 +0800 Zhen Lei wrote: > Fix to return -EINVAL from the error handling case instead of 0, as done > elsewhere in this function. > @@ -325,6 +325,7 @@ int ssb_bus_scan(struct ssb_bus *bus, > if (bus->nr_devices > ARRAY_SIZE(bus->devices)) { > pr_err("More than %d ssb cores found (%d)\n", > SSB_MAX_NR_CORES, bus->nr_devices); > + err =3D -EINVAL; > goto err_unmap; > } > if (bus->bustype =3D=3D SSB_BUSTYPE_SSB) { Acked-by: Michael B=C3=BCsch --=20 Michael --Sig_/VHxs5xiuuPF0B6tDQDbV9Gg Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEihRzkKVZOnT2ipsS9TK+HZCNiw4FAmCf4EYACgkQ9TK+HZCN iw4NRRAA3wLGilSNBbRnorgEI3MkycTCUTOxSB3btZDByoiT0LxHgIbb6rG2Uvny wPpM/Up5O/nUHu7xZf4Rw5Zme4YFUQjQqKXPzPDHlAjsLhwqDiZnl4srE7YFMzTr IS1ebXLU4FULDhrJNN2FywRIWfa4lJO3D3Gj26v4ORD3nPURfF6Vz9iO8POctLCV tQ1Zoi4CVrJRF+sELRQvSf9gPDr/P24+ddrijHPQCE+T96GMeu1RrTkRrYFqu/AW 0ZrdHwewATcOC9GoksOOB7lbjk71NlzebRBQHL/slN/NhqN62CMM40GByATQMnpN QUnGY4fiIRL7Or20EmLFxjIygtHQh/TKv6p2IGevEWjt89k9QA2PTcSEJI2G5ij2 BhH/ThDf8utCdwp5c2ao0j1qPvHq6O+zL1jQSNU5CnsuCRtCBHXpk5GnBnRVMfCF IcYtqFuiZ0kF8YV189pN02wuN/5inPpCX7/qrruvr66P2E9dYUC2Ub15u5Dq6zOW vfmXaU2Ewcgfz0fbqaV2BjQD7RLRF4VKt7SRYETXP0YDpzyAtZ60KD9+PXn+oitV L5PYEwlYAgJ/E7ROMQhpDyn/PweCtvIDlWNtDfbISXIZLYpNLafQwjhkzl/hLox4 AmxX75V3AAEqGQViPe9fQdMwZp34xWFNd4IN/4a0g45NJJSJEBM= =GIQ2 -----END PGP SIGNATURE----- --Sig_/VHxs5xiuuPF0B6tDQDbV9Gg--