Linux-Wireless Archive on
 help / color / Atom feed
From: Randy Dunlap <>
Cc: Randy Dunlap <>,
	kernel test robot <>,
	Kalle Valo <>,
	Christian Lamparter <>,, Arnd Bergmann <>
Subject: [PATCH v3] wireless: carl9170: fix LEDS build errors & warnings
Date: Sat, 29 May 2021 20:11:34 -0700
Message-ID: <> (raw)

kernel test robot reports over 200 build errors and warnings
that are due to this Kconfig problem when CARL9170=m,
MAC80211=y, and LEDS_CLASS=m.

WARNING: unmet direct dependencies detected for MAC80211_LEDS
  Depends on [n]: NET [=y] && WIRELESS [=y] && MAC80211 [=y] && (LEDS_CLASS [=m]=y || LEDS_CLASS [=m]=MAC80211 [=y])
  Selected by [m]:
  - CARL9170_LEDS [=y] && NETDEVICES [=y] && WLAN [=y] && WLAN_VENDOR_ATH [=y] && CARL9170 [=m]

CARL9170_LEDS selects MAC80211_LEDS even though its kconfig
dependencies are not met. This happens because 'select' does not follow
any Kconfig dependency chains.

Fix this by making CARL9170_LEDS depend on MAC80211_LEDS, where
the latter supplies any needed dependencies on LEDS_CLASS.

Fixes: 1d7e1e6b1b8ed ("carl9170: Makefile, Kconfig files and MAINTAINERS")
Signed-off-by: Randy Dunlap <>
Reported-by: kernel test robot <>
Cc: Kalle Valo <>
Cc: Christian Lamparter <>
Cc: Arnd Bergmann <>
Suggested-by: Christian Lamparter <>
v2: modify as suggesed by Arnd
v3: modify as suggested by Christian

 drivers/net/wireless/ath/carl9170/Kconfig |    8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

--- linux-next-20210528.orig/drivers/net/wireless/ath/carl9170/Kconfig
+++ linux-next-20210528/drivers/net/wireless/ath/carl9170/Kconfig
@@ -16,13 +16,11 @@ config CARL9170
 config CARL9170_LEDS
 	bool "SoftLED Support"
-	depends on CARL9170
-	select MAC80211_LEDS
-	select LEDS_CLASS
-	select NEW_LEDS
 	default y
+	depends on CARL9170
+	depends on MAC80211_LEDS
-	  This option is necessary, if you want your device' LEDs to blink
+	  This option is necessary, if you want your device's LEDs to blink.
 	  Say Y, unless you need the LEDs for firmware debugging.

             reply index

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-30  3:11 Randy Dunlap [this message]
2021-05-30  9:07 ` Arnd Bergmann
2021-05-30  9:31 ` Christian Lamparter
2021-05-30 14:32   ` Randy Dunlap
2021-06-03  9:46     ` Kalle Valo
2021-06-03 15:20       ` Randy Dunlap
2021-06-03 18:10         ` Christian Lamparter
2021-06-12 10:38 ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Wireless Archive on

Archives are clonable:
	git clone --mirror linux-wireless/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-wireless linux-wireless/ \
	public-inbox-index linux-wireless

Example config snippet for mirrors

Newsgroup available over NNTP:

AGPL code for this site: git clone