From: Sergey Ryazanov <ryazanov.s.a@gmail.com>
To: Loic Poulain <loic.poulain@linaro.org>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>
Cc: netdev@vger.kernel.org, linux-wireless@vger.kernel.org
Subject: [PATCH 04/10] net: wwan: core: init port type string array using enum values
Date: Tue, 8 Jun 2021 07:02:35 +0300 [thread overview]
Message-ID: <20210608040241.10658-5-ryazanov.s.a@gmail.com> (raw)
In-Reply-To: <20210608040241.10658-1-ryazanov.s.a@gmail.com>
This array is indexed by port type. Make it self-descriptive by using
the port type enum values as indices in the array initializer.
Signed-off-by: Sergey Ryazanov <ryazanov.s.a@gmail.com>
---
drivers/net/wwan/wwan_core.c | 13 ++++++-------
1 file changed, 6 insertions(+), 7 deletions(-)
diff --git a/drivers/net/wwan/wwan_core.c b/drivers/net/wwan/wwan_core.c
index 632ff86398ac..97d77b06d222 100644
--- a/drivers/net/wwan/wwan_core.c
+++ b/drivers/net/wwan/wwan_core.c
@@ -184,13 +184,12 @@ static void wwan_remove_dev(struct wwan_device *wwandev)
/* ------- WWAN port management ------- */
-/* Keep aligned with wwan_port_type enum */
-static const char * const wwan_port_type_str[] = {
- "AT",
- "MBIM",
- "QMI",
- "QCDM",
- "FIREHOSE"
+static const char * const wwan_port_type_str[WWAN_PORT_MAX + 1] = {
+ [WWAN_PORT_AT] = "AT",
+ [WWAN_PORT_MBIM] = "MBIM",
+ [WWAN_PORT_QMI] = "QMI",
+ [WWAN_PORT_QCDM] = "QCDM",
+ [WWAN_PORT_FIREHOSE] = "FIREHOSE",
};
static ssize_t type_show(struct device *dev, struct device_attribute *attr,
--
2.26.3
next prev parent reply other threads:[~2021-06-08 4:03 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-08 4:02 [PATCH 00/10] net: WWAN subsystem improvements Sergey Ryazanov
2021-06-08 4:02 ` [PATCH 01/10] wwan_hwsim: WWAN device simulator Sergey Ryazanov
2021-06-08 4:02 ` [PATCH 02/10] wwan_hwsim: add debugfs management interface Sergey Ryazanov
2021-06-08 4:02 ` [PATCH 03/10] net: wwan: make WWAN_PORT_MAX meaning less surprised Sergey Ryazanov
2021-06-08 8:35 ` Loic Poulain
2021-06-08 4:02 ` Sergey Ryazanov [this message]
2021-06-08 8:36 ` [PATCH 04/10] net: wwan: core: init port type string array using enum values Loic Poulain
2021-06-08 4:02 ` [PATCH 05/10] net: wwan: core: spell port device name in lowercase Sergey Ryazanov
2021-06-08 8:37 ` Loic Poulain
2021-06-08 4:02 ` [PATCH 06/10] net: wwan: core: make port names more user-friendly Sergey Ryazanov
2021-06-08 4:02 ` [PATCH 07/10] net: wwan: core: expand ports number limit Sergey Ryazanov
2021-06-08 8:47 ` Loic Poulain
2021-06-08 4:02 ` [PATCH 08/10] net: wwan: core: implement TIOCINQ ioctl Sergey Ryazanov
2021-06-08 8:51 ` Loic Poulain
2021-06-08 4:02 ` [PATCH 09/10] net: wwan: core: implement terminal ioctls for AT port Sergey Ryazanov
2021-06-08 4:02 ` [PATCH 10/10] net: wwan: core: purge rx queue on port close Sergey Ryazanov
2021-06-08 21:50 ` [PATCH 00/10] net: WWAN subsystem improvements patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210608040241.10658-5-ryazanov.s.a@gmail.com \
--to=ryazanov.s.a@gmail.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=loic.poulain@linaro.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).