From: Kalle Valo <kvalo@codeaurora.org>
To: Tony Lindgren <tony@atomide.com>
Cc: Eyal Reizer <eyalr@ti.com>, Guy Mishol <guym@ti.com>,
Raz Bouganim <r-bouganim@ti.com>,
linux-wireless@vger.kernel.org, linux-omap@vger.kernel.org,
Carl Philipp Klemm <philipp@uvos.xyz>
Subject: Re: [PATCH] wlcore/wl12xx: Fix wl12xx get_mac error if device is in ELP
Date: Mon, 14 Jun 2021 15:47:50 +0000 (UTC) [thread overview]
Message-ID: <20210614154750.21551C4323A@smtp.codeaurora.org> (raw)
In-Reply-To: <20210603062814.19464-1-tony@atomide.com>
Tony Lindgren <tony@atomide.com> wrote:
> At least on wl12xx, reading the MAC after boot can fail with a warning
> at drivers/net/wireless/ti/wlcore/sdio.c:78 wl12xx_sdio_raw_read.
> The failed call comes from wl12xx_get_mac() that wlcore_nvs_cb() calls
> after request_firmware_work_func().
>
> After the error, no wireless interface is created. Reloading the wl12xx
> module makes the interface work.
>
> Turns out the wlan controller can be in a low-power ELP state after the
> boot from the bootloader or kexec, and needs to be woken up first.
>
> Let's wake the hardware and add a sleep after that similar to
> wl12xx_pre_boot() is already doing.
>
> Note that a similar issue could exist for wl18xx, but I have not seen it
> so far. And a search for wl18xx_get_mac and wl12xx_sdio_raw_read did not
> produce similar errors.
>
> Cc: Carl Philipp Klemm <philipp@uvos.xyz>
> Signed-off-by: Tony Lindgren <tony@atomide.com>
Patch applied to wireless-drivers-next.git, thanks.
11ef6bc846dc wlcore/wl12xx: Fix wl12xx get_mac error if device is in ELP
--
https://patchwork.kernel.org/project/linux-wireless/patch/20210603062814.19464-1-tony@atomide.com/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
prev parent reply other threads:[~2021-06-14 15:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-03 6:28 [PATCH] wlcore/wl12xx: Fix wl12xx get_mac error if device is in ELP Tony Lindgren
2021-06-14 15:47 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210614154750.21551C4323A@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=eyalr@ti.com \
--cc=guym@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=philipp@uvos.xyz \
--cc=r-bouganim@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).