From: Kalle Valo <kvalo@codeaurora.org>
To: "Íñigo Huguet" <ihuguet@redhat.com>
Cc: Jes.Sorensen@gmail.com, davem@davemloft.net, kuba@kernel.org,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
ihuguet@redhat.com
Subject: Re: [PATCH] rtl8xxxu: avoid parsing short RX packet
Date: Sat, 19 Jun 2021 09:06:19 +0000 (UTC) [thread overview]
Message-ID: <20210619090619.D786BC43460@smtp.codeaurora.org> (raw)
In-Reply-To: <20210511071926.8951-1-ihuguet@redhat.com>
Íñigo Huguet <ihuguet@redhat.com> wrote:
> One USB data buffer can contain multiple received network
> packets. If that's the case, they're processed this way:
> 1. Original buffer is cloned
> 2. Original buffer is trimmed to contain only the first
> network packet
> 3. This first network packet is passed to network stack
> 4. Cloned buffer is trimmed to eliminate the first network
> packet
> 5. Repeat with the cloned buffer until there are no more
> network packets inside
>
> However, if the space remaining in original buffer after
> the first network packet is not enough to contain at least
> another network packet descriptor, it is not cloned.
>
> The loop parsing this packets ended if remaining space == 0.
> But if the remaining space was > 0 but < packet descriptor
> size, another iteration of the loop was done, processing again
> the previous packet because cloning didn't happen. Moreover,
> the ownership of this packet had been passed to network
> stack in the previous iteration.
>
> This patch ensures that no extra iteration is done if the
> remaining size is not enough for one packet, and also avoid
> the first iteration for the same reason.
>
> Probably this doesn't happen in practice, but can happen
> theoretically.
>
> Signed-off-by: Íñigo Huguet <ihuguet@redhat.com>
Patch applied to wireless-drivers-next.git, thanks.
adf6a0f8c0a6 rtl8xxxu: avoid parsing short RX packet
--
https://patchwork.kernel.org/project/linux-wireless/patch/20210511071926.8951-1-ihuguet@redhat.com/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
prev parent reply other threads:[~2021-06-19 9:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-11 7:19 [PATCH] rtl8xxxu: avoid parsing short RX packet Íñigo Huguet
2021-06-01 8:57 ` Íñigo Huguet
2021-06-03 9:53 ` Kalle Valo
2021-06-19 9:06 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210619090619.D786BC43460@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=Jes.Sorensen@gmail.com \
--cc=davem@davemloft.net \
--cc=ihuguet@redhat.com \
--cc=kuba@kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).