archive mirror
 help / color / mirror / Atom feed
From: Colin King <>
To: Luca Coelho <>,
	"David S . Miller" <>,
	Jakub Kicinski <>,,
Subject: [PATCH][next] iwlwifi: Fix error return on failed kmalloc
Date: Thu, 24 Jun 2021 20:18:33 +0100	[thread overview]
Message-ID: <> (raw)

From: Colin Ian King <>

Currently the failing kmalloc sets package to the -ENOMEM error
return value however the error is returned by variable data. Fix this
by setting data to the error code instead.

Addresses-Coverity: ("Unused value")
Fixes: 9dad325f9d57 ("iwlwifi: support loading the reduced power table from UEFI")
Signed-off-by: Colin Ian King <>
 drivers/net/wireless/intel/iwlwifi/fw/uefi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/intel/iwlwifi/fw/uefi.c b/drivers/net/wireless/intel/iwlwifi/fw/uefi.c
index a7c79d814aa4..c2c8078278f7 100644
--- a/drivers/net/wireless/intel/iwlwifi/fw/uefi.c
+++ b/drivers/net/wireless/intel/iwlwifi/fw/uefi.c
@@ -229,7 +229,7 @@ void *iwl_uefi_get_reduced_power(struct iwl_trans *trans, size_t *len)
 	package = kmalloc(package_size, GFP_KERNEL);
 	if (!package) {
-		package = ERR_PTR(-ENOMEM);
+		data = ERR_PTR(-ENOMEM);
 		goto out;

                 reply	other threads:[~2021-06-24 19:18 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).