From: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
Krzysztof Opasiak <k.opasiak@samsung.com>,
Mark Greer <mgreer@animalcreek.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
linux-nfc@lists.01.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org
Subject: [PATCH v2 15/15] nfc: mrvl: drop unneeded memory allocation fail messages
Date: Mon, 13 Sep 2021 15:20:35 +0200 [thread overview]
Message-ID: <20210913132035.242870-16-krzysztof.kozlowski@canonical.com> (raw)
In-Reply-To: <20210913132035.242870-1-krzysztof.kozlowski@canonical.com>
nci_skb_alloc() already prints an error message on memory allocation
failure.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
---
drivers/nfc/nfcmrvl/fw_dnld.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/nfc/nfcmrvl/fw_dnld.c b/drivers/nfc/nfcmrvl/fw_dnld.c
index edac56b01fd1..e83f65596a88 100644
--- a/drivers/nfc/nfcmrvl/fw_dnld.c
+++ b/drivers/nfc/nfcmrvl/fw_dnld.c
@@ -76,10 +76,8 @@ static struct sk_buff *alloc_lc_skb(struct nfcmrvl_private *priv, uint8_t plen)
struct nci_data_hdr *hdr;
skb = nci_skb_alloc(priv->ndev, (NCI_DATA_HDR_SIZE + plen), GFP_KERNEL);
- if (!skb) {
- pr_err("no memory for data\n");
+ if (!skb)
return NULL;
- }
hdr = skb_put(skb, NCI_DATA_HDR_SIZE);
hdr->conn_id = NCI_CORE_LC_CONNID_PROP_FW_DL;
--
2.30.2
prev parent reply other threads:[~2021-09-13 13:26 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-13 13:20 [PATCH v2 00/15] nfc: minor printk cleanup Krzysztof Kozlowski
2021-09-13 13:20 ` [PATCH v2 01/15] nfc: drop unneeded debug prints Krzysztof Kozlowski
2021-09-13 13:20 ` [PATCH v2 02/15] nfc: do not break pr_debug() call into separate lines Krzysztof Kozlowski
2021-09-13 13:20 ` [PATCH v2 03/15] nfc: nci: replace GPLv2 boilerplate with SPDX Krzysztof Kozlowski
2021-09-13 13:20 ` [PATCH v2 04/15] nfc: fdp: drop unneeded debug prints Krzysztof Kozlowski
2021-09-13 13:20 ` [PATCH v2 05/15] nfc: pn533: " Krzysztof Kozlowski
2021-09-13 13:20 ` [PATCH v2 06/15] nfc: pn533: use dev_err() instead of pr_err() Krzysztof Kozlowski
2021-09-13 13:20 ` [PATCH v2 07/15] nfc: pn544: drop unneeded debug prints Krzysztof Kozlowski
2021-09-13 13:20 ` [PATCH v2 08/15] nfc: pn544: drop unneeded memory allocation fail messages Krzysztof Kozlowski
2021-09-13 13:20 ` [PATCH v2 09/15] nfc: s3fwrn5: simplify dereferencing pointer to struct device Krzysztof Kozlowski
2021-09-13 13:20 ` [PATCH v2 10/15] nfc: st-nci: drop unneeded debug prints Krzysztof Kozlowski
2021-09-13 13:20 ` [PATCH v2 11/15] nfc: st21nfca: " Krzysztof Kozlowski
2021-09-13 13:20 ` [PATCH v2 12/15] nfc: trf7970a: " Krzysztof Kozlowski
2021-09-13 16:57 ` Mark Greer
2021-10-07 13:01 ` Krzysztof Kozlowski
2021-10-07 13:12 ` Jakub Kicinski
2021-09-13 13:20 ` [PATCH v2 13/15] nfc: microread: " Krzysztof Kozlowski
2021-09-13 13:20 ` [PATCH v2 14/15] nfc: microread: drop unneeded memory allocation fail messages Krzysztof Kozlowski
2021-09-13 13:20 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210913132035.242870-16-krzysztof.kozlowski@canonical.com \
--to=krzysztof.kozlowski@canonical.com \
--cc=davem@davemloft.net \
--cc=k.opasiak@samsung.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfc@lists.01.org \
--cc=linux-wireless@vger.kernel.org \
--cc=mgreer@animalcreek.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).