From: Kalle Valo <kvalo@codeaurora.org>
To: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Cc: linux-wireless@vger.kernel.org, wcn36xx@lists.infradead.org,
loic.poulain@linaro.org, benl@squareup.com,
bryan.odonoghue@linaro.org
Subject: Re: [PATCH] wcn36xx: Implement Idle Mode Power Save
Date: Tue, 21 Sep 2021 13:34:44 +0000 (UTC) [thread overview]
Message-ID: <20210921133444.A7D1EC43616@smtp.codeaurora.org> (raw)
In-Reply-To: <20210909153320.2624649-1-bryan.odonoghue@linaro.org>
Bryan O'Donoghue <bryan.odonoghue@linaro.org> wrote:
> Idle Mode Power Save (IMPS) is a power saving mechanism which when called
> by wcn36xx will cause the radio hardware to enter power collapse.
>
> This particular call maps nicely to a simple conjunction/disjunction around
> IEEE80211_CONF_CHANGE_IDLE and IEEE80211_CONF_IDLE.
>
> Here we enter idle when we are not associated with an AP. The kernel will
> incrementally toggle idle on/off in the process of trying to establish a
> connection, thus saving power until we are connected to the AP again, at
> which point we give way to BMPS if power_save is on.
>
> We've validated that with IMPS an apq8039 device which has the wcn36xx
> module loaded but, has not authenticated with an AP will get to VMIN on
> suspend and will not without IMPS.
>
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
> Tested-by: Benjamin Li <benl@squareup.com>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Patch applied to ath-next branch of ath.git, thanks.
0e159d2c0834 wcn36xx: Implement Idle Mode Power Save
--
https://patchwork.kernel.org/project/linux-wireless/patch/20210909153320.2624649-1-bryan.odonoghue@linaro.org/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
prev parent reply other threads:[~2021-09-21 13:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-09 15:33 [PATCH] wcn36xx: Implement Idle Mode Power Save Bryan O'Donoghue
2021-09-21 13:34 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210921133444.A7D1EC43616@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=benl@squareup.com \
--cc=bryan.odonoghue@linaro.org \
--cc=linux-wireless@vger.kernel.org \
--cc=loic.poulain@linaro.org \
--cc=wcn36xx@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).