From: "Pali Rohár" <pali@kernel.org>
To: Rob Herring <robh+dt@kernel.org>, devicetree@vger.kernel.org
Cc: "Kalle Valo" <kvalo@codeaurora.org>,
"Jérôme Pouiller" <jerome.pouiller@silabs.com>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"David S . Miller" <davem@davemloft.net>,
linux-mmc@vger.kernel.org, "Ulf Hansson" <ulf.hansson@linaro.org>
Subject: Re: [PATCH v7 10/24] wfx: add fwio.c/fwio.h
Date: Thu, 7 Oct 2021 12:13:42 +0200 [thread overview]
Message-ID: <20211007101342.fxl74ud4xra4u3cp@pali> (raw)
In-Reply-To: <87pmshckrm.fsf@codeaurora.org>
Hello Rob! Could you look at issue below to represent antenna (pds)
firmware file requirement for this driver in DTS file?
On Thursday 07 October 2021 11:16:29 Kalle Valo wrote:
> Pali Rohár <pali@kernel.org> writes:
>
> > On Friday 01 October 2021 17:09:41 Jérôme Pouiller wrote:
> >> On Friday 1 October 2021 13:58:38 CEST Kalle Valo wrote:
> >> > Jerome Pouiller <Jerome.Pouiller@silabs.com> writes:
> >> >
> >> > > From: Jérôme Pouiller <jerome.pouiller@silabs.com>
> >> > >
> >> > > Signed-off-by: Jérôme Pouiller <jerome.pouiller@silabs.com>
> >> >
> >> > [...]
> >> >
> >> > > +static int get_firmware(struct wfx_dev *wdev, u32 keyset_chip,
> >> > > + const struct firmware **fw, int *file_offset)
> >> > > +{
> >> > > + int keyset_file;
> >> > > + char filename[256];
> >> > > + const char *data;
> >> > > + int ret;
> >> > > +
> >> > > + snprintf(filename, sizeof(filename), "%s_%02X.sec",
> >> > > + wdev->pdata.file_fw, keyset_chip);
> >> > > + ret = firmware_request_nowarn(fw, filename, wdev->dev);
> >> > > + if (ret) {
> >> > > + dev_info(wdev->dev, "can't load %s, falling back to %s.sec\n",
> >> > > + filename, wdev->pdata.file_fw);
> >> > > + snprintf(filename, sizeof(filename), "%s.sec",
> >> > > + wdev->pdata.file_fw);
> >> > > + ret = request_firmware(fw, filename, wdev->dev);
> >> > > + if (ret) {
> >> > > + dev_err(wdev->dev, "can't load %s\n", filename);
> >> > > + *fw = NULL;
> >> > > + return ret;
> >> > > + }
> >> > > + }
> >> >
> >> > How is this firmware file loading supposed to work? If I'm reading the
> >> > code right, the driver tries to load file "wfm_wf200_??.sec" but in
> >> > linux-firmware the file is silabs/wfm_wf200_C0.sec:
> >> >
> >> > https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git/tree/silabs
> >> >
> >> > That can't work automatically, unless I'm missing something of course.
> >>
> >> The firmware are signed. "C0" is the key used to sign this firmware. This
> >> key must match with the key burned into the chip. Fortunately, the driver
> >> is able to read the key accepted by the chip and automatically choose the
> >> right firmware.
> >>
> >> We could imagine to add a attribute in the DT to choose the firmware to
> >> load. However, it would be a pity to have to specify it manually whereas
> >> the driver is able to detect it automatically.
> >>
> >> Currently, the only possible key is C0. However, it exists some internal
> >> parts with other keys. In addition, it is theoretically possible to ask
> >> to Silabs to burn parts with a specific key in order to improve security
> >> of a product.
> >>
> >> Obviously, for now, this feature mainly exists for the Silabs firmware
> >> developers who have to work with other keys.
> >>
> >> > Also I would prefer to use directory name as the driver name wfx, but I
> >> > guess silabs is also doable.
> >>
> >> I have no opinion.
> >>
> >>
> >> > Also I'm not seeing the PDS files in linux-firmware. The idea is that
> >> > when user installs an upstream kernel and the linux-firmware everything
> >> > will work automatically, without any manual file installations.
> >>
> >> WF200 is just a chip. Someone has to design an antenna before to be able
> >> to use.
> >>
> >> However, we have evaluation boards that have antennas and corresponding
> >> PDS files[1]. Maybe linux-firmware should include the PDS for these boards
> >
> > So chip vendor provides firmware and card vendor provides PDS files. In
> > my opinion all files should go into linux-firmware repository. If Silabs
> > has PDS files for its devel boards (which are basically cards) then I
> > think these files should go also into linux-firmware repository.
>
> I agree, all files required for normal functionality should be in
> linux-firmware. The upstream philosophy is that a user can just install
> the latest kernel and latest linux-firmware, and everything should work
> out of box (without any manual work).
>
> > And based on some parameter, driver should load correct PDS file. Seems
> > like DT can be a place where to put something which indicates which PDS
> > file should be used.
>
> Again I agree.
>
> > But should be in DT directly name of PDS file? Or should be in DT just
> > additional compatible string with card vendor name and then in driver
> > itself should be mapping table from compatible string to filename? I do
> > not know what is better.
>
> This is also what I was wondering, to me it sounds wrong to have a
> filename in DT. I was more thinking about calling it "antenna name" (and
> not the actually filename), but using compatible strings sounds good to
> me as well. But of course DT maintainers know this better.
>
> --
> https://patchwork.kernel.org/project/linux-wireless/list/
>
> https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2021-10-07 10:13 UTC|newest]
Thread overview: 83+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-20 16:11 [PATCH v7 00/24] wfx: get out from the staging area Jerome Pouiller
2021-09-20 16:11 ` [PATCH v7 01/24] mmc: sdio: add SDIO IDs for Silabs WF200 chip Jerome Pouiller
2021-09-20 16:11 ` [PATCH v7 02/24] dt-bindings: introduce silabs,wfx.yaml Jerome Pouiller
2021-09-23 17:09 ` Rob Herring
2021-09-20 16:11 ` [PATCH v7 03/24] wfx: add Makefile/Kconfig Jerome Pouiller
2021-10-01 9:04 ` Kalle Valo
2021-10-01 9:06 ` Kalle Valo
2021-09-20 16:11 ` [PATCH v7 04/24] wfx: add wfx.h Jerome Pouiller
2021-09-20 16:11 ` [PATCH v7 05/24] wfx: add main.c/main.h Jerome Pouiller
2021-10-01 9:22 ` Kalle Valo
2021-10-01 9:44 ` Jérôme Pouiller
2021-10-01 12:18 ` Kalle Valo
2021-10-06 7:32 ` Jérôme Pouiller
2021-10-07 8:35 ` Kalle Valo
2021-10-07 10:00 ` Jérôme Pouiller
2021-10-07 10:41 ` Kalle Valo
2021-10-07 10:49 ` Kalle Valo
2021-10-07 11:22 ` Jérôme Pouiller
2021-11-10 9:58 ` Kalle Valo
2021-11-10 11:10 ` Jérôme Pouiller
2021-10-01 15:29 ` Jérôme Pouiller
2021-10-05 5:56 ` Kalle Valo
2021-10-05 8:12 ` Jérôme Pouiller
2021-09-20 16:11 ` [PATCH v7 06/24] wfx: add bus.h Jerome Pouiller
2021-09-20 16:11 ` [PATCH v7 07/24] wfx: add bus_spi.c Jerome Pouiller
2021-09-20 16:11 ` [PATCH v7 08/24] wfx: add bus_sdio.c Jerome Pouiller
2021-09-30 10:07 ` Ulf Hansson
2021-09-30 16:51 ` Jérôme Pouiller
2021-09-30 17:06 ` Pali Rohár
2021-10-01 15:23 ` Ulf Hansson
2021-10-05 8:14 ` Jérôme Pouiller
2021-10-06 15:02 ` Ulf Hansson
2021-10-06 15:42 ` Jérôme Pouiller
2021-10-07 8:26 ` Kalle Valo
2021-10-07 10:24 ` Pali Rohár
2021-10-01 15:37 ` Ulf Hansson
2021-10-05 5:59 ` Kalle Valo
2021-09-20 16:11 ` [PATCH v7 09/24] wfx: add hwio.c/hwio.h Jerome Pouiller
2021-10-01 9:52 ` Kalle Valo
2021-10-01 12:39 ` Kalle Valo
2021-09-20 16:11 ` [PATCH v7 10/24] wfx: add fwio.c/fwio.h Jerome Pouiller
2021-10-01 11:58 ` Kalle Valo
2021-10-01 15:09 ` Jérôme Pouiller
2021-10-01 16:08 ` Pali Rohár
2021-10-01 16:46 ` Jérôme Pouiller
2021-10-07 8:19 ` Kalle Valo
2021-10-07 10:10 ` Pali Rohár
2021-10-07 8:16 ` Kalle Valo
2021-10-07 10:13 ` Pali Rohár [this message]
2021-10-07 8:08 ` Kalle Valo
2021-10-07 9:35 ` Jérôme Pouiller
2021-09-20 16:11 ` [PATCH v7 11/24] wfx: add bh.c/bh.h Jerome Pouiller
2021-09-20 16:11 ` [PATCH v7 12/24] wfx: add hif_api_*.h Jerome Pouiller
2021-10-01 11:41 ` Kalle Valo
2021-10-01 11:52 ` Jérôme Pouiller
2021-10-01 12:45 ` Kalle Valo
2021-10-01 11:45 ` Kalle Valo
2021-10-01 11:48 ` Kalle Valo
2021-09-20 16:11 ` [PATCH v7 13/24] wfx: add hif_tx*.c/hif_tx*.h Jerome Pouiller
2021-10-01 9:55 ` Kalle Valo
2021-10-01 15:17 ` Jérôme Pouiller
2021-10-01 16:13 ` Pali Rohár
2021-10-05 6:12 ` Kalle Valo
2021-10-05 6:44 ` Greg Kroah-Hartman
2021-10-05 8:17 ` Jérôme Pouiller
2021-10-05 8:21 ` Greg Kroah-Hartman
2021-10-05 9:18 ` Jérôme Pouiller
2021-10-05 14:02 ` Jakub Kicinski
2021-09-20 16:11 ` [PATCH v7 14/24] wfx: add key.c/key.h Jerome Pouiller
2021-09-20 16:11 ` [PATCH v7 15/24] wfx: add hif_rx.c/hif_rx.h Jerome Pouiller
2021-10-01 10:09 ` Kalle Valo
2021-09-20 16:11 ` [PATCH v7 16/24] wfx: add data_rx.c/data_rx.h Jerome Pouiller
2021-09-20 16:11 ` [PATCH v7 17/24] wfx: add queue.c/queue.h Jerome Pouiller
2021-09-20 16:11 ` [PATCH v7 18/24] wfx: add data_tx.c/data_tx.h Jerome Pouiller
2021-09-20 16:11 ` [PATCH v7 19/24] wfx: add sta.c/sta.h Jerome Pouiller
2021-09-20 16:11 ` [PATCH v7 20/24] wfx: add scan.c/scan.h Jerome Pouiller
2021-10-01 9:35 ` Kalle Valo
2021-09-20 16:11 ` [PATCH v7 21/24] wfx: add debug.c/debug.h Jerome Pouiller
2021-10-01 12:01 ` Kalle Valo
2021-09-20 16:11 ` [PATCH v7 22/24] wfx: add traces.h Jerome Pouiller
2021-09-20 16:11 ` [PATCH v7 23/24] wfx: remove from the staging area Jerome Pouiller
2021-09-20 16:11 ` [PATCH v7 24/24] wfx: get out " Jerome Pouiller
2021-10-01 12:42 ` [PATCH v7 00/24] " Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211007101342.fxl74ud4xra4u3cp@pali \
--to=pali@kernel.org \
--cc=davem@davemloft.net \
--cc=devel@driverdev.osuosl.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jerome.pouiller@silabs.com \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).