From: "Pali Rohár" <pali@kernel.org>
To: "Jonas Dreßler" <verdre@v0yd.nl>
Cc: Amitkumar Karwar <amitkarwar@gmail.com>,
Ganapathi Bhat <ganapathi017@gmail.com>,
Xinming Hu <huxinming820@gmail.com>,
Kalle Valo <kvalo@codeaurora.org>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Tsuchiya Yuto <kitakar@gmail.com>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
Maximilian Luz <luzmaximilian@gmail.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Bjorn Helgaas <bhelgaas@google.com>
Subject: Re: [PATCH v3 4/5] mwifiex: Send DELBA requests according to spec
Date: Sun, 17 Oct 2021 10:08:56 +0200 [thread overview]
Message-ID: <20211017080856.hy3cjszegur5gumy@pali> (raw)
In-Reply-To: <20211016153244.24353-5-verdre@v0yd.nl>
On Saturday 16 October 2021 17:32:43 Jonas Dreßler wrote:
> While looking at on-air packets using Wireshark, I noticed we're never
> setting the initiator bit when sending DELBA requests to the AP: While
> we set the bit on our del_ba_param_set bitmask, we forget to actually
> copy that bitmask over to the command struct, which means we never
> actually set the initiator bit.
>
> Fix that and copy the bitmask over to the host_cmd_ds_11n_delba command
> struct.
>
> Fixes: 5e6e3a92b9a4 ("wireless: mwifiex: initial commit for Marvell mwifiex driver")
> Signed-off-by: Jonas Dreßler <verdre@v0yd.nl>
Acked-by: Pali Rohár <pali@kernel.org>
> ---
> drivers/net/wireless/marvell/mwifiex/11n.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/wireless/marvell/mwifiex/11n.c b/drivers/net/wireless/marvell/mwifiex/11n.c
> index b0695432b26a..9ff2058bcd7e 100644
> --- a/drivers/net/wireless/marvell/mwifiex/11n.c
> +++ b/drivers/net/wireless/marvell/mwifiex/11n.c
> @@ -657,14 +657,15 @@ int mwifiex_send_delba(struct mwifiex_private *priv, int tid, u8 *peer_mac,
> uint16_t del_ba_param_set;
>
> memset(&delba, 0, sizeof(delba));
> - delba.del_ba_param_set = cpu_to_le16(tid << DELBA_TID_POS);
>
> - del_ba_param_set = le16_to_cpu(delba.del_ba_param_set);
> + del_ba_param_set = tid << DELBA_TID_POS;
> +
> if (initiator)
> del_ba_param_set |= IEEE80211_DELBA_PARAM_INITIATOR_MASK;
> else
> del_ba_param_set &= ~IEEE80211_DELBA_PARAM_INITIATOR_MASK;
>
> + delba.del_ba_param_set = cpu_to_le16(del_ba_param_set);
> memcpy(&delba.peer_mac_addr, peer_mac, ETH_ALEN);
>
> /* We don't wait for the response of this command */
> --
> 2.31.1
>
next prev parent reply other threads:[~2021-10-17 8:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-16 15:32 [PATCH v3 0/5] A few more cleanups and fixes for mwifiex Jonas Dreßler
2021-10-16 15:32 ` [PATCH v3 1/5] mwifiex: Don't log error on suspend if wake-on-wlan is disabled Jonas Dreßler
2021-10-16 17:50 ` Joe Perches
2021-10-20 8:51 ` Kalle Valo
2021-10-16 15:32 ` [PATCH v3 2/5] mwifiex: Log an error on command failure during key-material upload Jonas Dreßler
2021-10-16 15:32 ` [PATCH v3 3/5] mwifiex: Fix an incorrect comment Jonas Dreßler
2021-10-16 15:32 ` [PATCH v3 4/5] mwifiex: Send DELBA requests according to spec Jonas Dreßler
2021-10-17 8:08 ` Pali Rohár [this message]
2021-10-16 15:32 ` [PATCH v3 5/5] mwifiex: Deactive host sleep using HSCFG after it was activated manually Jonas Dreßler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211017080856.hy3cjszegur5gumy@pali \
--to=pali@kernel.org \
--cc=amitkarwar@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bhelgaas@google.com \
--cc=davem@davemloft.net \
--cc=ganapathi017@gmail.com \
--cc=huxinming820@gmail.com \
--cc=kitakar@gmail.com \
--cc=kuba@kernel.org \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=luzmaximilian@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=verdre@v0yd.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).