From: Dan Carpenter <dan.carpenter@oracle.com>
To: max chee <maxchee@outlook.com>
Cc: "security@kernel.org" <security@kernel.org>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: Heap based overflow in Marvell Wifi mwifiex_cfg80211_start_ap function
Date: Mon, 29 Nov 2021 10:16:02 +0300 [thread overview]
Message-ID: <20211129071602.GO18178@kadam> (raw)
In-Reply-To: <SI2PR06MB406009BA8EA40388A439FA3DA3659@SI2PR06MB4060.apcprd06.prod.outlook.com>
This is a false positive. The nla stuff has checking which is pretty
tricky for static analysis to handle. Here is how that attribute is
defined.
net/wireless/nl80211.c
544 [NL80211_ATTR_SSID] = { .type = NLA_BINARY,
545 .len = IEEE80211_MAX_SSID_LEN },
When the NL80211_ATTR_SSID attr is parsed it's capped at
0-IEEE80211_MAX_SSID_LEN because of this.
regards,
dan carpenter
next parent reply other threads:[~2021-11-29 7:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <SI2PR06MB40600A3DBE2D37C6C484D4A5A3659@SI2PR06MB4060.apcprd06.prod.outlook.com>
[not found] ` <SI2PR06MB406009BA8EA40388A439FA3DA3659@SI2PR06MB4060.apcprd06.prod.outlook.com>
2021-11-29 7:16 ` Dan Carpenter [this message]
[not found] <SI2PR06MB4060AE27017D9205ADBC7140A3659@SI2PR06MB4060.apcprd06.prod.outlook.com>
2021-11-29 8:48 ` Heap based overflow in Marvell Wifi mwifiex_cfg80211_start_ap function Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211129071602.GO18178@kadam \
--to=dan.carpenter@oracle.com \
--cc=linux-wireless@vger.kernel.org \
--cc=maxchee@outlook.com \
--cc=security@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).