[wpan-next 0/4] ieee802154: General preparation to scan support

[wpan-next 0/4] ieee802154: General preparation to scan support

[Miquel Raynal]

These few patches are preparation patches and light cleanups before the
introduction of scan support.

David Girault (4):
  net: ieee802154: Move IEEE 802.15.4 Kconfig main entry
  net: mac802154: Include the softMAC stack inside the IEEE 802.15.4
    menu
  net: ieee802154: Move the address structure earlier
  net: ieee802154: Add a kernel doc header to the ieee802154_addr
    structure

 include/net/cfg802154.h | 28 +++++++++++++++++++---------
 net/Kconfig             |  3 +--
 net/ieee802154/Kconfig  |  1 +
 3 files changed, 21 insertions(+), 11 deletions(-)

-- 
2.27.0

[wpan-next 1/4] net: ieee802154: Move IEEE 802.15.4 Kconfig main entry

[Miquel Raynal]

From: David Girault <david.girault@qorvo.com>

It makes certainly more sense to have all the low-range wireless
protocols such as Bluetooth, IEEE 802.11 (WiFi) and IEEE 802.15.4
together, so let's move the main IEEE 802.15.4 stack Kconfig entry at a
better location.

Signed-off-by: David Girault <david.girault@qorvo.com>
[miquel.raynal@bootlin.com: Isolate this change from a bigger commit and
rewrite the commit message.]
Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
---
 net/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/Kconfig b/net/Kconfig
index 8a1f9d0287de..0da89d09ffa6 100644
--- a/net/Kconfig
+++ b/net/Kconfig
@@ -228,7 +228,6 @@ source "net/x25/Kconfig"
 source "net/lapb/Kconfig"
 source "net/phonet/Kconfig"
 source "net/6lowpan/Kconfig"
-source "net/ieee802154/Kconfig"
 source "net/mac802154/Kconfig"
 source "net/sched/Kconfig"
 source "net/dcb/Kconfig"
@@ -380,6 +379,7 @@ source "net/mac80211/Kconfig"
 
 endif # WIRELESS
 
+source "net/ieee802154/Kconfig"
 source "net/rfkill/Kconfig"
 source "net/9p/Kconfig"
 source "net/caif/Kconfig"
-- 
2.27.0

[wpan-next 2/4] net: mac802154: Include the softMAC stack inside the IEEE 802.15.4 menu

[Miquel Raynal]

From: David Girault <david.girault@qorvo.com>

The softMAC stack has no meaning outside of the IEEE 802.15.4 stack and
cannot be used without it.

Signed-off-by: David Girault <david.girault@qorvo.com>
[miquel.raynal@bootlin.com: Isolate this change from a bigger commit]
Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
---
 net/Kconfig            | 1 -
 net/ieee802154/Kconfig | 1 +
 2 files changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/Kconfig b/net/Kconfig
index 0da89d09ffa6..a5e31078fd14 100644
--- a/net/Kconfig
+++ b/net/Kconfig
@@ -228,7 +228,6 @@ source "net/x25/Kconfig"
 source "net/lapb/Kconfig"
 source "net/phonet/Kconfig"
 source "net/6lowpan/Kconfig"
-source "net/mac802154/Kconfig"
 source "net/sched/Kconfig"
 source "net/dcb/Kconfig"
 source "net/dns_resolver/Kconfig"
diff --git a/net/ieee802154/Kconfig b/net/ieee802154/Kconfig
index 31aed75fe62d..7e4b1d49d445 100644
--- a/net/ieee802154/Kconfig
+++ b/net/ieee802154/Kconfig
@@ -36,6 +36,7 @@ config IEEE802154_SOCKET
 	  for 802.15.4 dataframes. Also RAW socket interface to build MAC
 	  header from userspace.
 
+source "net/mac802154/Kconfig"
 source "net/ieee802154/6lowpan/Kconfig"
 
 endif
-- 
2.27.0

[wpan-next 3/4] net: ieee802154: Move the address structure earlier

[Miquel Raynal]

From: David Girault <david.girault@qorvo.com>

Move the address structure earlier in the cfg802154.h header in order to
use it in subsequent additions. There is no functional change here.

Signed-off-by: David Girault <david.girault@qorvo.com>
[miquel.raynal@bootlin.com: Isolate this change from a bigger commit]
Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
---
 include/net/cfg802154.h | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)

diff --git a/include/net/cfg802154.h b/include/net/cfg802154.h
index 4491e2724ff2..4193c242d96e 100644
--- a/include/net/cfg802154.h
+++ b/include/net/cfg802154.h
@@ -29,6 +29,15 @@ struct ieee802154_llsec_key_id;
 struct ieee802154_llsec_key;
 #endif /* CONFIG_IEEE802154_NL802154_EXPERIMENTAL */
 
+struct ieee802154_addr {
+	u8 mode;
+	__le16 pan_id;
+	union {
+		__le16 short_addr;
+		__le64 extended_addr;
+	};
+};
+
 struct cfg802154_ops {
 	struct net_device * (*add_virtual_intf_deprecated)(struct wpan_phy *wpan_phy,
 							   const char *name,
@@ -277,15 +286,6 @@ static inline void wpan_phy_net_set(struct wpan_phy *wpan_phy, struct net *net)
 	write_pnet(&wpan_phy->_net, net);
 }
 
-struct ieee802154_addr {
-	u8 mode;
-	__le16 pan_id;
-	union {
-		__le16 short_addr;
-		__le64 extended_addr;
-	};
-};
-
 struct ieee802154_llsec_key_id {
 	u8 mode;
 	u8 id;
-- 
2.27.0

[wpan-next 4/4] net: ieee802154: Add a kernel doc header to the ieee802154_addr structure

[Miquel Raynal]

From: David Girault <david.girault@qorvo.com>

While not being absolutely needed, it at least explain the mode vs. enum
fields.

Signed-off-by: David Girault <david.girault@qorvo.com>
[miquel.raynal@bootlin.com: Isolate this change from a bigger commit and
                            reword the comment]
Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
---
 include/net/cfg802154.h | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/include/net/cfg802154.h b/include/net/cfg802154.h
index 4193c242d96e..0b8b1812cea1 100644
--- a/include/net/cfg802154.h
+++ b/include/net/cfg802154.h
@@ -29,6 +29,16 @@ struct ieee802154_llsec_key_id;
 struct ieee802154_llsec_key;
 #endif /* CONFIG_IEEE802154_NL802154_EXPERIMENTAL */
 
+/**
+ * struct ieee802154_addr - IEEE802.15.4 device address
+ * @mode: Address mode from frame header. Can be one of:
+ *        - @IEEE802154_ADDR_NONE
+ *        - @IEEE802154_ADDR_SHORT
+ *        - @IEEE802154_ADDR_LONG
+ * @pan_id: The PAN ID this address belongs to
+ * @short_addr: address if @mode is @IEEE802154_ADDR_SHORT
+ * @extended_addr: address if @mode is @IEEE802154_ADDR_LONG
+ */
 struct ieee802154_addr {
 	u8 mode;
 	__le16 pan_id;
-- 
2.27.0

Re: [wpan-next 0/4] ieee802154: General preparation to scan support

[Kalle Valo]

Miquel Raynal <miquel.raynal@bootlin.com> writes:

> These few patches are preparation patches and light cleanups before the
> introduction of scan support.
>
> David Girault (4):
>   net: ieee802154: Move IEEE 802.15.4 Kconfig main entry
>   net: mac802154: Include the softMAC stack inside the IEEE 802.15.4
>     menu
>   net: ieee802154: Move the address structure earlier
>   net: ieee802154: Add a kernel doc header to the ieee802154_addr
>     structure
>
>  include/net/cfg802154.h | 28 +++++++++++++++++++---------
>  net/Kconfig             |  3 +--
>  net/ieee802154/Kconfig  |  1 +
>  3 files changed, 21 insertions(+), 11 deletions(-)

Is there a reason why you cc linux-wireless? It looks like there's a
separate linux-wpan list now and people who are interested about wpan
can join that list, right?

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

Re: [wpan-next 0/4] ieee802154: General preparation to scan support

[Miquel Raynal]

Hi Kalle,

kvalo@kernel.org wrote on Thu, 20 Jan 2022 15:10:37 +0200:

> Miquel Raynal <miquel.raynal@bootlin.com> writes:
> 
> > These few patches are preparation patches and light cleanups before the
> > introduction of scan support.
> >
> > David Girault (4):
> >   net: ieee802154: Move IEEE 802.15.4 Kconfig main entry
> >   net: mac802154: Include the softMAC stack inside the IEEE 802.15.4
> >     menu
> >   net: ieee802154: Move the address structure earlier
> >   net: ieee802154: Add a kernel doc header to the ieee802154_addr
> >     structure
> >
> >  include/net/cfg802154.h | 28 +++++++++++++++++++---------
> >  net/Kconfig             |  3 +--
> >  net/ieee802154/Kconfig  |  1 +
> >  3 files changed, 21 insertions(+), 11 deletions(-)  
> 
> Is there a reason why you cc linux-wireless? It looks like there's a
> separate linux-wpan list now and people who are interested about wpan
> can join that list, right?
> 

I originally was advised to cc linux-wireless@ on my scanning series,
and I ended up with too many patches, leading to numerous smaller
series.

I actually forgot to drop this list from the Cc list in the preparation
patches for this version, I did however dropped it in the v2. Sorry for
the noise.

Thanks,
Miquèl

Re: [wpan-next 0/4] ieee802154: General preparation to scan support

[Alexander Aring]

Hi Kalle and Miquel,

On Thu, 20 Jan 2022 at 08:10, Kalle Valo <kvalo@kernel.org> wrote:
>
> Miquel Raynal <miquel.raynal@bootlin.com> writes:
>
> > These few patches are preparation patches and light cleanups before the
> > introduction of scan support.
> >
> > David Girault (4):
> >   net: ieee802154: Move IEEE 802.15.4 Kconfig main entry
> >   net: mac802154: Include the softMAC stack inside the IEEE 802.15.4
> >     menu
> >   net: ieee802154: Move the address structure earlier
> >   net: ieee802154: Add a kernel doc header to the ieee802154_addr
> >     structure
> >
> >  include/net/cfg802154.h | 28 +++++++++++++++++++---------
> >  net/Kconfig             |  3 +--
> >  net/ieee802154/Kconfig  |  1 +
> >  3 files changed, 21 insertions(+), 11 deletions(-)
>
> Is there a reason why you cc linux-wireless? It looks like there's a
> separate linux-wpan list now and people who are interested about wpan
> can join that list, right?
>

I thought it would make sense to cc wireless as they have similar
paradigms constructs (probably due the fact both are IEEE standards?).
As well we took some ideas from wireless as base. Moreover we were
talking about things which wireless already solved.
I was hoping to get some feedback if somebody knows the right do's and
don'ts of managing a wireless subsystem and I am pretty sure some
802.11 developers have more knowledge about it than some 802.15.4
developers (including myself).

I apologise for this. Please Miquel drop wireless for your future patch-series.

Miquel please slow down the amount of patches. First sending the
fixes, then new features in small series one by one. And with one by
one I mean after they are applied.

- Alex

Re: [wpan-next 0/4] ieee802154: General preparation to scan support

[Miquel Raynal]

Hi Alexander,

alex.aring@gmail.com wrote on Thu, 20 Jan 2022 18:31:58 -0500:

> Hi Kalle and Miquel,
> 
> On Thu, 20 Jan 2022 at 08:10, Kalle Valo <kvalo@kernel.org> wrote:
> >
> > Miquel Raynal <miquel.raynal@bootlin.com> writes:
> >  
> > > These few patches are preparation patches and light cleanups before the
> > > introduction of scan support.
> > >
> > > David Girault (4):
> > >   net: ieee802154: Move IEEE 802.15.4 Kconfig main entry
> > >   net: mac802154: Include the softMAC stack inside the IEEE 802.15.4
> > >     menu
> > >   net: ieee802154: Move the address structure earlier
> > >   net: ieee802154: Add a kernel doc header to the ieee802154_addr
> > >     structure
> > >
> > >  include/net/cfg802154.h | 28 +++++++++++++++++++---------
> > >  net/Kconfig             |  3 +--
> > >  net/ieee802154/Kconfig  |  1 +
> > >  3 files changed, 21 insertions(+), 11 deletions(-)  
> >
> > Is there a reason why you cc linux-wireless? It looks like there's a
> > separate linux-wpan list now and people who are interested about wpan
> > can join that list, right?
> >  
> 
> I thought it would make sense to cc wireless as they have similar
> paradigms constructs (probably due the fact both are IEEE standards?).
> As well we took some ideas from wireless as base. Moreover we were
> talking about things which wireless already solved.
> I was hoping to get some feedback if somebody knows the right do's and
> don'ts of managing a wireless subsystem and I am pretty sure some
> 802.11 developers have more knowledge about it than some 802.15.4
> developers (including myself).
> 
> I apologise for this. Please Miquel drop wireless for your future patch-series.

Ok, no problem!
 
> Miquel please slow down the amount of patches. First sending the
> fixes, then new features in small series one by one. And with one by
> one I mean after they are applied.

Yes no problem, I didn't want to flood you, but I was eager to share
the new sync tx implementation that we discussed earlier this week,
which meant I also needed to share the two 'small' series in between.

Thanks,
Miquèl

Re: [wpan-next 2/4] net: mac802154: Include the softMAC stack inside the IEEE 802.15.4 menu

[Stefan Schmidt]

Hello.

On 20.01.22 01:43, Miquel Raynal wrote:
> From: David Girault <david.girault@qorvo.com>
> 
> The softMAC stack has no meaning outside of the IEEE 802.15.4 stack and
> cannot be used without it.
> 
> Signed-off-by: David Girault <david.girault@qorvo.com>
> [miquel.raynal@bootlin.com: Isolate this change from a bigger commit]
> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
> ---
>   net/Kconfig            | 1 -
>   net/ieee802154/Kconfig | 1 +
>   2 files changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/Kconfig b/net/Kconfig
> index 0da89d09ffa6..a5e31078fd14 100644
> --- a/net/Kconfig
> +++ b/net/Kconfig
> @@ -228,7 +228,6 @@ source "net/x25/Kconfig"
>   source "net/lapb/Kconfig"
>   source "net/phonet/Kconfig"
>   source "net/6lowpan/Kconfig"
> -source "net/mac802154/Kconfig"
>   source "net/sched/Kconfig"
>   source "net/dcb/Kconfig"
>   source "net/dns_resolver/Kconfig"
> diff --git a/net/ieee802154/Kconfig b/net/ieee802154/Kconfig
> index 31aed75fe62d..7e4b1d49d445 100644
> --- a/net/ieee802154/Kconfig
> +++ b/net/ieee802154/Kconfig
> @@ -36,6 +36,7 @@ config IEEE802154_SOCKET
>   	  for 802.15.4 dataframes. Also RAW socket interface to build MAC
>   	  header from userspace.
>   
> +source "net/mac802154/Kconfig"
>   source "net/ieee802154/6lowpan/Kconfig"
>   
>   endif
> 

Please fold this patch into the previous one moving the Kconfig option 
around. This can be done in one go.

regards
Stefan Schmidt

Re: [wpan-next 4/4] net: ieee802154: Add a kernel doc header to the ieee802154_addr structure

[Stefan Schmidt]

Hello.

On 20.01.22 01:43, Miquel Raynal wrote:
> From: David Girault <david.girault@qorvo.com>
> 
> While not being absolutely needed, it at least explain the mode vs. enum
> fields.
> 
> Signed-off-by: David Girault <david.girault@qorvo.com>
> [miquel.raynal@bootlin.com: Isolate this change from a bigger commit and
>                              reword the comment]
> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
> ---
>   include/net/cfg802154.h | 10 ++++++++++
>   1 file changed, 10 insertions(+)
> 
> diff --git a/include/net/cfg802154.h b/include/net/cfg802154.h
> index 4193c242d96e..0b8b1812cea1 100644
> --- a/include/net/cfg802154.h
> +++ b/include/net/cfg802154.h
> @@ -29,6 +29,16 @@ struct ieee802154_llsec_key_id;
>   struct ieee802154_llsec_key;
>   #endif /* CONFIG_IEEE802154_NL802154_EXPERIMENTAL */
>   
> +/**
> + * struct ieee802154_addr - IEEE802.15.4 device address
> + * @mode: Address mode from frame header. Can be one of:
> + *        - @IEEE802154_ADDR_NONE
> + *        - @IEEE802154_ADDR_SHORT
> + *        - @IEEE802154_ADDR_LONG
> + * @pan_id: The PAN ID this address belongs to
> + * @short_addr: address if @mode is @IEEE802154_ADDR_SHORT
> + * @extended_addr: address if @mode is @IEEE802154_ADDR_LONG
> + */
>   struct ieee802154_addr {
>   	u8 mode;
>   	__le16 pan_id;
> 

Same here, please fold into the addr moving patch. I see no reason why 
splitting these would make it easier or do I miss something?

regards
Stefan Schmidt

Re: [wpan-next 4/4] net: ieee802154: Add a kernel doc header to the ieee802154_addr structure

[Miquel Raynal]

Hi Stefan,

stefan@datenfreihafen.org wrote on Thu, 27 Jan 2022 17:05:42 +0100:

> Hello.
> 
> On 20.01.22 01:43, Miquel Raynal wrote:
> > From: David Girault <david.girault@qorvo.com>
> > 
> > While not being absolutely needed, it at least explain the mode vs. enum
> > fields.
> > 
> > Signed-off-by: David Girault <david.girault@qorvo.com>
> > [miquel.raynal@bootlin.com: Isolate this change from a bigger commit and
> >                              reword the comment]
> > Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
> > ---
> >   include/net/cfg802154.h | 10 ++++++++++
> >   1 file changed, 10 insertions(+)
> > 
> > diff --git a/include/net/cfg802154.h b/include/net/cfg802154.h
> > index 4193c242d96e..0b8b1812cea1 100644
> > --- a/include/net/cfg802154.h
> > +++ b/include/net/cfg802154.h
> > @@ -29,6 +29,16 @@ struct ieee802154_llsec_key_id;
> >   struct ieee802154_llsec_key;
> >   #endif /* CONFIG_IEEE802154_NL802154_EXPERIMENTAL */  
> >   > +/**  
> > + * struct ieee802154_addr - IEEE802.15.4 device address
> > + * @mode: Address mode from frame header. Can be one of:
> > + *        - @IEEE802154_ADDR_NONE
> > + *        - @IEEE802154_ADDR_SHORT
> > + *        - @IEEE802154_ADDR_LONG
> > + * @pan_id: The PAN ID this address belongs to
> > + * @short_addr: address if @mode is @IEEE802154_ADDR_SHORT
> > + * @extended_addr: address if @mode is @IEEE802154_ADDR_LONG
> > + */
> >   struct ieee802154_addr {
> >   	u8 mode;
> >   	__le16 pan_id;
> >   
> 
> Same here, please fold into the addr moving patch. I see no reason why splitting these would make it easier or do I miss something?

I really split every change that I could as a habit, but there is no
problem with squashing them both.

Thanks,
Miquèl

Re: [wpan-next 2/4] net: mac802154: Include the softMAC stack inside the IEEE 802.15.4 menu

[Miquel Raynal]

Hi Stefan,

stefan@datenfreihafen.org wrote on Thu, 27 Jan 2022 17:04:41 +0100:

> Hello.
> 
> On 20.01.22 01:43, Miquel Raynal wrote:
> > From: David Girault <david.girault@qorvo.com>
> > 
> > The softMAC stack has no meaning outside of the IEEE 802.15.4 stack and
> > cannot be used without it.
> > 
> > Signed-off-by: David Girault <david.girault@qorvo.com>
> > [miquel.raynal@bootlin.com: Isolate this change from a bigger commit]
> > Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
> > ---
> >   net/Kconfig            | 1 -
> >   net/ieee802154/Kconfig | 1 +
> >   2 files changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/net/Kconfig b/net/Kconfig
> > index 0da89d09ffa6..a5e31078fd14 100644
> > --- a/net/Kconfig
> > +++ b/net/Kconfig
> > @@ -228,7 +228,6 @@ source "net/x25/Kconfig"
> >   source "net/lapb/Kconfig"
> >   source "net/phonet/Kconfig"
> >   source "net/6lowpan/Kconfig"
> > -source "net/mac802154/Kconfig"
> >   source "net/sched/Kconfig"
> >   source "net/dcb/Kconfig"
> >   source "net/dns_resolver/Kconfig"
> > diff --git a/net/ieee802154/Kconfig b/net/ieee802154/Kconfig
> > index 31aed75fe62d..7e4b1d49d445 100644
> > --- a/net/ieee802154/Kconfig
> > +++ b/net/ieee802154/Kconfig
> > @@ -36,6 +36,7 @@ config IEEE802154_SOCKET
> >   	  for 802.15.4 dataframes. Also RAW socket interface to build MAC
> >   	  header from userspace.  
> >   > +source "net/mac802154/Kconfig"  
> >   source "net/ieee802154/6lowpan/Kconfig"  
> >   >   endif  
> >   
> 
> Please fold this patch into the previous one moving the Kconfig option around. This can be done in one go.

Sure.

By the way, I was questioning myself: why is the mac802154 folder
outside of ieee802154? I don't really understand the organization but
as it would massively prevent any of the future changes that I already
prepared to apply correctly, I haven't proposed such a move -yet. But
I would like to know what's the idea behind the current folder
hierarchy?

Thanks,
Miquèl

Re: [wpan-next 2/4] net: mac802154: Include the softMAC stack inside the IEEE 802.15.4 menu

[Stefan Schmidt]

Hello.

On 27.01.22 17:54, Miquel Raynal wrote:
> Hi Stefan,
> 
> stefan@datenfreihafen.org wrote on Thu, 27 Jan 2022 17:04:41 +0100:
> 
>> Hello.
>>
>> On 20.01.22 01:43, Miquel Raynal wrote:
>>> From: David Girault <david.girault@qorvo.com>
>>>
>>> The softMAC stack has no meaning outside of the IEEE 802.15.4 stack and
>>> cannot be used without it.
>>>
>>> Signed-off-by: David Girault <david.girault@qorvo.com>
>>> [miquel.raynal@bootlin.com: Isolate this change from a bigger commit]
>>> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
>>> ---
>>>    net/Kconfig            | 1 -
>>>    net/ieee802154/Kconfig | 1 +
>>>    2 files changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/net/Kconfig b/net/Kconfig
>>> index 0da89d09ffa6..a5e31078fd14 100644
>>> --- a/net/Kconfig
>>> +++ b/net/Kconfig
>>> @@ -228,7 +228,6 @@ source "net/x25/Kconfig"
>>>    source "net/lapb/Kconfig"
>>>    source "net/phonet/Kconfig"
>>>    source "net/6lowpan/Kconfig"
>>> -source "net/mac802154/Kconfig"
>>>    source "net/sched/Kconfig"
>>>    source "net/dcb/Kconfig"
>>>    source "net/dns_resolver/Kconfig"
>>> diff --git a/net/ieee802154/Kconfig b/net/ieee802154/Kconfig
>>> index 31aed75fe62d..7e4b1d49d445 100644
>>> --- a/net/ieee802154/Kconfig
>>> +++ b/net/ieee802154/Kconfig
>>> @@ -36,6 +36,7 @@ config IEEE802154_SOCKET
>>>    	  for 802.15.4 dataframes. Also RAW socket interface to build MAC
>>>    	  header from userspace.
>>>    > +source "net/mac802154/Kconfig"
>>>    source "net/ieee802154/6lowpan/Kconfig"
>>>    >   endif
>>>    
>>
>> Please fold this patch into the previous one moving the Kconfig option around. This can be done in one go.
> 
> Sure.
> 
> By the way, I was questioning myself: why is the mac802154 folder
> outside of ieee802154? I don't really understand the organization but
> as it would massively prevent any of the future changes that I already
> prepared to apply correctly, I haven't proposed such a move -yet. But
> I would like to know what's the idea behind the current folder
> hierarchy?

The directory structure has been in place from the initial merge of the 
subsystem, before Alex and myself took on the maintainer roles.

I see no reason for a move though. The extra burden for backports, etc 
outweigh the urge of cleanliness on the folder structure. :-)

The Kconfig cleanup and move of the file is worth doing, the move of the 
whole source code folder not.

regards
Stefan Schmidt

Re: [wpan-next 2/4] net: mac802154: Include the softMAC stack inside the IEEE 802.15.4 menu

[Miquel Raynal]

Hi Stefan,

stefan@datenfreihafen.org wrote on Fri, 28 Jan 2022 13:35:00 +0100:

> Hello.
> 
> On 27.01.22 17:54, Miquel Raynal wrote:
> > Hi Stefan,
> > 
> > stefan@datenfreihafen.org wrote on Thu, 27 Jan 2022 17:04:41 +0100:
> >   
> >> Hello.
> >>
> >> On 20.01.22 01:43, Miquel Raynal wrote:  
> >>> From: David Girault <david.girault@qorvo.com>
> >>>
> >>> The softMAC stack has no meaning outside of the IEEE 802.15.4 stack and
> >>> cannot be used without it.
> >>>
> >>> Signed-off-by: David Girault <david.girault@qorvo.com>
> >>> [miquel.raynal@bootlin.com: Isolate this change from a bigger commit]
> >>> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
> >>> ---
> >>>    net/Kconfig            | 1 -
> >>>    net/ieee802154/Kconfig | 1 +
> >>>    2 files changed, 1 insertion(+), 1 deletion(-)
> >>>
> >>> diff --git a/net/Kconfig b/net/Kconfig
> >>> index 0da89d09ffa6..a5e31078fd14 100644
> >>> --- a/net/Kconfig
> >>> +++ b/net/Kconfig
> >>> @@ -228,7 +228,6 @@ source "net/x25/Kconfig"
> >>>    source "net/lapb/Kconfig"
> >>>    source "net/phonet/Kconfig"
> >>>    source "net/6lowpan/Kconfig"
> >>> -source "net/mac802154/Kconfig"
> >>>    source "net/sched/Kconfig"
> >>>    source "net/dcb/Kconfig"
> >>>    source "net/dns_resolver/Kconfig"
> >>> diff --git a/net/ieee802154/Kconfig b/net/ieee802154/Kconfig
> >>> index 31aed75fe62d..7e4b1d49d445 100644
> >>> --- a/net/ieee802154/Kconfig
> >>> +++ b/net/ieee802154/Kconfig
> >>> @@ -36,6 +36,7 @@ config IEEE802154_SOCKET
> >>>    	  for 802.15.4 dataframes. Also RAW socket interface to build MAC
> >>>    	  header from userspace.  
> >>>    > +source "net/mac802154/Kconfig"  
> >>>    source "net/ieee802154/6lowpan/Kconfig"  
> >>>    >   endif  
> >>>    >>  
> >> Please fold this patch into the previous one moving the Kconfig option around. This can be done in one go.  
> > 
> > Sure.
> > 
> > By the way, I was questioning myself: why is the mac802154 folder
> > outside of ieee802154? I don't really understand the organization but
> > as it would massively prevent any of the future changes that I already
> > prepared to apply correctly, I haven't proposed such a move -yet. But
> > I would like to know what's the idea behind the current folder
> > hierarchy?  
> 
> The directory structure has been in place from the initial merge of the subsystem, before Alex and myself took on the maintainer roles.
> 
> I see no reason for a move though. The extra burden for backports, etc outweigh the urge of cleanliness on the folder structure. :-)

That's fair.

> The Kconfig cleanup and move of the file is worth doing, the move of the whole source code folder not.

I agree there is more interesting and less impacting to do in the area,
I was just wondering about that choice.

Thanks,
Miquèl

Re: [wpan-next 2/4] net: mac802154: Include the softMAC stack inside the IEEE 802.15.4 menu

[Alexander Aring]

Hi,

On Wed, Jan 19, 2022 at 7:43 PM Miquel Raynal <miquel.raynal@bootlin.com> wrote:
>
> From: David Girault <david.girault@qorvo.com>
>
> The softMAC stack has no meaning outside of the IEEE 802.15.4 stack and
> cannot be used without it.
>

that's why there is a "depends on" in there.

> Signed-off-by: David Girault <david.girault@qorvo.com>
> [miquel.raynal@bootlin.com: Isolate this change from a bigger commit]
> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
> ---
>  net/Kconfig            | 1 -
>  net/ieee802154/Kconfig | 1 +
>  2 files changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/Kconfig b/net/Kconfig
> index 0da89d09ffa6..a5e31078fd14 100644
> --- a/net/Kconfig
> +++ b/net/Kconfig
> @@ -228,7 +228,6 @@ source "net/x25/Kconfig"
>  source "net/lapb/Kconfig"
>  source "net/phonet/Kconfig"
>  source "net/6lowpan/Kconfig"
> -source "net/mac802154/Kconfig"
>  source "net/sched/Kconfig"
>  source "net/dcb/Kconfig"
>  source "net/dns_resolver/Kconfig"
> diff --git a/net/ieee802154/Kconfig b/net/ieee802154/Kconfig
> index 31aed75fe62d..7e4b1d49d445 100644
> --- a/net/ieee802154/Kconfig
> +++ b/net/ieee802154/Kconfig
> @@ -36,6 +36,7 @@ config IEEE802154_SOCKET
>           for 802.15.4 dataframes. Also RAW socket interface to build MAC
>           header from userspace.
>
> +source "net/mac802154/Kconfig"
>  source "net/ieee802154/6lowpan/Kconfig"

The next person in a year will probably argue "but wireless do source
of wireless/mac80211 in net/Kconfig... so this is wrong".
To avoid this issue maybe we should take out the menuentry here and do
whatever wireless is doing without questioning it?

- Alex