From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Alexander Aring <alex.aring@gmail.com>,
Stefan Schmidt <stefan@datenfreihafen.org>,
linux-wpan@vger.kernel.org
Cc: "David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
netdev@vger.kernel.org, linux-wireless@vger.kernel.org,
David Girault <david.girault@qorvo.com>,
Romuald Despres <romuald.despres@qorvo.com>,
Frederic Blain <frederic.blain@qorvo.com>,
Nicolas Schodet <nico@ni.fr.eu.org>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Miquel Raynal <miquel.raynal@bootlin.com>
Subject: [wpan-next 05/14] net: ieee802154: ca8210: Call _xmit_error() when a transmission fails
Date: Thu, 20 Jan 2022 01:51:13 +0100 [thread overview]
Message-ID: <20220120005122.309104-6-miquel.raynal@bootlin.com> (raw)
In-Reply-To: <20220120005122.309104-1-miquel.raynal@bootlin.com>
ieee802154_xmit_error() is the right helper to call when a transmission
has failed. Let's use it instead of open-coding it.
Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
---
drivers/net/ieee802154/ca8210.c | 12 +++++++-----
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/drivers/net/ieee802154/ca8210.c b/drivers/net/ieee802154/ca8210.c
index 91456c5e5691..2830e6fdd0fd 100644
--- a/drivers/net/ieee802154/ca8210.c
+++ b/drivers/net/ieee802154/ca8210.c
@@ -1765,17 +1765,19 @@ static int ca8210_async_xmit_complete(
priv->nextmsduhandle++;
if (status) {
+ bool ifs_handling =
+ status == MAC_TRANSACTION_OVERFLOW ? true : false;
+
dev_err(
&priv->spi->dev,
"Link transmission unsuccessful, status = %d\n",
status
);
- if (status != MAC_TRANSACTION_OVERFLOW) {
- ieee802154_wake_queue(priv->hw);
- dev_kfree_skb_any(atusb->tx_skb);
- return 0;
- }
+
+ ieee802154_xmit_error(priv->hw, priv->tx_skb, ifs_handling);
+ return 0;
}
+
ieee802154_xmit_complete(priv->hw, priv->tx_skb, true);
return 0;
--
2.27.0
next prev parent reply other threads:[~2022-01-20 0:51 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-20 0:51 [wpan-next 00/14] ieee802154: Synchronous Tx API Miquel Raynal
2022-01-20 0:51 ` [wpan-next 01/14] net: ieee802154: Move the logic restarting the queue upon transmission Miquel Raynal
2022-01-20 0:51 ` [wpan-next 02/14] net: mac802154: Create a transmit error helper Miquel Raynal
2022-01-20 0:51 ` [wpan-next 03/14] net: ieee802154: at86rf230: Call _xmit_error() when a transmission fails Miquel Raynal
2022-01-20 0:51 ` [wpan-next 04/14] net: ieee802154: atusb: " Miquel Raynal
2022-01-20 0:51 ` Miquel Raynal [this message]
2022-01-20 0:51 ` [wpan-next 06/14] net: mac802154: Stop exporting ieee802154_wake/stop_queue() Miquel Raynal
2022-01-20 0:51 ` [wpan-next 07/14] net: mac802154: Rename the synchronous xmit worker Miquel Raynal
2022-01-20 0:51 ` [wpan-next 08/14] net: mac802154: Rename the main tx_work struct Miquel Raynal
2022-01-20 0:51 ` [wpan-next 09/14] net: mac802154: Follow the count of ongoing transmissions Miquel Raynal
2022-01-20 0:51 ` [wpan-next 10/14] net: mac802154: Hold the transmit queue when relevant Miquel Raynal
2022-01-20 0:51 ` [wpan-next 11/14] net: mac802154: Create a hot tx path Miquel Raynal
2022-01-20 0:51 ` [wpan-next 12/14] net: mac802154: Add a warning in the hot path Miquel Raynal
2022-01-20 0:51 ` [wpan-next 13/14] net: mac802154: Introduce a tx queue flushing mechanism Miquel Raynal
2022-01-20 0:51 ` [wpan-next 14/14] net: mac802154: Introduce a synchronous API for MLME commands Miquel Raynal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220120005122.309104-6-miquel.raynal@bootlin.com \
--to=miquel.raynal@bootlin.com \
--cc=alex.aring@gmail.com \
--cc=davem@davemloft.net \
--cc=david.girault@qorvo.com \
--cc=frederic.blain@qorvo.com \
--cc=kuba@kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linux-wpan@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nico@ni.fr.eu.org \
--cc=romuald.despres@qorvo.com \
--cc=stefan@datenfreihafen.org \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).