From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2FE41C4332F for ; Thu, 20 Jan 2022 00:25:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345307AbiATAZE convert rfc822-to-8bit (ORCPT ); Wed, 19 Jan 2022 19:25:04 -0500 Received: from relay7-d.mail.gandi.net ([217.70.183.200]:46737 "EHLO relay7-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345289AbiATAZD (ORCPT ); Wed, 19 Jan 2022 19:25:03 -0500 Received: (Authenticated sender: miquel.raynal@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 3DAB620003; Thu, 20 Jan 2022 00:25:00 +0000 (UTC) Date: Thu, 20 Jan 2022 01:24:59 +0100 From: Miquel Raynal To: Alexander Aring Cc: Stefan Schmidt , linux-wpan - ML , "open list:NETWORKING [GENERAL]" , "linux-wireless@vger.kernel.org Wireless" , David Girault , Romuald Despres , Frederic Blain , Nicolas Schodet , Michael Hennerich , Jakub Kicinski , Varka Bhadram , Xue Liu , Alan Ott , Thomas Petazzoni Subject: Re: [PATCH v3 00/41] IEEE 802.15.4 scan support Message-ID: <20220120012459.1e3ca85e@xps13> In-Reply-To: References: <20220117115440.60296-1-miquel.raynal@bootlin.com> <20220118114023.2d2c0207@xps13> Organization: Bootlin X-Mailer: Claws Mail 3.17.7 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Hi Alexander, alex.aring@gmail.com wrote on Tue, 18 Jan 2022 18:12:49 -0500: > Hi, > > On Tue, 18 Jan 2022 at 05:40, Miquel Raynal wrote: > > > > Hi Alexander, > > > > > > So far the only technical point that is missing in this series is the > > > > possibility to grab a reference over the module driving the net device > > > > in order to prevent module unloading during a scan or when the beacons > > > > work is ongoing. > > > > Do you have any advises regarding this issue? That is the only > > technical point that is left unaddressed IMHO. > > > > module_get()/module_put() or I don't see where the problem here is. > You can avoid module unloading with it. Which module is the problem > here? I'll give it another try, maybe when I first tried that I was missing a few mental peaces and did not understood the puzzle correctly. > > > > Finally, this series is a deep reshuffle of David Girault's original > > > > work, hence the fact that he is almost systematically credited, either > > > > by being the only author when I created the patches based on his changes > > > > with almost no modification, or with a Co-developped-by tag whenever the > > > > final code base is significantly different than his first proposal while > > > > still being greatly inspired from it. > > > > > > > > > > can you please split this patch series, what I see is now: > > > > > > 1. cleanup patches > > > 2. sync tx handling for mlme commands > > > 3. scan support > > > > Works for me. I just wanted to give the big picture but I'll split the > > series. > > > > maybe also put some "symbol duration" series into it if it's getting > too large? It is difficult to review 40 patches... in one step. Yep, I truly understand (and now 50+). > > > Also sorry for forgetting the 'wpan-next' subject prefix. > > > > no problem. > > I really appreciate your work and your willingness to work on all > outstanding issues. I am really happy to see something that we can use > for mlme-commands and to separate it from the hotpath transmission... > It is good to see architecture for that which I think goes in the > right direction. That is very stirring to read :) Thanks, Miquèl