From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Stefan Schmidt <stefan@datenfreihafen.org>
Cc: Alexander Aring <alex.aring@gmail.com>,
linux-wpan@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
netdev@vger.kernel.org, linux-wireless@vger.kernel.org,
David Girault <david.girault@qorvo.com>,
Romuald Despres <romuald.despres@qorvo.com>,
Frederic Blain <frederic.blain@qorvo.com>,
Nicolas Schodet <nico@ni.fr.eu.org>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: Re: [wpan-next 2/4] net: mac802154: Include the softMAC stack inside the IEEE 802.15.4 menu
Date: Fri, 28 Jan 2022 15:04:12 +0100 [thread overview]
Message-ID: <20220128150412.4d3f8a3d@xps13> (raw)
In-Reply-To: <431ac70b-40f8-0666-0919-e3dd20721794@datenfreihafen.org>
Hi Stefan,
stefan@datenfreihafen.org wrote on Fri, 28 Jan 2022 13:35:00 +0100:
> Hello.
>
> On 27.01.22 17:54, Miquel Raynal wrote:
> > Hi Stefan,
> >
> > stefan@datenfreihafen.org wrote on Thu, 27 Jan 2022 17:04:41 +0100:
> >
> >> Hello.
> >>
> >> On 20.01.22 01:43, Miquel Raynal wrote:
> >>> From: David Girault <david.girault@qorvo.com>
> >>>
> >>> The softMAC stack has no meaning outside of the IEEE 802.15.4 stack and
> >>> cannot be used without it.
> >>>
> >>> Signed-off-by: David Girault <david.girault@qorvo.com>
> >>> [miquel.raynal@bootlin.com: Isolate this change from a bigger commit]
> >>> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
> >>> ---
> >>> net/Kconfig | 1 -
> >>> net/ieee802154/Kconfig | 1 +
> >>> 2 files changed, 1 insertion(+), 1 deletion(-)
> >>>
> >>> diff --git a/net/Kconfig b/net/Kconfig
> >>> index 0da89d09ffa6..a5e31078fd14 100644
> >>> --- a/net/Kconfig
> >>> +++ b/net/Kconfig
> >>> @@ -228,7 +228,6 @@ source "net/x25/Kconfig"
> >>> source "net/lapb/Kconfig"
> >>> source "net/phonet/Kconfig"
> >>> source "net/6lowpan/Kconfig"
> >>> -source "net/mac802154/Kconfig"
> >>> source "net/sched/Kconfig"
> >>> source "net/dcb/Kconfig"
> >>> source "net/dns_resolver/Kconfig"
> >>> diff --git a/net/ieee802154/Kconfig b/net/ieee802154/Kconfig
> >>> index 31aed75fe62d..7e4b1d49d445 100644
> >>> --- a/net/ieee802154/Kconfig
> >>> +++ b/net/ieee802154/Kconfig
> >>> @@ -36,6 +36,7 @@ config IEEE802154_SOCKET
> >>> for 802.15.4 dataframes. Also RAW socket interface to build MAC
> >>> header from userspace.
> >>> > +source "net/mac802154/Kconfig"
> >>> source "net/ieee802154/6lowpan/Kconfig"
> >>> > endif
> >>> >>
> >> Please fold this patch into the previous one moving the Kconfig option around. This can be done in one go.
> >
> > Sure.
> >
> > By the way, I was questioning myself: why is the mac802154 folder
> > outside of ieee802154? I don't really understand the organization but
> > as it would massively prevent any of the future changes that I already
> > prepared to apply correctly, I haven't proposed such a move -yet. But
> > I would like to know what's the idea behind the current folder
> > hierarchy?
>
> The directory structure has been in place from the initial merge of the subsystem, before Alex and myself took on the maintainer roles.
>
> I see no reason for a move though. The extra burden for backports, etc outweigh the urge of cleanliness on the folder structure. :-)
That's fair.
> The Kconfig cleanup and move of the file is worth doing, the move of the whole source code folder not.
I agree there is more interesting and less impacting to do in the area,
I was just wondering about that choice.
Thanks,
Miquèl
next prev parent reply other threads:[~2022-01-28 14:04 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-20 0:43 [wpan-next 0/4] ieee802154: General preparation to scan support Miquel Raynal
2022-01-20 0:43 ` [wpan-next 1/4] net: ieee802154: Move IEEE 802.15.4 Kconfig main entry Miquel Raynal
2022-01-20 0:43 ` [wpan-next 2/4] net: mac802154: Include the softMAC stack inside the IEEE 802.15.4 menu Miquel Raynal
2022-01-27 16:04 ` Stefan Schmidt
2022-01-27 16:54 ` Miquel Raynal
2022-01-28 12:35 ` Stefan Schmidt
2022-01-28 14:04 ` Miquel Raynal [this message]
2022-01-30 20:55 ` Alexander Aring
2022-01-20 0:43 ` [wpan-next 3/4] net: ieee802154: Move the address structure earlier Miquel Raynal
2022-01-20 0:43 ` [wpan-next 4/4] net: ieee802154: Add a kernel doc header to the ieee802154_addr structure Miquel Raynal
2022-01-27 16:05 ` Stefan Schmidt
2022-01-27 16:51 ` Miquel Raynal
2022-01-20 13:10 ` [wpan-next 0/4] ieee802154: General preparation to scan support Kalle Valo
2022-01-20 14:28 ` Miquel Raynal
2022-01-20 23:31 ` Alexander Aring
2022-01-21 8:31 ` Miquel Raynal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220128150412.4d3f8a3d@xps13 \
--to=miquel.raynal@bootlin.com \
--cc=alex.aring@gmail.com \
--cc=davem@davemloft.net \
--cc=david.girault@qorvo.com \
--cc=frederic.blain@qorvo.com \
--cc=kuba@kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linux-wpan@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nico@ni.fr.eu.org \
--cc=romuald.despres@qorvo.com \
--cc=stefan@datenfreihafen.org \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).