From: Sascha Hauer <s.hauer@pengutronix.de>
To: Po-Hao Huang <phhuang@realtek.com>
Cc: linux-wireless@vger.kernel.org, Ping-Ke Shih <pkshih@realtek.com>,
Hans Ulli Kroll <linux@ulli-kroll.de>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
netdev@vger.kernel.org, Kalle Valo <kvalo@kernel.org>,
Yan-Hsuan Chuang <tony0620emma@gmail.com>,
linux-kernel@vger.kernel.org, Viktor Petrenko <g0000ga@gmail.com>,
Neo Jou <neojou@gmail.com>, Po-Hao Huang <phhuang@realtek.com>,
kernel@pengutronix.de, Johannes Berg <johannes@sipsolutions.net>,
Alexander Hochbaum <alex@appudo.com>, Da Xue <da@libre.computer>
Subject: Re: [PATCH v3 00/11] RTW88: Add support for USB variants
Date: Tue, 22 Nov 2022 15:55:27 +0100 [thread overview]
Message-ID: <20221122145527.GA29978@pengutronix.de> (raw)
In-Reply-To: <20221122145226.4065843-1-s.hauer@pengutronix.de>
On Tue, Nov 22, 2022 at 03:52:15PM +0100, Sascha Hauer wrote:
> This is the third round of adding support for the USB variants to the
> RTW88 driver. There are a few changes to the last version which make it
> worth looking at this version.
>
> First of all RTL8723du and RTL8821cu are tested working now. The issue
> here was that the txdesc checksum calculation was wrong. I found the
> correct calculation in various downstream drivers found on github.
>
> The second big issue was that TX packet aggregation was wrong. When
> aggregating packets each packet start has to be aligned to eight bytes.
> The necessary alignment was added to the total URB length before
> checking if there is another packet to aggregate, so the URB length
> included that padding after the last packet, which is wrong. Fixing
> this makes the driver work much more reliably.
>
> I added all people to Cc: who showed interest in this driver and I want
> to welcome you for testing and reviewing.
There still is a problem with the RTL8822cu chipset I have here. When
using NetworkManager I immediately lose the connection to the AP after
it has been connected:
[ 376.213846] wlan0: authenticate with 76:83:c2:ce:81:b1
[ 380.085463] wlan0: send auth to 76:83:c2:ce:81:b1 (try 1/3)
[ 380.091446] wlan0: authenticated
[ 380.108864] wlan0: associate with 76:83:c2:ce:81:b1 (try 1/3)
[ 380.136448] wlan0: RX AssocResp from 76:83:c2:ce:81:b1 (capab=0x1411 status=0 aid=2)
[ 380.202955] wlan0: associated
[ 380.268140] IPv6: ADDRCONF(NETDEV_CHANGE): wlan0: link becomes ready
[ 380.275328] wlan0: Connection to AP 76:83:c2:ce:81:b1 lost
That doesn't happen when using plain wpa_supplicant. This seems to go
down to cd96e22bc1da ("rtw88: add beacon filter support"). After being
connected I get a BCN_FILTER_CONNECTION_LOSS beacon. Plain
wpa_supplicant seems to go another code patch and doesn't activate
connection quality monitoring.
The connection to the AP works fluently also with NetworkManager though
when I just ignore the BCN_FILTER_CONNECTION_LOSS beacon.
Any idea what may be wrong here?
Sascha
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2022-11-22 14:57 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-22 14:52 [PATCH v3 00/11] RTW88: Add support for USB variants Sascha Hauer
2022-11-22 14:52 ` [PATCH v3 01/11] rtw88: print firmware type in info message Sascha Hauer
2022-11-25 8:27 ` Ping-Ke Shih
2022-11-22 14:52 ` [PATCH v3 02/11] rtw88: Call rtw_fw_beacon_filter_config() with rtwdev->mutex held Sascha Hauer
2022-11-25 8:27 ` Ping-Ke Shih
2022-11-22 14:52 ` [PATCH v3 03/11] rtw88: Drop rf_lock Sascha Hauer
2022-11-25 8:29 ` Ping-Ke Shih
2022-11-22 14:52 ` [PATCH v3 04/11] rtw88: Drop h2c.lock Sascha Hauer
2022-11-22 14:52 ` [PATCH v3 05/11] rtw88: Drop coex mutex Sascha Hauer
2022-11-22 14:52 ` [PATCH v3 06/11] rtw88: iterate over vif/sta list non-atomically Sascha Hauer
2022-11-25 8:50 ` Ping-Ke Shih
2022-11-22 14:52 ` [PATCH v3 07/11] rtw88: Add common USB chip support Sascha Hauer
2022-11-28 2:00 ` Ping-Ke Shih
2022-11-28 10:30 ` Sascha Hauer
2022-11-28 13:41 ` Kalle Valo
2022-11-22 14:52 ` [PATCH v3 08/11] rtw88: Add rtw8821cu chipset support Sascha Hauer
2022-11-28 2:13 ` Ping-Ke Shih
2022-11-22 14:52 ` [PATCH v3 09/11] rtw88: Add rtw8822bu " Sascha Hauer
2022-11-28 5:39 ` Ryan Finnie
2022-11-22 14:52 ` [PATCH v3 10/11] rtw88: Add rtw8822cu " Sascha Hauer
2022-11-22 14:52 ` [PATCH v3 11/11] rtw88: Add rtw8723du " Sascha Hauer
2022-11-22 14:55 ` Sascha Hauer [this message]
2022-11-24 6:48 ` [PATCH v3 00/11] RTW88: Add support for USB variants Ping-Ke Shih
2022-11-24 8:21 ` Sascha Hauer
2022-11-24 8:26 ` Ping-Ke Shih
2022-11-24 8:36 ` Sascha Hauer
2022-11-24 8:33 ` Kalle Valo
2022-11-24 9:20 ` Sascha Hauer
2022-11-28 3:45 ` Ping-Ke Shih
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221122145527.GA29978@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=alex@appudo.com \
--cc=da@libre.computer \
--cc=g0000ga@gmail.com \
--cc=johannes@sipsolutions.net \
--cc=kernel@pengutronix.de \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linux@ulli-kroll.de \
--cc=martin.blumenstingl@googlemail.com \
--cc=neojou@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=phhuang@realtek.com \
--cc=pkshih@realtek.com \
--cc=tony0620emma@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).