linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: gregory.greenman@intel.com
To: kvalo@kernel.org, johannes@sipsolutions.net
Cc: linux-wireless@vger.kernel.org,
	Mukesh Sisodiya <mukesh.sisodiya@intel.com>,
	Gregory Greenman <gregory.greenman@intel.com>
Subject: [PATCH 10/11] wifi: iwlwifi: dump: Update check for UMAC valid FW address
Date: Mon,  5 Dec 2022 10:35:47 +0200	[thread overview]
Message-ID: <20221205102808.e4b7fc650144.I46103baf400bb4ae69d82738e402a3903b17c030@changeid> (raw)
In-Reply-To: <20221205083548.236620-1-gregory.greenman@intel.com>

From: Mukesh Sisodiya <mukesh.sisodiya@intel.com>

The error dump base address check for UMAC
need an update based on current hardware.

Signed-off-by: Mukesh Sisodiya <mukesh.sisodiya@intel.com>
Signed-off-by: Gregory Greenman <gregory.greenman@intel.com>
---
 drivers/net/wireless/intel/iwlwifi/mvm/fw.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/fw.c b/drivers/net/wireless/intel/iwlwifi/mvm/fw.c
index 0a41cd0ab243..0c6b49fcb00d 100644
--- a/drivers/net/wireless/intel/iwlwifi/mvm/fw.c
+++ b/drivers/net/wireless/intel/iwlwifi/mvm/fw.c
@@ -122,6 +122,9 @@ static bool iwl_alive_fn(struct iwl_notif_wait_data *notif_wait,
 	u32 version = iwl_fw_lookup_notif_ver(mvm->fw, LEGACY_GROUP,
 					      UCODE_ALIVE_NTFY, 0);
 	u32 i;
+	struct iwl_trans *trans = mvm->trans;
+	enum iwl_device_family device_family = trans->trans_cfg->device_family;
+
 
 	if (version == 6) {
 		struct iwl_alive_ntf_v6 *palive;
@@ -230,7 +233,8 @@ static bool iwl_alive_fn(struct iwl_notif_wait_data *notif_wait,
 
 	if (umac_error_table) {
 		if (umac_error_table >=
-		    mvm->trans->cfg->min_umac_error_event_table) {
+		    mvm->trans->cfg->min_umac_error_event_table ||
+		    device_family >= IWL_DEVICE_FAMILY_BZ) {
 			iwl_fw_umac_set_alive_err_table(mvm->trans,
 							umac_error_table);
 		} else {
-- 
2.35.3


  parent reply	other threads:[~2022-12-05  8:37 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-05  8:35 [PATCH 00/11] updates intended for v6.2 2022-12-05 gregory.greenman
2022-12-05  8:35 ` [PATCH 01/11] wifi: iwlwifi: nvm-parse: enable WiFi7 for Fm radio for now gregory.greenman
2022-12-05  8:35 ` [PATCH 02/11] wifi: iwlwifi: modify new queue allocation command gregory.greenman
2022-12-05  8:35 ` [PATCH 03/11] wifi: iwlwifi: mvm: don't access packet before checking len gregory.greenman
2022-12-05  8:35 ` [PATCH 04/11] wifi: iwlwifi: dump: Update check for valid FW address gregory.greenman
2022-12-05  8:35 ` [PATCH 05/11] wifi: iwlwifi: mvm: replace usage of found with dedicated list iterator variable gregory.greenman
2022-12-05  8:35 ` [PATCH 06/11] wifi: iwlwifi: pcie: Add reading and storing of crf and cdb id gregory.greenman
2022-12-05  8:35 ` [PATCH 07/11] wifi: iwlwifi: mvm: Don't use deprecated register gregory.greenman
2022-12-05  8:35 ` [PATCH 08/11] wifi: iwlwifi: mei: clean up comments gregory.greenman
2022-12-05  8:35 ` [PATCH 09/11] wifi: iwlwifi: mvm: d3: add TKIP to the GTK iterator gregory.greenman
2022-12-05  8:35 ` gregory.greenman [this message]
2022-12-05  8:35 ` [PATCH 11/11] wifi: iwlwifi: fw: use correct IML/ROM status register gregory.greenman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221205102808.e4b7fc650144.I46103baf400bb4ae69d82738e402a3903b17c030@changeid \
    --to=gregory.greenman@intel.com \
    --cc=johannes@sipsolutions.net \
    --cc=kvalo@kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=mukesh.sisodiya@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).