archive mirror
 help / color / mirror / Atom feed
From: Nikita Zhandarovich <>
To: <>,
	Greg Kroah-Hartman <>
Cc: Nikita Zhandarovich <>,
	Felix Fietkau <>,
	Lorenzo Bianconi <>,
	Ryder Lee <>,
	Kalle Valo <>,
	<>, <>,
	"Alexey Khoroshilov" <>,
Subject: [PATCH 5.10 0/1] mt76: move mt76_init_tx_queue in common code
Date: Sun, 22 Jan 2023 07:59:10 -0800	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

My apologies, I should've have explained my reasoning for the patch better (and sooner).

1. My issue with 5.10 version of mt7615_init_tx_queues() in drivers/net/wireless/mediatek/mt76/mt7615/dma.c is that return value of final call to mt7615_init_tx_queue() is not taken into account
when returning result of mt7615_init_tx_queues(). So, if last mt7615_init_tx_queue() fails (due to memory issues, for instance), parent function will still erroneously return 0.

2. To correct the issue, I turned to Lorenzo's patch in b671da33d1c5973f90f098ff66a91953691df582 which solves my petit problem as well as rewrites a single mt76_init_tx_queue() function to be used
across all mt76 drivers.

3. I was torn between writing my own little patch to fix a single mistake or use an existing one that increases code readability and uniformity. I settled on latter.

4. As for this patch exclusivity to 5.10.y branch, I have an incentive to prioritize 5.10 of all others. Wasn't sure I should be the one to suggest the patch for other branches but it does make sense.

Keep having issues with quoting emails properly, hope this one worked fine.



  reply	other threads:[~2023-01-22 15:59 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-12 11:58 [PATCH 5.10 0/1] mt76: move mt76_init_tx_queue in common code Nikita Zhandarovich
2023-01-12 11:58 ` [PATCH 5.10 1/1] " Nikita Zhandarovich
2023-01-22 15:59   ` Nikita Zhandarovich [this message]
2023-01-27  7:35     ` [PATCH 5.10 0/1] " Greg Kroah-Hartman
2023-01-12 12:58 ` Greg Kroah-Hartman
2023-01-13 15:04   ` Nikita Zhandarovich
2023-01-14 13:46     ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).