linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Larry Finger <Larry.Finger@lwfinger.net>
To: Kalle Valo <kvalo@kernel.org>
Cc: Johannes Berg <johannes@sipsolutions.net>,
	linux-wireless@vger.kernel.org,
	Larry Finger <Larry.Finger@lwfinger.net>
Subject: [PATCH] wifi: wext: Eliminate log spamming in wireless_warn_cfg80211_wext()
Date: Wed, 22 Feb 2023 14:49:45 -0600	[thread overview]
Message-ID: <20230222204945.6716-1-Larry.Finger@lwfinger.net> (raw)

Commit dc09766c755c {"wifi: wireless: warn on most wireless extension
usage") introduces a warning when wireless extensions are used with
cfg80211 drivers. Although such a warning is desirable, the current
implementation overflows the dmesg buffer with thousands of warnings,
all of which are the same. A WARN_ONCE() call is sufficient.

Fixes: dc09766c755c {"wifi: wireless: warn on most wireless extension usage")
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
---

Kalle,

If accepted, this patch should be send to kernel 6.3.

Larry
---
 net/wireless/wext-core.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/net/wireless/wext-core.c b/net/wireless/wext-core.c
index 13a72b17248e..9589ba5dafc2 100644
--- a/net/wireless/wext-core.c
+++ b/net/wireless/wext-core.c
@@ -641,8 +641,8 @@ static void wireless_warn_cfg80211_wext(void)
 {
 	char name[sizeof(current->comm)];
 
-	pr_warn_ratelimited("warning: `%s' uses wireless extensions that are deprecated for modern drivers; use nl80211\n",
-			    get_task_comm(name, current));
+	WARN_ONCE(1, "warning: `%s' uses wireless extensions that are deprecated for modern drivers; use nl80211\n",
+		  get_task_comm(name, current));
 }
 #endif
 
-- 
2.39.2


             reply	other threads:[~2023-02-22 20:50 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-22 20:49 Larry Finger [this message]
2023-02-23  8:12 ` [PATCH] wifi: wext: Eliminate log spamming in wireless_warn_cfg80211_wext() Johannes Berg
2023-02-23 16:07   ` Larry Finger
2023-02-24  9:05     ` Nicolas Cavallari
2023-02-23 23:09   ` Larry Finger
2023-02-24 13:09     ` Kalle Valo
2023-02-24 15:55       ` Larry Finger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230222204945.6716-1-Larry.Finger@lwfinger.net \
    --to=larry.finger@lwfinger.net \
    --cc=johannes@sipsolutions.net \
    --cc=kvalo@kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).