From: Jonathan Cameron <Jonathan.Cameron@Huawei.com>
To: Rob Herring <robh@kernel.org>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>,
Len Brown <lenb@kernel.org>,
Marcelo Schmitt <marcelo.schmitt1@gmail.com>,
Lars-Peter Clausen <lars@metafoo.de>,
Michael Hennerich <Michael.Hennerich@analog.com>,
Jonathan Cameron <jic23@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Johannes Berg <johannes@sipsolutions.net>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Jiri Slaby <jirislaby@kernel.org>,
Thierry Reding <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
"Marc Zyngier" <maz@kernel.org>, <linux-iio@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <linux-staging@lists.linux.dev>,
<linux-wireless@vger.kernel.org>, <netdev@vger.kernel.org>,
<linux-serial@vger.kernel.org>, <linux-tegra@vger.kernel.org>,
<linux-acpi@vger.kernel.org>, <devicetree@vger.kernel.org>
Subject: Re: [PATCH 2/5] staging: iio: resolver: ad2s1210: Add explicit include for of.h
Date: Thu, 30 Mar 2023 09:38:20 +0100 [thread overview]
Message-ID: <20230330093820.0000639d@Huawei.com> (raw)
In-Reply-To: <20230329-acpi-header-cleanup-v1-2-8dc5cd3c610e@kernel.org>
On Wed, 29 Mar 2023 16:20:43 -0500
Rob Herring <robh@kernel.org> wrote:
> With linux/acpi.h no longer implicitly including of.h, add an explicit
> include of of.h to fix the following error:
>
> drivers/staging/iio/resolver/ad2s1210.c:706:21: error: implicit declaration of function 'of_match_ptr' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
>
> Signed-off-by: Rob Herring <robh@kernel.org>
Acked-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> ---
> drivers/staging/iio/resolver/ad2s1210.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/iio/resolver/ad2s1210.c b/drivers/staging/iio/resolver/ad2s1210.c
> index e4cf42438487..eb364639fa58 100644
> --- a/drivers/staging/iio/resolver/ad2s1210.c
> +++ b/drivers/staging/iio/resolver/ad2s1210.c
> @@ -7,6 +7,7 @@
> #include <linux/types.h>
> #include <linux/mutex.h>
> #include <linux/device.h>
> +#include <linux/of.h>
> #include <linux/spi/spi.h>
> #include <linux/slab.h>
> #include <linux/sysfs.h>
>
next prev parent reply other threads:[~2023-03-30 8:38 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-29 21:20 [PATCH 0/5] Remove acpi.h implicit include of of.h Rob Herring
2023-03-29 21:20 ` [PATCH 1/5] iio: adc: ad7292: Add explicit include for of.h Rob Herring
2023-03-30 1:10 ` Marcelo Schmitt
2023-03-30 8:38 ` Jonathan Cameron
2023-03-29 21:20 ` [PATCH 2/5] staging: iio: resolver: ad2s1210: " Rob Herring
2023-03-30 8:38 ` Jonathan Cameron [this message]
2023-03-29 21:20 ` [PATCH 3/5] net: rfkill-gpio: " Rob Herring
2023-03-29 21:27 ` Johannes Berg
2023-03-29 21:20 ` [PATCH 4/5] serial: 8250_tegra: " Rob Herring
2023-03-30 8:50 ` Jon Hunter
2023-03-29 21:20 ` [PATCH 5/5] ACPI: Replace irqdomain.h include with struct declarations Rob Herring
2023-04-05 14:59 ` Rafael J. Wysocki
2023-04-05 16:47 ` Rob Herring
2023-04-05 18:11 ` Rafael J. Wysocki
2023-03-29 23:23 ` [PATCH 0/5] Remove acpi.h implicit include of of.h Keller, Jacob E
2023-03-30 6:13 ` Greg Kroah-Hartman
2023-03-30 17:18 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230330093820.0000639d@Huawei.com \
--to=jonathan.cameron@huawei.com \
--cc=Michael.Hennerich@analog.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=jic23@kernel.org \
--cc=jirislaby@kernel.org \
--cc=johannes@sipsolutions.net \
--cc=jonathanh@nvidia.com \
--cc=kuba@kernel.org \
--cc=lars@metafoo.de \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=linux-tegra@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=marcelo.schmitt1@gmail.com \
--cc=maz@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rafael@kernel.org \
--cc=robh@kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).