linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: gregory.greenman@intel.com
To: johannes@sipsolutions.net
Cc: linux-wireless@vger.kernel.org,
	Benjamin Berg <benjamin.berg@intel.com>,
	Gregory Greenman <gregory.greenman@intel.com>
Subject: [PATCH 06/14] wifi: iwlwifi: do not log undefined DRAM buffers unnecessarily
Date: Wed, 31 May 2023 19:49:58 +0300	[thread overview]
Message-ID: <20230531194629.ecae60cf2d7f.Ib44a94d4aeb55dbb2e52edea8b69a09bc0f722c3@changeid> (raw)
In-Reply-To: <20230531165006.273284-1-gregory.greenman@intel.com>

From: Benjamin Berg <benjamin.berg@intel.com>

DRAM buffers that are not defined in the TLVs (or are unused in the
preset) would cause a log message. To avoid confusion, skip processing
buffers with an invalid (i.e. uninitialized) DRAM path.

This further reduces the noise of the message in cases where it is
unlikely to be helpful. Also update a related debug log string to better
describe what is happening.

Signed-off-by: Benjamin Berg <benjamin.berg@intel.com>
Signed-off-by: Gregory Greenman <gregory.greenman@intel.com>
---
 drivers/net/wireless/intel/iwlwifi/iwl-dbg-tlv.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/drivers/net/wireless/intel/iwlwifi/iwl-dbg-tlv.c b/drivers/net/wireless/intel/iwlwifi/iwl-dbg-tlv.c
index 898d5dcf1012..fb0277bd12cf 100644
--- a/drivers/net/wireless/intel/iwlwifi/iwl-dbg-tlv.c
+++ b/drivers/net/wireless/intel/iwlwifi/iwl-dbg-tlv.c
@@ -738,7 +738,8 @@ static int iwl_dbg_tlv_update_dram(struct iwl_fw_runtime *fwrt,
 
 	if (le32_to_cpu(fwrt->trans->dbg.fw_mon_cfg[alloc_id].buf_location) !=
 			IWL_FW_INI_LOCATION_DRAM_PATH) {
-		IWL_DEBUG_FW(fwrt, "DRAM_PATH is not supported alloc_id %u\n", alloc_id);
+		IWL_DEBUG_FW(fwrt, "WRT: alloc_id %u location is not in DRAM_PATH\n",
+			     alloc_id);
 		return -1;
 	}
 
@@ -799,6 +800,10 @@ static void iwl_dbg_tlv_update_drams(struct iwl_fw_runtime *fwrt)
 
 	for (i = IWL_FW_INI_ALLOCATION_ID_DBGC1;
 	     i < IWL_FW_INI_ALLOCATION_NUM; i++) {
+		if (fwrt->trans->dbg.fw_mon_cfg[i].buf_location ==
+				IWL_FW_INI_LOCATION_INVALID)
+			continue;
+
 		ret = iwl_dbg_tlv_update_dram(fwrt, i, dram_info);
 		if (!ret)
 			dram_alloc = true;
-- 
2.38.1


  parent reply	other threads:[~2023-05-31 16:51 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-31 16:49 [PATCH 00/14] wifi: iwlwifi: updates intended for v6.5 2023-05-31 gregory.greenman
2023-05-31 16:49 ` [PATCH 01/14] wifi: iwlwifi: fix Bz checksum start/result offset gregory.greenman
2023-05-31 16:49 ` [PATCH 02/14] wifi: iwlwifi: Add vendors to TAS approved list gregory.greenman
2023-05-31 16:49 ` [PATCH 03/14] wifi: iwlwifi: mvm: support injection rate control gregory.greenman
2023-05-31 16:49 ` [PATCH 04/14] wifi: iwlwifi: mvm: clarify EHT RU allocation bits gregory.greenman
2023-05-31 16:49 ` [PATCH 05/14] wifi: iwlwifi: acpi: add other Google OEMs to the ppag approved list gregory.greenman
2023-05-31 16:49 ` gregory.greenman [this message]
2023-05-31 16:49 ` [PATCH 07/14] wifi: iwlwifi: mvm: offload BTM response during D3 gregory.greenman
2023-05-31 16:50 ` [PATCH 08/14] wifi: iwlwifi: pcie: adjust Bz device timings gregory.greenman
2023-05-31 16:50 ` [PATCH 09/14] wifi: iwlwifi: mvm: FTM initiator MLO support gregory.greenman
2023-05-31 16:50 ` [PATCH 10/14] wifi: iwlwifi: mvm: tell firmware about per-STA MFP enablement gregory.greenman
2023-05-31 16:50 ` [PATCH 11/14] wifi: iwlwifi: Add Dell to ppag approved list gregory.greenman
2023-05-31 16:50 ` [PATCH 12/14] wifi: iwlwifi: remove dead code in iwl_dump_ini_imr_get_size() gregory.greenman
2023-05-31 16:50 ` [PATCH 13/14] wifi: iwlwifi: mvm: remove warning for beacon filtering error gregory.greenman
2023-05-31 16:50 ` [PATCH 14/14] wifi: iwlwifi: mvm: send time sync only if needed gregory.greenman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230531194629.ecae60cf2d7f.Ib44a94d4aeb55dbb2e52edea8b69a09bc0f722c3@changeid \
    --to=gregory.greenman@intel.com \
    --cc=benjamin.berg@intel.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).