From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Kalle Valo <kvalo@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Cc: ath10k@lists.infradead.org, linux-wireless@vger.kernel.org,
netdev@vger.kernel.org, kernel@pengutronix.de
Subject: [PATCH net-next 1/4] ath10k: Drop cleaning of driver data from probe error path and remove
Date: Thu, 1 Jun 2023 10:25:53 +0200 [thread overview]
Message-ID: <20230601082556.2738446-2-u.kleine-koenig@pengutronix.de> (raw)
In-Reply-To: <20230601082556.2738446-1-u.kleine-koenig@pengutronix.de>
The driver core cares for resetting driver data if probe fails and after
remove. So drop the explicit and duplicate cleanup in the driver's
functions.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
drivers/net/wireless/ath/ath10k/ahb.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/net/wireless/ath/ath10k/ahb.c b/drivers/net/wireless/ath/ath10k/ahb.c
index f0c615fa5614..7bb45c66cff7 100644
--- a/drivers/net/wireless/ath/ath10k/ahb.c
+++ b/drivers/net/wireless/ath/ath10k/ahb.c
@@ -816,7 +816,6 @@ static int ath10k_ahb_probe(struct platform_device *pdev)
err_core_destroy:
ath10k_core_destroy(ar);
- platform_set_drvdata(pdev, NULL);
return ret;
}
@@ -845,8 +844,6 @@ static int ath10k_ahb_remove(struct platform_device *pdev)
ath10k_ahb_resource_deinit(ar);
ath10k_core_destroy(ar);
- platform_set_drvdata(pdev, NULL);
-
return 0;
}
--
2.39.2
next prev parent reply other threads:[~2023-06-01 8:26 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-01 8:25 [PATCH net-next 0/4] Convert to platform remove callback returning void Uwe Kleine-König
2023-06-01 8:25 ` Uwe Kleine-König [this message]
2023-06-01 16:16 ` [PATCH net-next 1/4] ath10k: Drop cleaning of driver data from probe error path and remove Simon Horman
2023-06-09 12:28 ` Kalle Valo
2023-06-01 8:25 ` [PATCH net-next 2/4] ath10k: Drop checks that are always false Uwe Kleine-König
2023-06-01 16:16 ` Simon Horman
2023-06-01 8:25 ` [PATCH net-next 3/4] ath10k: Convert to platform remove callback returning void Uwe Kleine-König
2023-06-01 16:18 ` Simon Horman
2023-06-01 8:25 ` [PATCH net-next 4/4] atk10k: Don't opencode ath10k_pci_priv() in ath10k_ahb_priv() Uwe Kleine-König
2023-06-01 16:17 ` Simon Horman
2023-06-01 9:17 ` [PATCH net-next 0/4] Convert to platform remove callback returning void Kalle Valo
2023-06-01 9:30 ` Uwe Kleine-König
2023-06-01 10:44 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230601082556.2738446-2-u.kleine-koenig@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=ath10k@lists.infradead.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kernel@pengutronix.de \
--cc=kuba@kernel.org \
--cc=kvalo@kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).