From: Minjie Du <duminjie@vivo.com>
To: Gregory Greenman <gregory.greenman@intel.com>,
Kalle Valo <kvalo@kernel.org>, Minjie Du <duminjie@vivo.com>,
Stephen Rothwell <sfr@canb.auug.org.au>,
linux-wireless@vger.kernel.org (open list:INTEL WIRELESS WIFI
LINK (iwlwifi)), linux-kernel@vger.kernel.org (open list)
Cc: opensource.kernel@vivo.com
Subject: [PATCH v1] drivers/net: intel: iwlwifi: fix two parameters check in iwl_mei_dbgfs_register()
Date: Wed, 12 Jul 2023 21:14:06 +0800 [thread overview]
Message-ID: <20230712131407.16462-1-duminjie@vivo.com> (raw)
Make IS_ERR() judge the debugfs_create_dir() function return
in iwl_mei_dbgfs_register().
Signed-off-by: Minjie Du <duminjie@vivo.com>
---
drivers/net/wireless/intel/iwlwifi/mei/main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/intel/iwlwifi/mei/main.c b/drivers/net/wireless/intel/iwlwifi/mei/main.c
index 54445f39f..e5d203a62 100644
--- a/drivers/net/wireless/intel/iwlwifi/mei/main.c
+++ b/drivers/net/wireless/intel/iwlwifi/mei/main.c
@@ -1888,7 +1888,7 @@ static void iwl_mei_dbgfs_register(struct iwl_mei *mei)
{
mei->dbgfs_dir = debugfs_create_dir(KBUILD_MODNAME, NULL);
- if (!mei->dbgfs_dir)
+ if (IS_ERR(mei->dbgfs_dir))
return;
debugfs_create_ulong("status", S_IRUSR,
--
2.39.0
next reply other threads:[~2023-07-12 13:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-12 13:14 Minjie Du [this message]
2023-07-12 14:01 ` [PATCH v1] drivers/net: intel: iwlwifi: fix two parameters check in iwl_mei_dbgfs_register() Nicolas Escande
2023-08-13 15:27 ` Greenman, Gregory
2023-08-21 12:46 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230712131407.16462-1-duminjie@vivo.com \
--to=duminjie@vivo.com \
--cc=gregory.greenman@intel.com \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=opensource.kernel@vivo.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).