From: Dmitry Antipov <dmantipov@yandex.ru>
To: Felix Fietkau <nbd@nbd.name>
Cc: Kalle Valo <kvalo@kernel.org>,
linux-wireless@vger.kernel.org, lvc-project@linuxtesting.org,
Dmitry Antipov <dmantipov@yandex.ru>
Subject: [PATCH 1/4] wifi: mt76: handle possible error returned by sdio_set_host_pm_flags()
Date: Tue, 1 Aug 2023 07:57:20 +0300 [thread overview]
Message-ID: <20230801050000.18864-1-dmantipov@yandex.ru> (raw)
In 'mt7663s_suspend()', drop nested declaration of 'err' and
handle possible error returned by 'sdio_set_host_pm_flags()'.
Found by Linux Verification Center (linuxtesting.org) with SVACE.
Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru>
---
drivers/net/wireless/mediatek/mt76/mt7615/sdio.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/wireless/mediatek/mt76/mt7615/sdio.c b/drivers/net/wireless/mediatek/mt76/mt7615/sdio.c
index fc547a0031ea..6607577d22cf 100644
--- a/drivers/net/wireless/mediatek/mt76/mt7615/sdio.c
+++ b/drivers/net/wireless/mediatek/mt76/mt7615/sdio.c
@@ -188,14 +188,14 @@ static int mt7663s_suspend(struct device *dev)
if (!test_bit(MT76_STATE_SUSPEND, &mdev->mphy.state) &&
mt7615_firmware_offload(mdev)) {
- int err;
-
err = mt76_connac_mcu_set_hif_suspend(&mdev->mt76, true);
if (err < 0)
return err;
}
- sdio_set_host_pm_flags(func, MMC_PM_KEEP_POWER);
+ err = sdio_set_host_pm_flags(func, MMC_PM_KEEP_POWER);
+ if (err)
+ return err;
err = mt7615_mcu_set_fw_ctrl(mdev);
if (err)
--
2.41.0
next reply other threads:[~2023-08-01 5:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-01 4:57 Dmitry Antipov [this message]
2023-08-01 4:57 ` [PATCH 2/4] wifi: mt76: handle possible hardware timeout in mt7603_pse_client_reset() Dmitry Antipov
2023-08-01 4:57 ` [PATCH 3/4] wifi: mt76: handle possible hardware timeout in mt76x0_phy_tssi_dc_calibrate() Dmitry Antipov
2023-08-01 4:57 ` [PATCH 4/4] wifi: mt76: adjust error handling in mt76s_txrx_worker() Dmitry Antipov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230801050000.18864-1-dmantipov@yandex.ru \
--to=dmantipov@yandex.ru \
--cc=kvalo@kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lvc-project@linuxtesting.org \
--cc=nbd@nbd.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).