From: greearb@candelatech.com
To: linux-wireless@vger.kernel.org
Cc: Ben Greear <greearb@candelatech.com>
Subject: [PATCH 1/6] wifi: mt76: mt7996: add debugging for MCU command timeouts.
Date: Thu, 7 Mar 2024 11:29:46 -0800 [thread overview]
Message-ID: <20240307192951.3271156-1-greearb@candelatech.com> (raw)
From: Ben Greear <greearb@candelatech.com>
Print information about whether the message is the first timeout,
and also print info if we manage to recover after a timeout.
Signed-off-by: Ben Greear <greearb@candelatech.com>
---
drivers/net/wireless/mediatek/mt76/mt76.h | 2 ++
.../net/wireless/mediatek/mt76/mt7996/mcu.c | 31 +++++++++++++++++--
2 files changed, 30 insertions(+), 3 deletions(-)
diff --git a/drivers/net/wireless/mediatek/mt76/mt76.h b/drivers/net/wireless/mediatek/mt76/mt76.h
index b20c34d5a0f7..c341915e4d62 100644
--- a/drivers/net/wireless/mediatek/mt76/mt76.h
+++ b/drivers/net/wireless/mediatek/mt76/mt76.h
@@ -829,6 +829,8 @@ struct mt76_dev {
struct device *dma_dev;
struct mt76_mcu mcu;
+ u32 first_failed_mcu_cmd; /* for debugging */
+ u32 last_successful_mcu_cmd; /* for debugging */
struct net_device napi_dev;
struct net_device tx_napi_dev;
diff --git a/drivers/net/wireless/mediatek/mt76/mt7996/mcu.c b/drivers/net/wireless/mediatek/mt76/mt7996/mcu.c
index 699be57309c2..a858a0914bf0 100644
--- a/drivers/net/wireless/mediatek/mt76/mt7996/mcu.c
+++ b/drivers/net/wireless/mediatek/mt76/mt7996/mcu.c
@@ -200,14 +200,39 @@ mt7996_mcu_parse_response(struct mt76_dev *mdev, int cmd,
int ret = 0;
if (!skb) {
- dev_err(mdev->dev, "Message %08x (seq %d) timeout\n",
- cmd, seq);
+ const char *first = "Secondary";
+
+ if (!mdev->first_failed_mcu_cmd)
+ first = "Initial";
+
+ dev_err(mdev->dev,
+ "MCU: %s Failure: Message %08x (cid %lx ext_cid: %lx seq %d) timeout. Last successful cmd: 0x%x\n",
+ first,
+ cmd, FIELD_GET(__MCU_CMD_FIELD_ID, cmd),
+ FIELD_GET(__MCU_CMD_FIELD_EXT_ID, cmd), seq,
+ mdev->last_successful_mcu_cmd);
+
+ if (!mdev->first_failed_mcu_cmd)
+ mdev->first_failed_mcu_cmd = cmd;
return -ETIMEDOUT;
}
+ mdev->last_successful_mcu_cmd = cmd;
+
+ if (mdev->first_failed_mcu_cmd) {
+ dev_err(mdev->dev, "MCU: First success after failure: Message %08x (cid %lx ext_cid: %lx seq %d)\n",
+ cmd, FIELD_GET(__MCU_CMD_FIELD_ID, cmd),
+ FIELD_GET(__MCU_CMD_FIELD_EXT_ID, cmd), seq);
+ mdev->first_failed_mcu_cmd = 0;
+ }
+
rxd = (struct mt7996_mcu_rxd *)skb->data;
- if (seq != rxd->seq)
+ if (seq != rxd->seq) {
+ /* This can happen if the previous request didn't wait (which is normal).
+ * Quietly return EAGAIN in that case, it is not something to warn about.
+ */
return -EAGAIN;
+ }
if (cmd == MCU_CMD(PATCH_SEM_CONTROL)) {
skb_pull(skb, sizeof(*rxd) - 4);
--
2.42.0
next reply other threads:[~2024-03-07 19:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-07 19:29 greearb [this message]
2024-03-07 19:29 ` [PATCH 2/6] wifi: mt76: mt7996: add configured logging greearb
2024-03-07 19:29 ` [PATCH 3/6] wifi: mt76: mt7996: Enable spectrum management hw flag greearb
2024-03-07 19:29 ` [PATCH 4/6] wifi: mt76: mt7915: Mitigate mcu communication loss greearb
2024-03-07 19:29 ` [PATCH 5/6] wifi: mt76: mt7996: " greearb
2024-03-07 19:29 ` [PATCH 6/6] wifi: mt76: mt7996: Allow ignoring radar events greearb
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240307192951.3271156-1-greearb@candelatech.com \
--to=greearb@candelatech.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).