linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Fiona Klute <fiona.klute@gmx.de>
To: linux-wireless@vger.kernel.org, Ping-Ke Shih <pkshih@realtek.com>
Cc: "Fiona Klute" <fiona.klute@gmx.de>,
	"Kalle Valo" <kvalo@kernel.org>,
	"Ulf Hansson" <ulf.hansson@linaro.org>,
	linux-mmc@vger.kernel.org, "Pavel Machek" <pavel@ucw.cz>,
	"Ondřej Jirman" <megi@xff.cz>
Subject: [PATCH v4 0/9] rtw88: Add support for RTL8723CS/RTL8703B
Date: Mon, 11 Mar 2024 11:37:04 +0100	[thread overview]
Message-ID: <20240311103735.615541-1-fiona.klute@gmx.de> (raw)

This patch set adds a driver for RTL8723CS, which is used in the
Pinephone and a few other devices. It is a combined wifi/bluetooth
device, the wifi part is called RTL8703B. There is already a mainline
driver for the bluetooth part. RTL8703B is similar to the RTL8723D
chip already supported by rtw88. I've been using the out-of-tree
rtl8723cs driver as reference.

Station and monitor mode work well enough for daily use on my
Pinephone, I have not tested other modes yet. WOW firmware is
declared, but WOW isn't implemented yet. RX rates stay fairly low
still.

Ping-Ke Shih kindly offered to add the required s-o-b for the firmware
and help get it into linux-firmware when it's time, for testing now
please see the code I used to extract firmware from the out-of-tree
driver [1].

Thanks to Ping-Ke Shih for advice, and Ondřej Jirman for debug logs!

[1] https://github.com/airtower-luna/rtw8703b-fw-extractor

v2:
  * Parse PHY status using struct instead of macros
  * Prefer MAC from EFUSE if available, move retrieving MAC from DT to
    a separate function
  * Tidy up wait for IQK to be done, replace mdelay loop with
    read_poll_timeout
  * Set dual author for rtw88_8723x
  * Add missing "static" to rtw8723x function declarations, fixes
    build failure when not built as a module
  * Various style fixes

v3 has only minor changes requested in review, so I hope it's good to
merge now:
  * rtw8703b.h: #include rtw8723x.h instead of linux/types.h and
    linux/compiler_attributes.h
  * rtw8703b_tables.c: #include rtw8703b_tables.h
  * rtw8703b.c: define TRANS_SEQ_END without braces (checkpatch.pl
    doesn't like this, but I assume maintainer request overrides it)

v4:
  * Move definition of GET_RX_DESC_BW from rtw8703b.c to rx.h (now in
    patch 3/9 "wifi: rtw88: Add definitions for 8703b chip")

Fiona Klute (9):
  wifi: rtw88: Shared module for rtw8723x devices
  wifi: rtw88: Debug output for rtw8723x EFUSE
  wifi: rtw88: Add definitions for 8703b chip
  wifi: rtw88: Add rtw8703b.h
  wifi: rtw88: Add rtw8703b.c
  wifi: rtw88: Add rtw8703b_tables.h
  wifi: rtw88: Add rtw8703b_tables.c
  wifi: rtw88: Reset 8703b firmware before download
  wifi: rtw88: SDIO device driver for RTL8723CS

 drivers/net/wireless/realtek/rtw88/Kconfig    |   22 +
 drivers/net/wireless/realtek/rtw88/Makefile   |    9 +
 drivers/net/wireless/realtek/rtw88/mac.c      |    6 +
 drivers/net/wireless/realtek/rtw88/main.h     |    3 +
 drivers/net/wireless/realtek/rtw88/rtw8703b.c | 2109 +++++++++++++++++
 drivers/net/wireless/realtek/rtw88/rtw8703b.h |  102 +
 .../wireless/realtek/rtw88/rtw8703b_tables.c  |  902 +++++++
 .../wireless/realtek/rtw88/rtw8703b_tables.h  |   14 +
 .../net/wireless/realtek/rtw88/rtw8723cs.c    |   34 +
 drivers/net/wireless/realtek/rtw88/rtw8723d.c |  673 +-----
 drivers/net/wireless/realtek/rtw88/rtw8723d.h |  269 +--
 drivers/net/wireless/realtek/rtw88/rtw8723x.c |  721 ++++++
 drivers/net/wireless/realtek/rtw88/rtw8723x.h |  518 ++++
 drivers/net/wireless/realtek/rtw88/rx.h       |    2 +
 include/linux/mmc/sdio_ids.h                  |    1 +
 15 files changed, 4485 insertions(+), 900 deletions(-)
 create mode 100644 drivers/net/wireless/realtek/rtw88/rtw8703b.c
 create mode 100644 drivers/net/wireless/realtek/rtw88/rtw8703b.h
 create mode 100644 drivers/net/wireless/realtek/rtw88/rtw8703b_tables.c
 create mode 100644 drivers/net/wireless/realtek/rtw88/rtw8703b_tables.h
 create mode 100644 drivers/net/wireless/realtek/rtw88/rtw8723cs.c
 create mode 100644 drivers/net/wireless/realtek/rtw88/rtw8723x.c
 create mode 100644 drivers/net/wireless/realtek/rtw88/rtw8723x.h

--
2.43.0


             reply	other threads:[~2024-03-11 10:38 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-11 10:37 Fiona Klute [this message]
2024-03-11 10:37 ` [PATCH v4 1/9] wifi: rtw88: Shared module for rtw8723x devices Fiona Klute
2024-03-14  9:00   ` Kalle Valo
2024-03-11 10:37 ` [PATCH v4 2/9] wifi: rtw88: Debug output for rtw8723x EFUSE Fiona Klute
2024-03-11 10:37 ` [PATCH v4 3/9] wifi: rtw88: Add definitions for 8703b chip Fiona Klute
2024-03-11 10:37 ` [PATCH v4 4/9] wifi: rtw88: Add rtw8703b.h Fiona Klute
2024-03-11 10:37 ` [PATCH v4 5/9] wifi: rtw88: Add rtw8703b.c Fiona Klute
2024-03-11 10:37 ` [PATCH v4 6/9] wifi: rtw88: Add rtw8703b_tables.h Fiona Klute
2024-03-11 10:37 ` [PATCH v4 7/9] wifi: rtw88: Add rtw8703b_tables.c Fiona Klute
2024-03-11 10:37 ` [PATCH v4 8/9] wifi: rtw88: Reset 8703b firmware before download Fiona Klute
2024-03-11 10:37 ` [PATCH v4 9/9] wifi: rtw88: SDIO device driver for RTL8723CS Fiona Klute
2024-03-12  2:58 ` [PATCH v4 0/9] rtw88: Add support for RTL8723CS/RTL8703B Ping-Ke Shih
2024-03-12  8:43   ` Pavel Machek
2024-03-12  9:00     ` Ping-Ke Shih
2024-03-12 16:09       ` Larry Finger
2024-03-13 13:15       ` Fiona Klute
2024-03-14  0:18         ` Ping-Ke Shih
2024-03-14  9:02           ` Fiona Klute

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240311103735.615541-1-fiona.klute@gmx.de \
    --to=fiona.klute@gmx.de \
    --cc=kvalo@kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=megi@xff.cz \
    --cc=pavel@ucw.cz \
    --cc=pkshih@realtek.com \
    --cc=ulf.hansson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).