Linux-Wireless Archive on lore.kernel.org
 help / Atom feed
* [PATCH v4 0/4] rtlwifi: Fix issues with rtl8723ae
@ 2019-01-08 22:49 Bernd Edlinger
  2019-01-09  0:45 ` Larry Finger
  0 siblings, 1 reply; 2+ messages in thread
From: Bernd Edlinger @ 2019-01-08 22:49 UTC (permalink / raw)
  To: Ping-Ke Shih, Larry Finger, Kalle Valo, David S. Miller,
	linux-wireless, netdev, linux-kernel, Andrew Lunn

Currently the rtl8723ae driver is broken (since v4.7).

Connection to AP is lost very often, especially when
the signal level is not very good.

The main issue is the power save mode is basically
not working, and seems to trigger a firmware bug.
So I had to take out the FW LPS mode handling.

While debugging the driver I found a couple related issues,
for instance that the signal level in dm.undec_sm_pwdb
is no longer accurate (may be even much too high) when no more
packets are received, and it increases the likelihood to receive
something if the input gain is set to maximum.

The patch was tested with the rtl8723ae PCI card in my laptop
against a FRITZ!Box 7590 AP -- the WiFi connection works now
very reliable for me.

ChangeLog:

v2: Adjusts the defaults of swlps and fwlps module
parameters to match the firmware capabilities instead of removing
the whole code, so it can be easily re-activated once a firmware
update is available.

v3: Make the title of each patch fit in one line.

v4: Try to fix the line endings the message body.
    Which is an exchange server issue.
    The patch does not change at all.

Bernd Edlinger (4):
  rtl8723ae: Take the FW LPS mode handling out
  rtl8723ae: Dont use old data for input gain control
  rtl8723ae: Re-introduce the adaptive rate control
  rtlwifi: Don't clear num_rx_inperiod too early 

 drivers/net/wireless/realtek/rtlwifi/base.c        |  4 +-
 drivers/net/wireless/realtek/rtlwifi/core.c        |  2 +
 .../net/wireless/realtek/rtlwifi/rtl8723ae/dm.c    | 95 +++++++++++++++++++++-
 .../net/wireless/realtek/rtlwifi/rtl8723ae/sw.c    |  8 +-
 4 files changed, 101 insertions(+), 8 deletions(-)

-- 
1.9.1

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH v4 0/4] rtlwifi: Fix issues with rtl8723ae
  2019-01-08 22:49 [PATCH v4 0/4] rtlwifi: Fix issues with rtl8723ae Bernd Edlinger
@ 2019-01-09  0:45 ` Larry Finger
  0 siblings, 0 replies; 2+ messages in thread
From: Larry Finger @ 2019-01-09  0:45 UTC (permalink / raw)
  To: Bernd Edlinger, Ping-Ke Shih, Kalle Valo, David S. Miller,
	linux-wireless, netdev, linux-kernel, Andrew Lunn

On 1/8/19 4:49 PM, Bernd Edlinger wrote:
> Currently the rtl8723ae driver is broken (since v4.7).
> 
> Connection to AP is lost very often, especially when
> the signal level is not very good.
> 
> The main issue is the power save mode is basically
> not working, and seems to trigger a firmware bug.
> So I had to take out the FW LPS mode handling.
> 
> While debugging the driver I found a couple related issues,
> for instance that the signal level in dm.undec_sm_pwdb
> is no longer accurate (may be even much too high) when no more
> packets are received, and it increases the likelihood to receive
> something if the input gain is set to maximum.
> 
> The patch was tested with the rtl8723ae PCI card in my laptop
> against a FRITZ!Box 7590 AP -- the WiFi connection works now
> very reliable for me.
> 
> ChangeLog:
> 
> v2: Adjusts the defaults of swlps and fwlps module
> parameters to match the firmware capabilities instead of removing
> the whole code, so it can be easily re-activated once a firmware
> update is available.
> 
> v3: Make the title of each patch fit in one line.
> 
> v4: Try to fix the line endings the message body.
>      Which is an exchange server issue.
>      The patch does not change at all.
> 
> Bernd Edlinger (4):
>    rtl8723ae: Take the FW LPS mode handling out
>    rtl8723ae: Dont use old data for input gain control
>    rtl8723ae: Re-introduce the adaptive rate control
>    rtlwifi: Don't clear num_rx_inperiod too early
> 
>   drivers/net/wireless/realtek/rtlwifi/base.c        |  4 +-
>   drivers/net/wireless/realtek/rtlwifi/core.c        |  2 +
>   .../net/wireless/realtek/rtlwifi/rtl8723ae/dm.c    | 95 +++++++++++++++++++++-
>   .../net/wireless/realtek/rtlwifi/rtl8723ae/sw.c    |  8 +-
>   4 files changed, 101 insertions(+), 8 deletions(-)

This version applied OK.

Larry



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-08 22:49 [PATCH v4 0/4] rtlwifi: Fix issues with rtl8723ae Bernd Edlinger
2019-01-09  0:45 ` Larry Finger

Linux-Wireless Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-wireless/0 linux-wireless/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-wireless linux-wireless/ https://lore.kernel.org/linux-wireless \
		linux-wireless@vger.kernel.org linux-wireless@archiver.kernel.org
	public-inbox-index linux-wireless


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-wireless


AGPL code for this site: git clone https://public-inbox.org/ public-inbox