From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6ADF7C636CC for ; Sun, 5 Feb 2023 02:50:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229519AbjBECup (ORCPT ); Sat, 4 Feb 2023 21:50:45 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49162 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229379AbjBECuo (ORCPT ); Sat, 4 Feb 2023 21:50:44 -0500 Received: from mail.marcansoft.com (marcansoft.com [212.63.210.85]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C7D9A25973; Sat, 4 Feb 2023 18:50:42 -0800 (PST) Received: from [127.0.0.1] (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: marcan@marcan.st) by mail.marcansoft.com (Postfix) with ESMTPSA id C9EF441A42; Sun, 5 Feb 2023 02:50:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=marcan.st; s=default; t=1675565439; bh=2ClkKO5YNiZp4jOGVc6vmj27cmf3cHHLtZ4CbL6it0g=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=ABM15R128i7ev4jOh6iTzH0hoO74qkwwiwgoYAoo1FxUqBDj/qvEOEF0FEgSjogMi 3ff+/FqfTJ+5YSL1O8pJE7/epuo9fMPvZeT/6MLDc4c1LybEMHa03JBAvIcxyhArv1 41xI9KeaZhtkZhZLQQL6+rVhyjpiq0dJ0OcsN2GzF20C7Y+QZYiW8ZVNpnYbqiJPoe qMqHQXNldjagB+G92Mfu8tsnI1UM7b1V8YYKtr5KpeoC5+tEle5biNFcCUKWcKMVqI 5Kk8pkjbWys16CRfpbtAxdEgvRYZPhaXV1c5Pft5jUp+viEf8BSX2oaJt8St4XVECS kZqIJOXNzmmfg== Message-ID: <28ed8713-4243-7c67-b792-92d0dde82256@marcan.st> Date: Sun, 5 Feb 2023 11:50:30 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH v2 1/5] brcmfmac: Drop all the RAW device IDs Content-Language: en-US To: Arend Van Spriel , Jonas Gorski , "'Hector Martin' via BRCM80211-DEV-LIST,PDL" Cc: Arend van Spriel , Franky Lin , Hante Meuleman , Kalle Valo , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Alexander Prutskov , Chi-Hsien Lin , Wright Feng , Ian Lin , Soontak Lee , Joseph chuang , Sven Peter , Alyssa Rosenzweig , Aditya Garg , asahi@lists.linux.dev, linux-wireless@vger.kernel.org, SHA-cyfmac-dev-list@infineon.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= , Hauke Mehrtens References: <20230131112840.14017-1-marcan@marcan.st> <20230131112840.14017-2-marcan@marcan.st> <4fb4af22-d115-de62-3bda-c1ae02e097ee@marcan.st> <1861323f100.279b.9b12b7fc0a3841636cfb5e919b41b954@broadcom.com> From: Hector Martin In-Reply-To: <1861323f100.279b.9b12b7fc0a3841636cfb5e919b41b954@broadcom.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On 03/02/2023 02.19, Arend Van Spriel wrote: > On February 2, 2023 6:25:28 AM "'Hector Martin' via BRCM80211-DEV-LIST,PDL" > wrote: > >> On 31/01/2023 23.17, Jonas Gorski wrote: >>> On Tue, 31 Jan 2023 at 12:36, Hector Martin wrote: >>>> >>>> These device IDs are only supposed to be visible internally, in devices >>>> without a proper OTP. They should never be seen in devices in the wild, >>>> so drop them to avoid confusion. >>> >>> I think these can still show up in embedded platforms where the >>> OTP/SPROM is provided on-flash. >>> >>> E.g. https://forum.archive.openwrt.org/viewtopic.php?id=55367&p=4 >>> shows this bootlog on an BCM4709A0 router with two BCM43602 wifis: >>> >>> [ 3.237132] pci 0000:01:00.0: [14e4:aa52] type 00 class 0x028000 >>> [ 3.237174] pci 0000:01:00.0: reg 0x10: [mem 0x00000000-0x00007fff 64bit] >>> [ 3.237199] pci 0000:01:00.0: reg 0x18: [mem 0x00000000-0x003fffff 64bit] >>> [ 3.237302] pci 0000:01:00.0: supports D1 D2 >>> ... >>> [ 3.782384] pci 0001:03:00.0: [14e4:aa52] type 00 class 0x028000 >>> [ 3.782440] pci 0001:03:00.0: reg 0x10: [mem 0x00000000-0x00007fff 64bit] >>> [ 3.782474] pci 0001:03:00.0: reg 0x18: [mem 0x00000000-0x003fffff 64bit] >>> [ 3.782649] pci 0001:03:00.0: supports D1 D2 >>> >>> 0xaa52 == 43602 (BRCM_PCIE_43602_RAW_DEVICE_ID) >>> >>> Rafał can probably provide more info there. >>> >>> Regards >>> Jonas >> >> Arend, any comments on these platforms? > > Huh? I already replied to that couple of days ago or did I only imagine > doing that. I don't see any replies from you on the lists (or my inbox) to Jonas' email. - Hector