Re: [PATCH 1/1] staging: wilc1000: remove redundant reset of station statistics

[<Adham.Abozaeid@microchip.com>]

On 1/29/19 1:39 AM, Dan Carpenter wrote:
> On Mon, Jan 28, 2019 at 10:38:20PM +0000, Adham.Abozaeid@microchip.com wrote:
>> From: Adham Abozaeid <adham.abozaeid@microchip.com>
>>
>> Driver sends configuration wids to reset connection statistics in the
>> device, but the device already resets it when starting a new connection
>>
>> Signed-off-by: Adham Abozaeid <adham.abozaeid@microchip.com>
>> ---
>>  drivers/staging/wilc1000/host_interface.c | 20 +-------------------
>>  1 file changed, 1 insertion(+), 19 deletions(-)
>>
>> diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interface.c
>> index fbb61de20304..286685e426c1 100644
>> --- a/drivers/staging/wilc1000/host_interface.c
>> +++ b/drivers/staging/wilc1000/host_interface.c
>> @@ -342,29 +342,11 @@ static int wilc_send_connect_wid(struct wilc_vif *vif)
>>  {
>>  	int result = 0;
>>  	struct wid wid_list[8];
>                    ^^^^^^^^^^^
> We could make this array smaller as well.
Agree. Will send v2 with smaller array.
>
>> -	u32 wid_cnt = 0, dummyval = 0;
>> +	u32 wid_cnt = 0;
> regards,
> dan carpenter

Thanks,

Adham