From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1EA89C43387 for ; Fri, 4 Jan 2019 09:26:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E9ED721872 for ; Fri, 4 Jan 2019 09:26:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726847AbfADJ0g convert rfc822-to-8bit (ORCPT ); Fri, 4 Jan 2019 04:26:36 -0500 Received: from coyote.holtmann.net ([212.227.132.17]:52664 "EHLO mail.holtmann.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726117AbfADJ0f (ORCPT ); Fri, 4 Jan 2019 04:26:35 -0500 Received: from marcel-macpro.fritz.box (p5B3D2389.dip0.t-ipconnect.de [91.61.35.137]) by mail.holtmann.org (Postfix) with ESMTPSA id EFE85CF233; Fri, 4 Jan 2019 10:34:16 +0100 (CET) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 12.2 \(3445.102.3\)) Subject: Re: [PATCH 5/6] cfg80211: add support for SAE authentication offload From: Marcel Holtmann In-Reply-To: <1546582221-143220-5-git-send-email-chi-hsien.lin@cypress.com> Date: Fri, 4 Jan 2019 10:26:33 +0100 Cc: "linux-wireless@vger.kernel.org" , "brcm80211-dev-list@broadcom.com" , brcm80211-dev-list , Arend van Spriel , Franky Lin , Hante Meuleman , Wright Feng , Kalle Valo , Stanley Hsu Content-Transfer-Encoding: 8BIT Message-Id: <2FC4C72C-9E57-4195-A682-F7BAE7F3981E@holtmann.org> References: <1546582221-143220-1-git-send-email-chi-hsien.lin@cypress.com> <1546582221-143220-5-git-send-email-chi-hsien.lin@cypress.com> To: Chi-Hsien Lin X-Mailer: Apple Mail (2.3445.102.3) Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Hi, > Let drivers advertise support for station-mode SAE authentication > offload with a new NL80211_EXT_FEATURE_SAE_OFFLOAD flag. > > Signed-off-by: Chung-Hsien Hsu > Signed-off-by: Chi-Hsien Lin > --- > include/linux/ieee80211.h | 1 + > include/net/cfg80211.h | 5 +++++ > include/uapi/linux/nl80211.h | 16 ++++++++++++++++ > net/wireless/nl80211.c | 14 ++++++++++++++ > 4 files changed, 36 insertions(+) > > diff --git a/include/linux/ieee80211.h b/include/linux/ieee80211.h > index 3b04e72315e1..37d3e655e547 100644 > --- a/include/linux/ieee80211.h > +++ b/include/linux/ieee80211.h > @@ -2596,6 +2596,7 @@ enum ieee80211_key_len { > #define FILS_ERP_MAX_RRK_LEN 64 > > #define PMK_MAX_LEN 64 > +#define SAE_PASSWORD_MAX_LEN 128 > > /* Public action codes (IEEE Std 802.11-2016, 9.6.8.1, Table 9-307) */ > enum ieee80211_pub_actioncode { > diff --git a/include/net/cfg80211.h b/include/net/cfg80211.h > index e0c41eb1c860..5809dac97b33 100644 > --- a/include/net/cfg80211.h > +++ b/include/net/cfg80211.h > @@ -740,6 +740,9 @@ struct survey_info { > * CFG80211_MAX_WEP_KEYS WEP keys > * @wep_tx_key: key index (0..3) of the default TX static WEP key > * @psk: PSK (for devices supporting 4-way-handshake offload) > + * @sae_pwd: password for SAE authentication (for devices supporting SAE > + * offload) > + * @sae_pwd_len: length of SAE password (for devices supporting SAE offload) > */ > struct cfg80211_crypto_settings { > u32 wpa_versions; > @@ -755,6 +758,8 @@ struct cfg80211_crypto_settings { > struct key_params *wep_keys; > int wep_tx_key; > const u8 *psk; > + const u8 *sae_pwd; > + u16 sae_pwd_len; > }; > > /** > diff --git a/include/uapi/linux/nl80211.h b/include/uapi/linux/nl80211.h > index 12762afb3a07..4840aaed39ba 100644 > --- a/include/uapi/linux/nl80211.h > +++ b/include/uapi/linux/nl80211.h > @@ -235,6 +235,15 @@ > */ > > /** > + * DOC: SAE authentication offload > + * > + * By setting @NL80211_EXT_FEATURE_SAE_OFFLOAD flag drivers can indicate they > + * support offloading SAE authentication for WPA3-Personal networks. In > + * %NL80211_CMD_CONNECT the password for SAE should be specified using > + * %NL80211_ATTR_SAE_PASSWORD. > + */ > + > +/** > * enum nl80211_commands - supported nl80211 commands > * > * @NL80211_CMD_UNSPEC: unspecified command to catch errors > @@ -2288,6 +2297,9 @@ enum nl80211_commands { > * > * @NL80211_ATTR_FTM_RESPONDER_STATS: Nested attribute with FTM responder > * statistics, see &enum nl80211_ftm_responder_stats. > + * @NL80211_ATTR_SAE_PASSWORD: attribute for passing SAE password material. It > + * is used with %NL80211_CMD_CONNECT to provide password for offloading > + * SAE authentication for WPA3-Personal networks. > * > * @NL80211_ATTR_TIMEOUT: Timeout for the given operation in milliseconds (u32), > * if the attribute is not given no timeout is requested. Note that 0 is an > @@ -2743,6 +2755,7 @@ enum nl80211_attrs { > NL80211_ATTR_FTM_RESPONDER, > > NL80211_ATTR_FTM_RESPONDER_STATS, > + NL80211_ATTR_SAE_PASSWORD, > > NL80211_ATTR_TIMEOUT, so you are breaking user-space API on purpose here even when there was a clear comment where to add new attributes: /* add attributes here, update the policy in nl80211.c */ More importantly, does this actually need a new attribute and you can not utilize what has already been added for mesh? If this attribute is solely for offload cases, then it might be better named accordingly. Also I am curious on how mixed WPA1/WPA2/WPA3 network credentials are now provided to a CMD_CONNECT. So the CMD_CONNECT description might require an update as well. Regards Marcel