From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 945A0C433F5 for ; Wed, 29 Sep 2021 16:46:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7D1EE61262 for ; Wed, 29 Sep 2021 16:46:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346238AbhI2Qs3 (ORCPT ); Wed, 29 Sep 2021 12:48:29 -0400 Received: from so254-9.mailgun.net ([198.61.254.9]:59204 "EHLO so254-9.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345986AbhI2QsQ (ORCPT ); Wed, 29 Sep 2021 12:48:16 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1632933995; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=hENbf6DLHZQ9EDwLZm4d/dfWRbeRGqIPP0WtfVX8Mp0=; b=Bd9L6PjkP38SKN1MeKHbd/i2nKi7hREmGfn5mLEKRMEaa76UJx8flYVjLdVBaukqUlvMMc1M Ddf6Uw/hksW2DlEflLp63Nzj1f4ryXfunfC9QI4J+utYiBeE9YxLgilvj0IYb76C46WOVPQM Mj0XHc9vbX0/VrK0e+SC8kqeFjc= X-Mailgun-Sending-Ip: 198.61.254.9 X-Mailgun-Sid: WyI3YTAwOSIsICJsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n04.prod.us-west-2.postgun.com with SMTP id 61549869519bd8dcf0430505 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Wed, 29 Sep 2021 16:46:33 GMT Sender: vnaralas=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 5CFD3C4360D; Wed, 29 Sep 2021 16:46:33 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: vnaralas) by smtp.codeaurora.org (Postfix) with ESMTPSA id AF271C4338F; Wed, 29 Sep 2021 16:46:32 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Wed, 29 Sep 2021 22:16:32 +0530 From: Venkateswara Naralasetty To: Wen Gong Cc: johannes@sipsolutions.net, ath11k@lists.infradead.org, linux-wireless@vger.kernel.org, wgong=codeaurora.org@codeaurora.org Subject: Re: [PATCH v5] cfg80211: save power spectral density(psd) of regulatory rule In-Reply-To: References: <20210928085211.26186-1-wgong@codeaurora.org> Message-ID: <2afb1bf6f06cb53f43fe0d354afa4e7c@codeaurora.org> X-Sender: vnaralas@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On 2021-09-29 09:07, Wen Gong wrote: > On 2021-09-28 21:12, vnaralas@codeaurora.org wrote: >> On 2021-09-28 14:22, Wen Gong wrote: >>> 6 GHz regulatory domains introduces power spectral density(psd). >>> The power spectral density(psd) of regulatory rule should be take >>> effect to the channels. Save the values to the channel which has >>> psd value and add nl80211 attributes for it. >>> >>> Signed-off-by: Wen Gong >>> --- > ... >>> >>> @@ -2540,6 +2554,9 @@ static void handle_channel_custom(struct wiphy >>> *wiphy, >>> chan->dfs_cac_ms = IEEE80211_DFS_MIN_CAC_TIME_MS; >>> } >>> >>> + if (chan->flags & IEEE80211_CHAN_PSD) >>> + chan->psd = reg_rule->psd; >>> + >>> chan->max_power = chan->max_reg_power; >> >> What about the case AP + STA concurrency? are we going to overwrite >> the PSD power and channel flags? >> > > Hi Venkateswara, > > This patch is not relation with AP + STA concurrency. > For example, it also has other power intersection in > handle_channel_adjacent_rules(). > > chan->max_reg_power = > min_t(int, MBM_TO_DBM(power_rule1->max_eirp), > MBM_TO_DBM(power_rule2->max_eirp)); > > For AP + STA concurrency, it should to maintain 2 group of reg rules, > one is for AP, another is for STA. Can we maintain two power rules in the same channel one for AP and one for STA. In this way, we can update the power rules in the same channel for both AP and STA from the reg rules. Otherwise, we need to maintain multiple channel lists in sband for all supported power mode combinations to apply the respective power rules and build channel flags from the multiple reg rules. right? > This patch is to handle PSD info in the same reg rules. > It is to process only one reg rule in the reg rules. > AP + STA concurrency is a higher level things than this patch. >>> }