From: Pkshih <pkshih@realtek.com>
To: "cgel.zte@gmail.com" <cgel.zte@gmail.com>,
"kvalo@codeaurora.org" <kvalo@codeaurora.org>
Cc: "davem@davemloft.net" <davem@davemloft.net>,
"kuba@kernel.org" <kuba@kernel.org>,
"deng.changcheng@zte.com.cn" <deng.changcheng@zte.com.cn>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Zeal Robot <zealci@zte.com.cn>
Subject: RE: [PATCH] rtw89: remove unneeded variable
Date: Thu, 11 Nov 2021 05:19:19 +0000 [thread overview]
Message-ID: <2b0fcb779baf49caa58a4e7134af45b1@realtek.com> (raw)
In-Reply-To: <20211110121135.151187-1-deng.changcheng@zte.com.cn>
> -----Original Message-----
> From: cgel.zte@gmail.com <cgel.zte@gmail.com>
> Sent: Wednesday, November 10, 2021 8:12 PM
> To: kvalo@codeaurora.org
> Cc: davem@davemloft.net; kuba@kernel.org; deng.changcheng@zte.com.cn; Pkshih <pkshih@realtek.com>;
> linux-wireless@vger.kernel.org; netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Zeal Robot
> <zealci@zte.com.cn>
> Subject: [PATCH] rtw89: remove unneeded variable
>
> From: Changcheng Deng <deng.changcheng@zte.com.cn>
>
> Fix the following coccicheck review:
> ./drivers/net/wireless/realtek/rtw89/mac.c: 1096: 5-8: Unneeded variable
>
> Remove unneeded variable used to store return value.
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Changcheng Deng <deng.changcheng@zte.com.cn>
Acked-by: Ping-Ke Shih <pkshih@realtek.com>
> ---
> drivers/net/wireless/realtek/rtw89/mac.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/net/wireless/realtek/rtw89/mac.c b/drivers/net/wireless/realtek/rtw89/mac.c
> index 0171a5a7b1de..b93ac242b305 100644
> --- a/drivers/net/wireless/realtek/rtw89/mac.c
> +++ b/drivers/net/wireless/realtek/rtw89/mac.c
> @@ -1093,7 +1093,6 @@ static int cmac_func_en(struct rtw89_dev *rtwdev, u8 mac_idx, bool en)
> static int dmac_func_en(struct rtw89_dev *rtwdev)
> {
> u32 val32;
> - u32 ret = 0;
>
> val32 = (B_AX_MAC_FUNC_EN | B_AX_DMAC_FUNC_EN | B_AX_MAC_SEC_EN |
> B_AX_DISPATCHER_EN | B_AX_DLE_CPUIO_EN | B_AX_PKT_IN_EN |
> @@ -1107,7 +1106,7 @@ static int dmac_func_en(struct rtw89_dev *rtwdev)
> B_AX_WD_RLS_CLK_EN);
> rtw89_write32(rtwdev, R_AX_DMAC_CLK_EN, val32);
>
> - return ret;
> + return 0;
> }
>
> static int chip_func_en(struct rtw89_dev *rtwdev)
> --
> 2.25.1
next prev parent reply other threads:[~2021-11-11 5:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-10 12:11 [PATCH] rtw89: remove unneeded variable cgel.zte
2021-11-11 5:19 ` Pkshih [this message]
2021-11-26 16:11 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2b0fcb779baf49caa58a4e7134af45b1@realtek.com \
--to=pkshih@realtek.com \
--cc=cgel.zte@gmail.com \
--cc=davem@davemloft.net \
--cc=deng.changcheng@zte.com.cn \
--cc=kuba@kernel.org \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=zealci@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).