From: Johannes Berg <johannes@sipsolutions.net>
To: Ben Greear <greearb@candelatech.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: question on HE debugfs output
Date: Fri, 20 Aug 2021 11:17:20 +0200 [thread overview]
Message-ID: <2c55dce18c94d778207b3fc452a09e14ee80c032.camel@sipsolutions.net> (raw)
In-Reply-To: <578da3a0-f029-4e60-d4e6-34d42def62e8@candelatech.com>
Hi Ben,
> While poking around in things, I noticed that the
> he_capa debugfs is not showing the least-common-denominator, but rather
> more specifically the peer's capabilities.
>
> This could be bugs in how I'm using this, but thought I'd ask to
> see if this was on purpose or not.
It was on purpose. Also, for HE it's different from HT/VHT in that we
don't do this in the stack any more.
I'm not really sure _why_ now (or if we should change it), but I seem to
remember it was just a lot more complex to do in general, but drivers
didn't really care so much since they tend to have a lot of hard-coded
assumptions, e.g. they might not care about seeing 2, 3 or more streams
supported if their code assumes the device always only supports 2 in the
first place, so all they need is a >= 2 check in this case, for example.
If you wanted to change that, I wouldn't mind, but it might be complex.
johannes
next prev parent reply other threads:[~2021-08-20 9:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-10 3:39 question on HE debugfs output Ben Greear
2021-08-20 9:17 ` Johannes Berg [this message]
2021-08-20 15:08 ` Ben Greear
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2c55dce18c94d778207b3fc452a09e14ee80c032.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=greearb@candelatech.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).