From: Kalle Valo <kvalo@qca.qualcomm.com>
To: <ryanhsu@qti.qualcomm.com>
Cc: <ath10k@lists.infradead.org>, <linux-wireless@vger.kernel.org>,
<ryanhsu@qti.qualcomm.com>
Subject: Re: ath10k: fix napi_poll budget overflow
Date: Thu, 24 Aug 2017 11:07:35 +0200 [thread overview]
Message-ID: <2cd00da66a6847c1829ed9edf7ad7009@euamsexm01a.eu.qualcomm.com> (raw)
In-Reply-To: <1503438242-5657-1-git-send-email-ryanhsu@qti.qualcomm.com>
ryanhsu@qti.qualcomm.com wrote:
> From: Ryan Hsu <ryanhsu@qti.qualcomm.com>
>
> In napi_poll, the budget number is used to control the amount of packets
> we should handle per poll to balance the resource in the system.
>
> In the list of the amsdu packets reception, we check if there is budget
> count left and handle the complete list of the packets, that it will have
> chances the very last list will over the budget leftover.
>
> So adding one more parameter - budget_left, this would help while
> traversing the list to avoid handling more than the budget given.
>
> Reported-by: Andrey Ryabinin <aryabinin@virtuozzo.com>
> Fix-suggested-by: Igor Mitsyanko <igor.mitsyanko.os@quantenna.com>
>
> Signed-off-by: Ryan Hsu <ryanhsu@qti.qualcomm.com>
Was there a bug report about this? I can add a link to that and maybe also
include the warning.
--
https://patchwork.kernel.org/patch/9916207/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2017-08-24 9:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-22 21:44 [PATCH] ath10k: fix napi_poll budget overflow ryanhsu
2017-08-24 9:07 ` Kalle Valo [this message]
2017-08-24 14:27 ` Ryan Hsu
2017-08-31 12:13 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2cd00da66a6847c1829ed9edf7ad7009@euamsexm01a.eu.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=ath10k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=ryanhsu@qti.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).