From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B04DC2D0BF for ; Fri, 13 Dec 2019 09:32:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4639B214D8 for ; Fri, 13 Dec 2019 09:32:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725980AbfLMJcY (ORCPT ); Fri, 13 Dec 2019 04:32:24 -0500 Received: from s3.sipsolutions.net ([144.76.43.62]:44836 "EHLO sipsolutions.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725770AbfLMJcY (ORCPT ); Fri, 13 Dec 2019 04:32:24 -0500 Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.92.3) (envelope-from ) id 1ifhJ8-009bDv-0v; Fri, 13 Dec 2019 10:32:22 +0100 Message-ID: <2e5f60bc56e930e599cd5c5ed1925e41dcc90f14.camel@sipsolutions.net> Subject: Re: [PATCH] mac80211: he_support was not set when bringing up a HE mesh interface From: Johannes Berg To: John Crispin Cc: linux-wireless@vger.kernel.org, Pradeep Kumar Chitrapu , Sven Eckelmann Date: Fri, 13 Dec 2019 10:32:15 +0100 In-Reply-To: <20191213092636.17736-1-john@phrozen.org> References: <20191213092636.17736-1-john@phrozen.org> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.34.2 (3.34.2-1.fc31) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org > From: Pradeep Kumar Chitrapu > > The he_support flag inside bss_conf was not set when a HE mesh interface > gets created. This causes the drivers to not set the HW up correctly. This is all wrong ... it doesn't even explain the change. Also, the subject? Really? I know you can all do better. > Fixes: 60ad72da55ac ("mac80211: implement HE support for mesh") > > Cc: Sven Eckelmann The fixes should also be part of the footer. johannes