From: Johannes Berg <johannes@sipsolutions.net> To: Linus Torvalds <torvalds@linux-foundation.org> Cc: "David S. Miller" <davem@davemloft.net>, Kalle Valo <kvalo@codeaurora.org>, linux-wireless@vger.kernel.org, Netdev <netdev@vger.kernel.org>, Linux List Kernel Mailing <linux-kernel@vger.kernel.org> Subject: Re: WARNING at net/mac80211/sta_info.c:1057 (__sta_info_destroy_part2()) Date: Wed, 11 Sep 2019 14:04:30 +0200 Message-ID: <30679d3f86731475943856196478677e70a349a9.camel@sipsolutions.net> (raw) In-Reply-To: <CAHk-=wj_jneK+UYzHhjwsH0XxP0knM+2o2OeFVEz-FjuQ77-ow@mail.gmail.com> (sfid-20190911_135849_146176_004B38CD) On Wed, 2019-09-11 at 12:58 +0100, Linus Torvalds wrote: > > And I didn't think about it or double-check, because the errors that > then followed later _looked_ like that TX power failing that I thought > hadn't happened. Yeah, it could be something already got stuck there, hard to say. > > Since we see that something actually did an rfkill operation. Did you > > push a button there? > > No, I tried to turn off and turn on Wifi manually (no button, just the > settings panel). That does usually also cause rfkill, so that explains how we got down this particular code path. > I didn't notice the WARN_ON(), I just noticed that there was no > networking, and "turn it off and on again" is obviously the first > thing to try ;) :-) > Sep 11 10:27:13 xps13 kernel: WARNING: CPU: 4 PID: 1246 at > net/mac80211/sta_info.c:1057 __sta_info_destroy_part2+0x147/0x150 > [mac80211] > > but if you want full logs I can send them in private to you. No, it's fine, though maybe Kalle does - he was stepping out for a while but said he'd look later. This is the interesting time - 10:27:13 we get one of the first failures. Really the first one was this: > Sep 11 10:27:07 xps13 kernel: ath10k_pci 0000:02:00.0: wmi command 16387 timeout, restarting hardware > I do suspect it's atheros and suspend/resume or something. The > wireless clearly worked for a while after the resume, but then at some > point it stopped. I'm not really sure it's related to suspend/resume at all, the firmware seems to just have gotten stuck, and the device and firmware most likely got reset over the suspend/resume anyway. > > The only explanation I therefore have is that something is just taking > > *forever* in that code path, hence my question about timing information > > on the logs. > > Yeah, maybe it would time out everything eventually. But not for a > long time. It hadn't cleared up by > > Sep 11 10:36:21 xps13 gnome-session-f[6837]: gnome-session-failed: > Fatal IO error 0 (Success) on X server :0. Ok, that's way longer than I would have guessed even! That's over 9 minutes, that'd be close to 200 commands having to be issued and timing out ... I don't know. What I wrote before is basically all I can say, I think the driver gets stuck somewhere waiting for the device "forever", and the stack just doesn't get to release the lock, causing all the follow- up problems. johannes
next prev parent reply index Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-09-11 10:05 Linus Torvalds 2019-09-11 10:26 ` Johannes Berg 2019-09-11 11:58 ` Linus Torvalds 2019-09-11 12:04 ` Johannes Berg [this message] 2019-09-11 13:03 ` Ben Greear 2019-09-11 13:21 ` Linus Torvalds 2019-09-11 13:31 ` Ben Greear 2019-09-11 13:32 ` Kalle Valo 2019-09-11 18:19 ` Kalle Valo 2019-09-11 18:23 ` Johannes Berg 2019-09-11 18:48 ` Kalle Valo 2019-09-11 18:10 ` Kalle Valo 2019-10-20 15:12 ` Tomislav Požega 2019-10-21 14:01 ` Ben Greear
Reply instructions: You may reply publically to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=30679d3f86731475943856196478677e70a349a9.camel@sipsolutions.net \ --to=johannes@sipsolutions.net \ --cc=davem@davemloft.net \ --cc=kvalo@codeaurora.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-wireless@vger.kernel.org \ --cc=netdev@vger.kernel.org \ --cc=torvalds@linux-foundation.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Linux-Wireless Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/linux-wireless/0 linux-wireless/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 linux-wireless linux-wireless/ https://lore.kernel.org/linux-wireless \ linux-wireless@vger.kernel.org public-inbox-index linux-wireless Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.kernel.vger.linux-wireless AGPL code for this site: git clone https://public-inbox.org/public-inbox.git