From: Sven Eckelmann <sven@narfation.org>
To: Jouni Malinen <j@w1.fi>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH v6] mac80211_hwsim: Register support for HE meshpoint
Date: Tue, 13 Aug 2019 13:20:47 +0200 [thread overview]
Message-ID: <3127506.552nsDcnha@bentobox> (raw)
In-Reply-To: <20190813105549.GA26160@w1.fi>
[-- Attachment #1: Type: text/plain, Size: 2277 bytes --]
Hi,
On Tuesday, 13 August 2019 12:55:49 CEST Jouni Malinen wrote:
[...]
> > [1] https://patchwork.ozlabs.org/patch/1131273/
> > [2] https://patchwork.ozlabs.org/patch/1116968/
> > [3] https://lore.kernel.org/r/2152977.f3ncjnVLFo@bentobox
>
> And with the exact same snapshot of hostap.git.
>
> Without [1] applied, this mac80211_hwsim patch to enable HE meshpoint
> results in the following test cases failing:
>
> mesh_secure_ocv_mix_legacy
> wpas_mesh_open_ht40
> wpas_mesh_max_peering
> mesh_secure_ocv_mix_ht
>
> [1] fixes wpas_mesh_max_peering
>
> This leaves following three test cases failing ("Test exception:
> Couldn't join mesh"):
>
> mesh_secure_ocv_mix_legacy
> wpas_mesh_open_ht40
> mesh_secure_ocv_mix_ht
>
> Am I missing a patch somewhere that would be needed to make those pass?
No, these also failed for me without the mac80211_hwsim patch [3] in a full
test run. And thus not analyzed further by me.
Interestingly, they don't fail (without the hwsim patch) when running them
without the full test suite.
[...]
> So is that missing of vht_enabled=1 from some configurations the problem
> here and if so, would you be able to point me to a hostap.git patch that
> addresses this?
No, there is no hostap.git patch here. There was one in the past in
patchwork [4] but there were concerns by John. So if you reapply the patch
then you will see that it doesn't fail anymore.
diff --git a/src/drivers/driver_nl80211.c b/src/drivers/driver_nl80211.c
index d71511cb5..b54900bc4 100644
--- a/src/drivers/driver_nl80211.c
+++ b/src/drivers/driver_nl80211.c
@@ -4360,7 +4360,7 @@ static int nl80211_put_freq_params(struct nl_msg *msg,
is_24ghz = hw_mode == HOSTAPD_MODE_IEEE80211G ||
hw_mode == HOSTAPD_MODE_IEEE80211B;
- if (freq->vht_enabled || (freq->he_enabled && !is_24ghz)) {
+ if (freq->vht_enabled) {
enum nl80211_chan_width cw;
wpa_printf(MSG_DEBUG, " * bandwidth=%d", freq->bandwidth);
So as a compromise, I can can propose a patch which tries to replicate this
2.4GHz specific behavior from nl80211_put_freq_params also in
ibss_mesh_setup_freq
Btw. thanks for pointing me towards specific test cases.
Kind regards,
Sven
[4] https://patchwork.ozlabs.org/patch/1125305/
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2019-08-13 11:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-13 6:36 [PATCH v6] mac80211_hwsim: Register support for HE meshpoint Sven Eckelmann
2019-08-13 10:55 ` Jouni Malinen
2019-08-13 11:20 ` Sven Eckelmann [this message]
2019-08-30 10:38 ` Johannes Berg
2019-08-30 13:37 ` Jouni Malinen
2019-08-30 13:45 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3127506.552nsDcnha@bentobox \
--to=sven@narfation.org \
--cc=j@w1.fi \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).