From: Denis Kenzior <denkenz@gmail.com>
To: Alexander Wetzel <alexander@wetzel-home.de>,
Arend Van Spriel <arend.vanspriel@broadcom.com>,
Kalle Valo <kvalo@codeaurora.org>,
Maya Erez <merez@codeaurora.org>
Cc: Ahmad Masri <amasri@codeaurora.org>,
linux-wireless@vger.kernel.org, wil6210@qti.qualcomm.com
Subject: Re: [PATCH 04/11] wil6210: fix PTK re-key race
Date: Tue, 17 Sep 2019 10:32:08 -0500 [thread overview]
Message-ID: <31dd258c-7ff5-005b-9dee-b4753e3e5250@gmail.com> (raw)
In-Reply-To: <46f1141c-929c-9686-017d-fe4305d9c922@wetzel-home.de>
Hi Alexander,
> And that the intend of it is to replace the "old" path.
Correct.
>
> So the best way forward here would be to
>
> 1) implement the patch here to work around the problem without
> control_port or the theoretical QDISC bypass
> 2) start implementing control port for the future.
>
> correct?
>
I don't know what the right answer is, but it seems strange to me that
we developed a 'better way', upstreamed it several years ago, but are
still trying to kludge around adding special flags to what is now
considered a legacy approach. Also disconcerting that not a single
fullmac driver has added support for this 'better way' yet.
>
>> CONTROL_PORT was added specifically to take care of the re-keying
>> races and can be extended with additional attributes over time, as
>> needed (perhaps for extended key id, etc). Also note that in our
>> testing CONTROL_PORT is _way_ faster than PAE socket...
>>
>
> Extended Key ID is pretty robust when rekeying and the driver/card only
> has to take care to not mix KeyIDs within one A-MPDU. It's no problem
> encrypting eapol#4 with the new key. You can even encrypt it at the
> initial connect and it will work. Basically all races the "classical"
> rekey has to work around go away.
>
> For "normal" rekeys it's working pretty well with ath9k and iwlwifi even
> without control_port and just learned some weeks ago that QDISC could
> still cause issues...
Okay, if control port doesn't need to handle extended keys then even better.
By the way, thanks for your earlier explanation (upthread).
Regards,
-Denis
next prev parent reply other threads:[~2019-09-17 15:32 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-08 8:32 [PATCH 00/11] wil6210 patches Maya Erez
2019-09-08 8:32 ` [PATCH 01/11] wil6210: add wil_netif_rx() helper function Maya Erez
2019-09-12 15:08 ` Kalle Valo
2019-09-08 8:32 ` [PATCH 02/11] wil6210: add support for pci linkdown recovery Maya Erez
2019-09-12 15:22 ` Kalle Valo
2019-09-08 8:32 ` [PATCH 03/11] wil6210: add debugfs to show PMC ring content Maya Erez
2019-09-08 8:32 ` [PATCH 04/11] wil6210: fix PTK re-key race Maya Erez
2019-09-10 13:23 ` Kalle Valo
2019-09-11 7:50 ` Arend Van Spriel
2019-09-11 18:32 ` Alexander Wetzel
2019-09-12 17:39 ` Denis Kenzior
2019-09-12 21:04 ` Alexander Wetzel
2019-09-13 8:04 ` Arend Van Spriel
2019-09-13 14:33 ` Denis Kenzior
2019-09-13 20:48 ` Alexander Wetzel
2019-09-17 15:32 ` Denis Kenzior [this message]
2019-09-13 18:43 ` Alexander Wetzel
2019-09-08 8:32 ` [PATCH 05/11] wil6210: make sure DR bit is read before rest of the status message Maya Erez
2019-09-08 8:32 ` [PATCH 06/11] wil6210: verify cid value is valid Maya Erez
2019-09-08 8:32 ` [PATCH 07/11] wil6210: properly initialize discovery_expired_work Maya Erez
2019-09-08 8:32 ` [PATCH 08/11] wil6210: report boottime_ns in scan results Maya Erez
2019-09-08 8:32 ` [PATCH 09/11] wil6210: use writel_relaxed in wil_debugfs_iomem_x32_set Maya Erez
2019-09-08 8:32 ` [PATCH 10/11] wil6210: fix RX short frame check Maya Erez
2019-09-08 8:32 ` [PATCH 11/11] wil6210: ignore reset errors for FW during probe Maya Erez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=31dd258c-7ff5-005b-9dee-b4753e3e5250@gmail.com \
--to=denkenz@gmail.com \
--cc=alexander@wetzel-home.de \
--cc=amasri@codeaurora.org \
--cc=arend.vanspriel@broadcom.com \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=merez@codeaurora.org \
--cc=wil6210@qti.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).