From: Christian Lamparter <chunkeey@gmail.com>
To: "Tomislav Požega" <pozega.tomislav@gmail.com>
Cc: linux-wireless@vger.kernel.org, openwrt-devel@lists.openwrt.org,
kalle@codeaurora.org
Subject: Re: [PATCH] ath10k: reset chip after supported check
Date: Fri, 22 Mar 2019 20:25:37 +0100 [thread overview]
Message-ID: <3337086.qEUs9xMCTV@debian64> (raw)
In-Reply-To: <1553281120-22139-1-git-send-email-pozega.tomislav@gmail.com>
On Friday, March 22, 2019 7:58:40 PM CET Tomislav Požega wrote:
> When chip reset is done before the chip is checked if supported
> there will be crash. Previous behaviour caused bootloops on
> Archer C7 v1 units, this patch allows clean device boot without
> excluding ath10k driver.
>
You need
Fixes: 1a7fecb766c8 ("ath10k: reset chip before reading chip_id in probe")
too
> Signed-off-by: Tomislav Požega <pozega.tomislav@gmail.com>
> ---
> drivers/net/wireless/ath/ath10k/pci.c | 12 ++++++------
> 1 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/net/wireless/ath/ath10k/pci.c b/drivers/net/wireless/ath/ath10k/pci.c
> index e24403c..ec681da 100644
> --- a/drivers/net/wireless/ath/ath10k/pci.c
> +++ b/drivers/net/wireless/ath/ath10k/pci.c
> @@ -3619,12 +3619,6 @@ static int ath10k_pci_probe(struct pci_dev *pdev,
> goto err_deinit_irq;
> }
>
> - ret = ath10k_pci_chip_reset(ar);
> - if (ret) {
> - ath10k_err(ar, "failed to reset chip: %d\n", ret);
> - goto err_free_irq;
> - }
> -
> bus_params.dev_type = ATH10K_DEV_TYPE_LL;
> bus_params.link_can_suspend = true;
> bus_params.chip_id = ath10k_pci_soc_read32(ar, SOC_CHIP_ID_ADDRESS);
> @@ -3639,6 +3633,12 @@ static int ath10k_pci_probe(struct pci_dev *pdev,
> goto err_free_irq;
> }
>
> + ret = ath10k_pci_chip_reset(ar);
> + if (ret) {
> + ath10k_err(ar, "failed to reset chip: %d\n", ret);
> + goto err_free_irq;
> + }
> +
> ret = ath10k_core_register(ar, &bus_params);
> if (ret) {
> ath10k_err(ar, "failed to register driver core: %d\n", ret);
>
next prev parent reply other threads:[~2019-03-22 19:25 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-22 18:58 [PATCH] ath10k: reset chip after supported check Tomislav Požega
2019-03-22 19:25 ` Christian Lamparter [this message]
2019-03-23 7:16 ` Arend Van Spriel
2019-03-23 7:20 ` Arend Van Spriel
2019-03-25 12:14 ` Michał Kazior
2019-03-25 15:55 ` Ben Greear
2019-03-25 20:08 ` Michał Kazior
2019-03-25 20:22 ` Ben Greear
2019-03-25 21:34 ` Michał Kazior
2019-03-25 20:29 ` Ben Greear
2019-04-17 3:52 ` Tom Psyborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3337086.qEUs9xMCTV@debian64 \
--to=chunkeey@gmail.com \
--cc=kalle@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=openwrt-devel@lists.openwrt.org \
--cc=pozega.tomislav@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).