linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: linux-wireless@vger.kernel.org, sara.sharon@intel.com
Subject: Re: [bug report] iwlwifi: mvm: kill INACTIVE queue state
Date: Wed, 17 Oct 2018 10:00:29 +0200	[thread overview]
Message-ID: <361341a653e523dfe73a0dbcc9472b2246c18d63.camel@sipsolutions.net> (raw)
In-Reply-To: <20181017075534.anxr76wuf2rg4xxe@kili.mountain> (sfid-20181017_095553_400686_E94AC3D4)

Hi Dan,

>   1239                  ret = iwl_mvm_remove_inactive_tids(mvm, mvmsta, i,
>   1240                                                     inactive_tid_bitmap,
>   1241                                                     &unshare_queues,
>   1242                                                     &changetid_queues);
>   1243                  if (ret >= 0 && free_queue < 0)
>                             ^^^^^^^^
> 
> The iwl_mvm_remove_inactive_tids() returns a bool so it doesn't make
> sense to test for >= 0.  Probably we should test for ret == true?

Huh, thanks for the report, we'll check.

johannes


      reply	other threads:[~2018-10-17  8:00 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-17  7:55 [bug report] iwlwifi: mvm: kill INACTIVE queue state Dan Carpenter
2018-10-17  8:00 ` Johannes Berg [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=361341a653e523dfe73a0dbcc9472b2246c18d63.camel@sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=dan.carpenter@oracle.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=sara.sharon@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).