From: Aditya <yashsri421@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>, linux-wireless@vger.kernel.org
Cc: pkshih@realtek.com, kvalo@codeaurora.org, davem@davemloft.net,
kuba@kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-kernel-mentees@lists.linuxfoundation.org,
lukas.bulwahn@gmail.com
Subject: Re: [PATCH] drivers: net: wireless: rtlwifi: fix bool comparison in expressions
Date: Wed, 13 Jan 2021 22:41:06 +0530 [thread overview]
Message-ID: <37f9fb2c-56bb-b593-ae55-db8fce8304f9@gmail.com> (raw)
In-Reply-To: <3c121981-1468-fc9d-7813-483246066cc4@lwfinger.net>
On 9/1/21 1:11 am, Larry Finger wrote:
> On 1/8/21 9:32 AM, Aditya Srivastava wrote:
>> There are certain conditional expressions in rtlwifi, where a boolean
>> variable is compared with true/false, in forms such as (foo == true) or
>> (false != bar), which does not comply with checkpatch.pl (CHECK:
>> BOOL_COMPARISON), according to which boolean variables should be
>> themselves used in the condition, rather than comparing with true/false
>>
>> E.g., in drivers/net/wireless/realtek/rtlwifi/ps.c,
>> "if (find_p2p_ie == true)" can be replaced with "if (find_p2p_ie)"
>>
>> Replace all such expressions with the bool variables appropriately
>>
>> Signed-off-by: Aditya Srivastava<yashsri421@gmail.com>
>> ---
>> - The changes made are compile tested
>> - Applies perfecly on next-20210108
>>
>> drivers/net/wireless/realtek/rtlwifi/ps.c | 4 ++--
>> drivers/net/wireless/realtek/rtlwifi/rtl8188ee/dm.c | 8
>> ++++----
>> drivers/net/wireless/realtek/rtlwifi/rtl8188ee/hw.c | 4 ++--
>> drivers/net/wireless/realtek/rtlwifi/rtl8192c/dm_common.c | 4 ++--
>> drivers/net/wireless/realtek/rtlwifi/rtl8192se/hw.c | 4 ++--
>> drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c | 8
>> ++++----
>> 6 files changed, 16 insertions(+), 16 deletions(-)
>
> As has been stated several times, this form of the subject is
> incorrect. It should be: "rtlwifi: <driver_name>: <subject>
>
> I would prefer that there be separate patches for each driver, not
> that the changes be lumped into a single patch as was done here. Such
> organization makes it a lot easier to find the patches for a given
> driver in case something goes wrong.Note: The driver for ps is
> rtl_pci, and that for rtl8192c is rtl8192c-common. The other driver
> names match their directory.
>
> Larry
>
Hi Larry!
I sent the modified patches as patch series separately.
I probably missed CCing you :/
The patch series can be found at:
https://lore.kernel.org/linux-wireless/20210110121525.2407-1-yashsri421@gmail.com/#t
Please review :)
Thanks
Aditya
prev parent reply other threads:[~2021-01-13 17:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-08 15:32 [PATCH] drivers: net: wireless: rtlwifi: fix bool comparison in expressions Aditya Srivastava
2021-01-08 19:41 ` Larry Finger
2021-01-10 12:15 ` [PATCH 0/5] " Aditya Srivastava
2021-01-10 12:15 ` [PATCH 1/5] rtlwifi: rtl_pci: " Aditya Srivastava
2021-01-25 14:22 ` Kalle Valo
2021-01-10 12:15 ` [PATCH 2/5] rtlwifi: rtl8192c-common: " Aditya Srivastava
2021-01-10 12:15 ` [PATCH 3/5] rtlwifi: rtl8188ee: " Aditya Srivastava
2021-01-10 12:15 ` [PATCH 4/5] rtlwifi: rtl8192se: " Aditya Srivastava
2021-01-10 12:15 ` [PATCH 5/5] rtlwifi: rtl8821ae: " Aditya Srivastava
2021-01-13 17:11 ` Aditya [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=37f9fb2c-56bb-b593-ae55-db8fce8304f9@gmail.com \
--to=yashsri421@gmail.com \
--cc=Larry.Finger@lwfinger.net \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lukas.bulwahn@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pkshih@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).