From: Ben Greear <greearb@candelatech.com>
To: Venkateswara Naralasetty <vnaralas@qti.qualcomm.com>,
Venkateswara Naralasetty <vnaralas@codeaurora.org>,
"ath10k@lists.infradead.org" <ath10k@lists.infradead.org>
Cc: Kan Yan <kyan@chromium.org>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [PATCHv2] ath10k: Add wrapper function to ath10k debug
Date: Fri, 26 Apr 2019 06:57:10 -0700 [thread overview]
Message-ID: <380a88cf-9da4-a772-a119-d8df24d5b450@candelatech.com> (raw)
In-Reply-To: <be151755e771423eaa0ad6e6e2e81c2b@APSANEXR01F.ap.qualcomm.com>
On 4/26/19 6:38 AM, Venkateswara Naralasetty wrote:
>>> #ifdef CONFIG_ATH10K_DEBUG
>>> -void ath10k_dbg(struct ath10k *ar, enum ath10k_debug_mask mask,
>>> - const char *fmt, ...)
>>> +void __ath10k_dbg(struct ath10k *ar, enum ath10k_debug_mask mask,
>>> + const char *fmt, ...)
>>> {
>>> struct va_format vaf;
>>> va_list args;
>>
>> Do you still need the check later in this method:
>>
>> if (ath10k_debug_mask & mask)
>>
>> since you already checked in the ath10k_dbg() macro?
> Yes, we need this check.
> Otherwise all debug messages will be printed even without any debug mask set in case of tracing enabled.
Ahh, I see.
Thanks,
Ben
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
next prev parent reply other threads:[~2019-04-26 13:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-26 12:58 [PATCHv2] ath10k: Add wrapper function to ath10k debug Venkateswara Naralasetty
2019-04-26 13:21 ` Ben Greear
2019-04-26 13:38 ` Venkateswara Naralasetty
2019-04-26 13:57 ` Ben Greear [this message]
2019-04-26 13:44 ` Michał Kazior
2019-04-26 13:56 ` Ben Greear
2019-04-30 6:13 ` Venkateswara Naralasetty
2019-05-09 12:48 ` Venkateswara Naralasetty
2019-06-25 12:49 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=380a88cf-9da4-a772-a119-d8df24d5b450@candelatech.com \
--to=greearb@candelatech.com \
--cc=ath10k@lists.infradead.org \
--cc=kyan@chromium.org \
--cc=linux-wireless@vger.kernel.org \
--cc=vnaralas@codeaurora.org \
--cc=vnaralas@qti.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).