From: "Jonas Dreßler" <verdre@v0yd.nl>
To: "Pali Rohár" <pali@kernel.org>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
Amitkumar Karwar <amitkarwar@gmail.com>,
Ganapathi Bhat <ganapathi017@gmail.com>,
Xinming Hu <huxinming820@gmail.com>,
Kalle Valo <kvalo@codeaurora.org>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Tsuchiya Yuto <kitakar@gmail.com>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
Maximilian Luz <luzmaximilian@gmail.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Bjorn Helgaas <bhelgaas@google.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
Johannes Berg <johannes@sipsolutions.net>,
Brian Norris <briannorris@chromium.org>,
David Laight <David.Laight@ACULAB.COM>,
Alex Williamson <alex.williamson@redhat.com>
Subject: Re: [PATCH] mwifiex: Add quirk resetting the PCI bridge on MS Surface devices
Date: Tue, 12 Oct 2021 13:20:46 +0200 [thread overview]
Message-ID: <3c98ea6c-b80f-59d4-ad84-85cf1c9ff440@v0yd.nl> (raw)
In-Reply-To: <20211012090037.v3w4za5hshtm253f@pali>
On 10/12/21 11:00, Pali Rohár wrote:
> On Tuesday 12 October 2021 10:48:49 Jonas Dreßler wrote:
>> 1) Revert the cards firmware in linux-firmware back to the second-latest
>> version. That firmware didn't report a fixed LTR value and also doesn't
>> have any other obvious issues I know of compared to the latest one.
>
> FYI, there are new bugs with new firmware versions for 8997 sent by NXP
> to linux-firmware repository... and questions what to do with it. Seems
> that NXP again do not respond to any questions after new version was
> merged into linux-firmware repo.
>
> https://lore.kernel.org/linux-firmware/edeb34bc-7c85-7f1d-79e4-e3e21df86334@gk2.net/
>
> So firmware revert also for other ex-Marvell / NXP chips is not
> something which could not happen.
>
Argh, nevermind, it seems like my memory is fooling me once again, sorry.
I just tried the older firmware and I was completely wrong, there's no
difference at all between the versions when it comes to LTR messages. So
there goes alternative 1).
Something interesting and reassuring I noticed though: After resuming from
suspend the firmware actually doesn't send a new LTR message, which means
now the LTR is 0 and we enter PC10/S0ix just fine. So basically the change
this patch does is already in effect, just after one suspend/resume cycle.
That gives me more confidence that we should maybe apply this patch for
all 8897 devices, not only Surface devices?
next prev parent reply other threads:[~2021-10-12 11:21 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-11 13:42 [PATCH] mwifiex: Add quirk resetting the PCI bridge on MS Surface devices Jonas Dreßler
2021-10-11 16:53 ` Bjorn Helgaas
2021-10-12 8:48 ` Jonas Dreßler
2021-10-12 9:00 ` Pali Rohár
2021-10-12 11:20 ` Jonas Dreßler [this message]
2021-10-12 11:29 ` Bjorn Helgaas
2021-10-13 21:35 ` Jonas Dreßler
2021-10-11 17:02 ` Pali Rohár
2021-10-12 8:55 ` Jonas Dreßler
2021-10-12 15:39 ` Bjorn Helgaas
2021-10-13 22:08 ` Jonas Dreßler
2021-10-18 15:35 ` Bjorn Helgaas
2021-10-25 16:45 ` Jonas Dreßler
2021-10-25 23:56 ` Bjorn Helgaas
2021-11-04 13:57 ` Jonas Dreßler
2021-10-18 12:27 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3c98ea6c-b80f-59d4-ad84-85cf1c9ff440@v0yd.nl \
--to=verdre@v0yd.nl \
--cc=David.Laight@ACULAB.COM \
--cc=alex.williamson@redhat.com \
--cc=amitkarwar@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bhelgaas@google.com \
--cc=briannorris@chromium.org \
--cc=davem@davemloft.net \
--cc=ganapathi017@gmail.com \
--cc=helgaas@kernel.org \
--cc=hkallweit1@gmail.com \
--cc=huxinming820@gmail.com \
--cc=johannes@sipsolutions.net \
--cc=kitakar@gmail.com \
--cc=kuba@kernel.org \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=luzmaximilian@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pali@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).