From: Igor Mitsyanko <igor.mitsyanko.os@quantenna.com>
To: Andrey Ryabinin <aryabinin@virtuozzo.com>,
Ryan Hsu <ryanhsu@qti.qualcomm.com>,
Kalle Valo <kvalo@qca.qualcomm.com>
Cc: Networking <netdev@vger.kernel.org>,
linux-wireless <linux-wireless@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
"ath10k@lists.infradead.org" <ath10k@lists.infradead.org>
Subject: Re: WARN_ON_ONCE(work > weight) in napi_poll()
Date: Tue, 11 Jul 2017 18:19:51 -0700 [thread overview]
Message-ID: <3ce246b3-b110-dd50-bf29-45ee78985872@quantenna.com> (raw)
In-Reply-To: <8cb28d9b-41c9-043c-16ca-f0bea41944e9@virtuozzo.com>
On 07/11/2017 10:28 AM, Andrey Ryabinin wrote:
>
> It gave me this:
>
> [118648.825347] #1 quota too big 72 64 16
> [118648.825351] #2 quota too big 72 64 16
> [118648.825471] ------------[ cut here ]------------
> [118648.825484] WARNING: CPU: 0 PID: 0 at ../net/core/dev.c:5274 net_rx_action+0x258/0x360
>
> So this means that we didn't met the condition bellow, i.e. skb_queue_empty() returned true.
>
> ath10k_htt_txrx_compl_task():
>
> if ((quota > ATH10K_NAPI_QUOTA_LIMIT) &&
> !skb_queue_empty(&htt->rx_in_ord_compl_q)) {
> resched_napi = true;
> goto exit;
> }
>
>> Also WLAN.RM.2.0-00180-QCARMSWPZ-1 firmware is a bit old, could you also update firmware to give it a try?
>> https://github.com/kvalo/ath10k-firmware/tree/master/QCA6174/hw3.0/4.4
>>
>
> Will try.
>
Maybe ath10k_htt_rx_in_ord_ind() has to accept "budget_left" parameter
and use it to limit number of processed MSDUs in queued AMSDU and saving
rest for later (NAPI has to be rescheduled in this case).
It seems natural that this problem happens with current logic, in case
AMSDU in Rx queue has more elements then left in budget.
next prev parent reply other threads:[~2017-07-12 1:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-30 16:34 WARN_ON_ONCE(work > weight) in napi_poll() Andrey Ryabinin
2017-07-04 13:49 ` Kalle Valo
2017-07-04 15:59 ` Andrey Ryabinin
2017-07-10 21:24 ` Ryan Hsu
2017-07-11 17:28 ` Andrey Ryabinin
2017-07-12 1:19 ` Igor Mitsyanko [this message]
2017-07-18 6:47 ` Ryan Hsu
2017-07-24 9:30 ` Andrey Ryabinin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3ce246b3-b110-dd50-bf29-45ee78985872@quantenna.com \
--to=igor.mitsyanko.os@quantenna.com \
--cc=aryabinin@virtuozzo.com \
--cc=ath10k@lists.infradead.org \
--cc=kvalo@qca.qualcomm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=ryanhsu@qti.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).